All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] waf: fix autobuilders failure
@ 2018-04-02 17:14 Maxime Hadjinlian
  2018-04-02 19:43 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Hadjinlian @ 2018-04-02 17:14 UTC (permalink / raw)
  To: buildroot

The package is host only and so the variable to use must be prefixed by
'HOST_'

Fixes:
	http://autobuild.buildroot.org/results/01d/01d8c21df4baa9ecc6a0e45744fe6a4d086a0652/

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/waf/waf.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/waf/waf.mk b/package/waf/waf.mk
index 639c26a3b0..cb738a38fd 100644
--- a/package/waf/waf.mk
+++ b/package/waf/waf.mk
@@ -9,7 +9,7 @@ WAF_SOURCE = waf-$(WAF_VERSION)
 WAF_SITE = https://waf.io/
 
 define HOST_WAF_EXTRACT_CMDS
-	$(INSTALL) -D -m 0755 $(WAF_DL_DIR)/waf-$(WAF_VERSION) $(@D)/waf
+	$(INSTALL) -D -m 0755 $(HOST_WAF_DL_DIR)/waf-$(WAF_VERSION) $(@D)/waf
 endef
 
 define HOST_WAF_INSTALL_CMDS
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] waf: fix autobuilders failure
  2018-04-02 17:14 [Buildroot] [PATCH] waf: fix autobuilders failure Maxime Hadjinlian
@ 2018-04-02 19:43 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-04-02 19:43 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  2 Apr 2018 19:14:27 +0200, Maxime Hadjinlian wrote:
> The package is host only and so the variable to use must be prefixed by
> 'HOST_'
> 
> Fixes:
> 	http://autobuild.buildroot.org/results/01d/01d8c21df4baa9ecc6a0e45744fe6a4d086a0652/
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/waf/waf.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master after adjusting the commit title and commit log.
Thanks!

However, I really think packages shouldn't have to use
HOST_<pkg>_DL_DIR, and therefore the infra should probably define
<pkg>_DL_DIR.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-02 19:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-02 17:14 [Buildroot] [PATCH] waf: fix autobuilders failure Maxime Hadjinlian
2018-04-02 19:43 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.