[PATCH] Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

[PATCH] Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

[Stefano Stabellini]

Add a short entry to the xl.cfg man page about pvcalls.
Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in
libxl.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
---
 docs/man/xl.cfg.pod.5.in | 7 +++++++
 tools/libxl/libxl.h      | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
index 2c1a6e1..47d8824 100644
--- a/docs/man/xl.cfg.pod.5.in
+++ b/docs/man/xl.cfg.pod.5.in
@@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
 
 =back
 
+=item B<pvcalls=[ "backend=domain-id", ... ]>
+
+Creates a Xen pvcalls connection to handle pvcalls requests from
+frontend to backend. It can be used as an alternative networking model.
+For more information about the protocol, see
+https://xenbits.xen.org/docs/unstable/misc/pvcalls.html.
+
 =item B<vfb=[ "VFB_SPEC_STRING", "VFB_SPEC_STRING", ...]>
 
 Specifies the paravirtual framebuffer devices which should be supplied
diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index bffc5a1..eea57ca 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -1127,6 +1127,13 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac *dst, const libxl_mac *src);
  */
 #define LIBXL_HAVE_PV_SHIM 1
 
+/*
+ * LIBXL_HAVE_PVCALLS
+ *
+ * If this is defined, libxl supports creating pvcalls interfaces.
+ */
+#define LIBXL_HAVE_PVCALLS 1
+
 typedef char **libxl_string_list;
 void libxl_string_list_dispose(libxl_string_list *sl);
 int libxl_string_list_length(const libxl_string_list *sl);
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

[Wei Liu]

On Fri, Mar 30, 2018 at 10:31:53AM -0700, Stefano Stabellini wrote:
> Add a short entry to the xl.cfg man page about pvcalls.
> Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in
> libxl.
> 
> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

[Roger Pau Monné]

On Fri, Mar 30, 2018 at 10:31:53AM -0700, Stefano Stabellini wrote:
> Add a short entry to the xl.cfg man page about pvcalls.
> Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in
> libxl.
> 
> Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> ---
>  docs/man/xl.cfg.pod.5.in | 7 +++++++
>  tools/libxl/libxl.h      | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> index 2c1a6e1..47d8824 100644
> --- a/docs/man/xl.cfg.pod.5.in
> +++ b/docs/man/xl.cfg.pod.5.in
> @@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
>  
>  =back
>  
> +=item B<pvcalls=[ "backend=domain-id", ... ]>

The 'backend' parameter in the disk config [0] contains the domain name,
not the domain id. I think it would be good to keep the same
semantics for both.

Thanks, Roger.

[0] https://xenbits.xen.org/docs/unstable/man/xl-disk-configuration.5.html

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] Add pvcalls info to xl man page and add missing LIBXL_HAVE_PVCALLS

[Wei Liu]

On Tue, Apr 03, 2018 at 11:29:07AM +0100, Roger Pau Monné wrote:
> On Fri, Mar 30, 2018 at 10:31:53AM -0700, Stefano Stabellini wrote:
> > Add a short entry to the xl.cfg man page about pvcalls.
> > Also add LIBXL_HAVE_PVCALLS to mark the presence of pvcalls support in
> > libxl.
> > 
> > Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
> > ---
> >  docs/man/xl.cfg.pod.5.in | 7 +++++++
> >  tools/libxl/libxl.h      | 7 +++++++
> >  2 files changed, 14 insertions(+)
> > 
> > diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
> > index 2c1a6e1..47d8824 100644
> > --- a/docs/man/xl.cfg.pod.5.in
> > +++ b/docs/man/xl.cfg.pod.5.in
> > @@ -685,6 +685,13 @@ Specify the backend domain name or id, defaults to dom0.
> >  
> >  =back
> >  
> > +=item B<pvcalls=[ "backend=domain-id", ... ]>
> 
> The 'backend' parameter in the disk config [0] contains the domain name,
> not the domain id. I think it would be good to keep the same
> semantics for both.
> 
> Thanks, Roger.
> 
> [0] https://xenbits.xen.org/docs/unstable/man/xl-disk-configuration.5.html

I think that's only a matter of ambiguous wording. It should support
both a name and a domid -- libxl__resolve_domid handles both.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel