* [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson.
@ 2018-04-03 22:48 Adam Sampson
2018-04-03 22:48 ` [igt-dev] [PATCH i-g-t 2/2] Test that register types are accepted in all valid forms Adam Sampson
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Adam Sampson @ 2018-04-03 22:48 UTC (permalink / raw)
To: Development mailing list for IGT GPU Tools; +Cc: Adam Sampson
When built with automake, the assembler's tokeniser is built with -i,
making it case-insensitive. This wasn't being done with meson.
(The symptom was build failures in intel-vaapi-driver, which uses
register types like ":ub". In lex.l, they're written as ":UB", so the
lexer was rejecting them without -i.)
Signed-off-by: Adam Sampson <ats@offog.org>
---
assembler/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/assembler/meson.build b/assembler/meson.build
index 7517d82f..c858bc0f 100644
--- a/assembler/meson.build
+++ b/assembler/meson.build
@@ -19,7 +19,7 @@ bison = find_program('bison')
lgen = generator(flex,
output : '@BASENAME@.c',
- arguments : ['-o', '@OUTPUT@', '@INPUT@'])
+ arguments : ['-i', '-o', '@OUTPUT@', '@INPUT@'])
lfiles = lgen.process('lex.l')
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] Test that register types are accepted in all valid forms.
2018-04-03 22:48 [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson Adam Sampson
@ 2018-04-03 22:48 ` Adam Sampson
2018-04-04 8:38 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Use flex -i when building with meson Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Adam Sampson @ 2018-04-03 22:48 UTC (permalink / raw)
To: Development mailing list for IGT GPU Tools; +Cc: Adam Sampson
The assembler should accept ub, :ub, UB and :UB.
Signed-off-by: Adam Sampson <ats@offog.org>
---
assembler/Makefile.am | 1 +
assembler/meson.build | 1 +
assembler/test/regtype.expected | 0
assembler/test/regtype.g4a | 6 ++++++
4 files changed, 8 insertions(+)
create mode 100644 assembler/test/regtype.expected
create mode 100644 assembler/test/regtype.g4a
diff --git a/assembler/Makefile.am b/assembler/Makefile.am
index 855e33ab..49422e02 100644
--- a/assembler/Makefile.am
+++ b/assembler/Makefile.am
@@ -52,6 +52,7 @@ check_SCRIPTS = test/run-test.sh
TESTS = \
test/mov \
test/frc \
+ test/regtype \
test/rndd \
test/rndu \
test/rnde \
diff --git a/assembler/meson.build b/assembler/meson.build
index c858bc0f..cefdba93 100644
--- a/assembler/meson.build
+++ b/assembler/meson.build
@@ -47,6 +47,7 @@ configure_file(input : 'intel-gen4asm.pc.in', output : 'intel-gen4asm.pc',
gen4asm_testcases = [
'test/mov',
'test/frc',
+ 'test/regtype',
'test/rndd',
'test/rndu',
'test/rnde',
diff --git a/assembler/test/regtype.expected b/assembler/test/regtype.expected
new file mode 100644
index 00000000..e69de29b
diff --git a/assembler/test/regtype.g4a b/assembler/test/regtype.g4a
new file mode 100644
index 00000000..8d7f8dd2
--- /dev/null
+++ b/assembler/test/regtype.g4a
@@ -0,0 +1,6 @@
+// Test that register types are accepted in upper or lower case, with and
+// without the : prefix.
+.default_register_type :ub
+.default_register_type :UB
+.default_register_type ub
+.default_register_type UB
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Use flex -i when building with meson.
2018-04-03 22:48 [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson Adam Sampson
2018-04-03 22:48 ` [igt-dev] [PATCH i-g-t 2/2] Test that register types are accepted in all valid forms Adam Sampson
@ 2018-04-04 8:38 ` Patchwork
2018-04-04 9:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-04 13:44 ` [igt-dev] [PATCH i-g-t 1/2] " Arkadiusz Hiler
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-04 8:38 UTC (permalink / raw)
To: Adam Sampson; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] Use flex -i when building with meson.
URL : https://patchwork.freedesktop.org/series/41118/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
cad5fc06f954546042a432202cbe7e5a20fe1132 tests/gem_eio: Add reset and unwedge stress testing
with latest DRM-Tip kernel build CI_DRM_4017
29940f138482 drm-tip: 2018y-04m-03d-13h-23m-36s UTC integration manifest
No testlist changes.
---- Known issues:
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-c:
fail -> PASS (fi-skl-6700k2) fdo#103191
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:432s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:444s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:382s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:537s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s
fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:516s
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:513s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:521s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:509s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:413s
fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:560s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:513s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:583s
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:426s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:317s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:486s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:405s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:422s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:475s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:432s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:477s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:465s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:508s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:659s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:444s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:531s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:500s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:510s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:429s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:448s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:605s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:398s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:535s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1221/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] Use flex -i when building with meson.
2018-04-03 22:48 [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson Adam Sampson
2018-04-03 22:48 ` [igt-dev] [PATCH i-g-t 2/2] Test that register types are accepted in all valid forms Adam Sampson
2018-04-04 8:38 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Use flex -i when building with meson Patchwork
@ 2018-04-04 9:25 ` Patchwork
2018-04-04 13:44 ` [igt-dev] [PATCH i-g-t 1/2] " Arkadiusz Hiler
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-04 9:25 UTC (permalink / raw)
To: Adam Sampson; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/2] Use flex -i when building with meson.
URL : https://patchwork.freedesktop.org/series/41118/
State : success
== Summary ==
---- Possible new issues:
Test kms_draw_crc:
Subgroup draw-method-xrgb8888-mmap-wc-untiled:
skip -> PASS (shard-snb)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
skip -> PASS (shard-snb)
Subgroup fbc-1p-primscrn-spr-indfb-move:
skip -> PASS (shard-snb)
Test prime_vgem:
Subgroup basic-fence-flip:
skip -> PASS (shard-snb)
---- Known issues:
Test kms_atomic_transition:
Subgroup 1x-modeset-transitions-nonblocking:
pass -> FAIL (shard-apl) fdo#103207
Test kms_flip:
Subgroup flip-vs-wf_vblank-interruptible:
pass -> FAIL (shard-hsw) fdo#100368 +2
Test kms_frontbuffer_tracking:
Subgroup fbc-stridechange:
fail -> PASS (shard-snb) fdo#105798 +4
Subgroup fbcpsr-2p-primscrn-shrfb-pgflip-blt:
fail -> SKIP (shard-snb) fdo#103167 +1
Test kms_mmap_write_crc:
dmesg-warn -> PASS (shard-hsw) fdo#103286
Test kms_plane_multiple:
Subgroup atomic-pipe-a-tiling-x:
pass -> FAIL (shard-snb) fdo#103166
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#105798 https://bugs.freedesktop.org/show_bug.cgi?id=105798
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103286 https://bugs.freedesktop.org/show_bug.cgi?id=103286
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
shard-apl total:3498 pass:1833 dwarn:1 dfail:0 fail:8 skip:1655 time:12953s
shard-hsw total:3498 pass:1783 dwarn:1 dfail:0 fail:3 skip:1710 time:11481s
shard-snb total:3498 pass:1376 dwarn:1 dfail:0 fail:6 skip:2115 time:7124s
Blacklisted hosts:
shard-kbl total:3498 pass:1944 dwarn:18 dfail:1 fail:7 skip:1528 time:9435s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1221/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson.
2018-04-03 22:48 [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson Adam Sampson
` (2 preceding siblings ...)
2018-04-04 9:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-04-04 13:44 ` Arkadiusz Hiler
3 siblings, 0 replies; 5+ messages in thread
From: Arkadiusz Hiler @ 2018-04-04 13:44 UTC (permalink / raw)
To: Adam Sampson; +Cc: Development mailing list for IGT GPU Tools
On Tue, Apr 03, 2018 at 11:48:43PM +0100, Adam Sampson wrote:
> When built with automake, the assembler's tokeniser is built with -i,
> making it case-insensitive. This wasn't being done with meson.
>
> (The symptom was build failures in intel-vaapi-driver, which uses
> register types like ":ub". In lex.l, they're written as ":UB", so the
> lexer was rejecting them without -i.)
>
> Signed-off-by: Adam Sampson <ats@offog.org>
Both patches are
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Thanks for spotting and fixing this :-)
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-04 13:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-03 22:48 [igt-dev] [PATCH i-g-t 1/2] Use flex -i when building with meson Adam Sampson
2018-04-03 22:48 ` [igt-dev] [PATCH i-g-t 2/2] Test that register types are accepted in all valid forms Adam Sampson
2018-04-04 8:38 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Use flex -i when building with meson Patchwork
2018-04-04 9:25 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-04 13:44 ` [igt-dev] [PATCH i-g-t 1/2] " Arkadiusz Hiler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.