From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size
Date: Thu, 5 Apr 2018 08:19:06 -0400 [thread overview]
Message-ID: <20180405121906.GA6274@sophia> (raw)
In-Reply-To: <20180405120012.7671-1-colin.king@canonical.com>
On Thu, Apr 05, 2018 at 01:00:12PM +0100, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Don't populate the const read-only array 'ports' on the stack but instead
>make it static. Makes the object code smaller by over 100 buytes:
>
>Before:
> text data bss dec hex filename
> 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o
>
>After:
> text data bss dec hex filename
> 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o
>
>(gcc version 7.2.0 x86_64)
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/gpio/gpio-104-dio-48e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c
>index 31e22c93e844..9c4e07fcb74b 100644
>--- a/drivers/gpio/gpio-104-dio-48e.c
>+++ b/drivers/gpio/gpio-104-dio-48e.c
>@@ -188,7 +188,7 @@ static int dio48e_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask,
> {
> struct dio48e_gpio *const dio48egpio = gpiochip_get_data(chip);
> size_t i;
>- const size_t ports[] = { 0, 1, 2, 4, 5, 6 };
>+ static const size_t ports[] = { 0, 1, 2, 4, 5, 6 };
> const unsigned int gpio_reg_size = 8;
> unsigned int bits_offset;
> size_t word_index;
>--
>2.15.1
>
If this makes gpio-104-dio-48e.o smaller, then it may be worthwhile to
apply similar changes to gpio-104-idi-48.c and gpio-gpio-mm.c which have
similar get_multiple callback implementations.
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size
Date: Thu, 05 Apr 2018 12:19:06 +0000 [thread overview]
Message-ID: <20180405121906.GA6274@sophia> (raw)
In-Reply-To: <20180405120012.7671-1-colin.king@canonical.com>
On Thu, Apr 05, 2018 at 01:00:12PM +0100, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Don't populate the const read-only array 'ports' on the stack but instead
>make it static. Makes the object code smaller by over 100 buytes:
>
>Before:
> text data bss dec hex filename
> 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o
>
>After:
> text data bss dec hex filename
> 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o
>
>(gcc version 7.2.0 x86_64)
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/gpio/gpio-104-dio-48e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c
>index 31e22c93e844..9c4e07fcb74b 100644
>--- a/drivers/gpio/gpio-104-dio-48e.c
>+++ b/drivers/gpio/gpio-104-dio-48e.c
>@@ -188,7 +188,7 @@ static int dio48e_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask,
> {
> struct dio48e_gpio *const dio48egpio = gpiochip_get_data(chip);
> size_t i;
>- const size_t ports[] = { 0, 1, 2, 4, 5, 6 };
>+ static const size_t ports[] = { 0, 1, 2, 4, 5, 6 };
> const unsigned int gpio_reg_size = 8;
> unsigned int bits_offset;
> size_t word_index;
>--
>2.15.1
>
If this makes gpio-104-dio-48e.o smaller, then it may be worthwhile to
apply similar changes to gpio-104-idi-48.c and gpio-gpio-mm.c which have
similar get_multiple callback implementations.
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
next prev parent reply other threads:[~2018-04-05 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 12:00 [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size Colin King
2018-04-05 12:00 ` Colin King
2018-04-05 12:19 ` William Breathitt Gray [this message]
2018-04-05 12:19 ` William Breathitt Gray
2018-04-26 9:06 ` Linus Walleij
2018-04-26 9:06 ` Linus Walleij
2018-04-26 13:02 ` William Breathitt Gray
2018-04-26 13:02 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405121906.GA6274@sophia \
--to=vilhelm.gray@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.