All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Vadim.Lomovtsev@caviumnetworks.com
Cc: sgoutham@cavium.com, sunil.kovvuri@gmail.com, rric@kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, dnelson@redhat.com,
	robin.murphy@arm.com, hch@infradead.org, gustavo@embeddedor.com,
	Vadim.Lomovtsev@cavium.com
Subject: Re: [PATCH v4] net: thunderx: rework mac addresses list to u64 array
Date: Sun, 08 Apr 2018 12:42:00 -0400 (EDT)	[thread overview]
Message-ID: <20180408.124200.2204489876311923873.davem@davemloft.net> (raw)
In-Reply-To: <20180406195354.16037-1-Vadim.Lomovtsev@caviumnetworks.com>

From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Date: Fri,  6 Apr 2018 12:53:54 -0700

> @@ -1929,7 +1929,7 @@ static void nicvf_set_rx_mode_task(struct work_struct *work_arg)
>  						  work.work);
>  	struct nicvf *nic = container_of(vf_work, struct nicvf, rx_mode_work);
>  	union nic_mbx mbx = {};
> -	struct xcast_addr *xaddr, *next;
> +	int idx = 0;

No need to initialize idx.

> +		for (idx = 0; idx < vf_work->mc->count; idx++) {

As it is always explicitly initialized at, and only used inside of,
this loop.

WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] net: thunderx: rework mac addresses list to u64 array
Date: Sun, 08 Apr 2018 12:42:00 -0400 (EDT)	[thread overview]
Message-ID: <20180408.124200.2204489876311923873.davem@davemloft.net> (raw)
In-Reply-To: <20180406195354.16037-1-Vadim.Lomovtsev@caviumnetworks.com>

From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Date: Fri,  6 Apr 2018 12:53:54 -0700

> @@ -1929,7 +1929,7 @@ static void nicvf_set_rx_mode_task(struct work_struct *work_arg)
>  						  work.work);
>  	struct nicvf *nic = container_of(vf_work, struct nicvf, rx_mode_work);
>  	union nic_mbx mbx = {};
> -	struct xcast_addr *xaddr, *next;
> +	int idx = 0;

No need to initialize idx.

> +		for (idx = 0; idx < vf_work->mc->count; idx++) {

As it is always explicitly initialized at, and only used inside of,
this loop.

  reply	other threads:[~2018-04-08 16:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 14:57 [PATCH] net: thunderx: rework mac addresses list to u64 array Vadim Lomovtsev
2018-04-05 14:57 ` Vadim Lomovtsev
2018-04-05 15:00 ` Vadim Lomovtsev
2018-04-05 15:00   ` Vadim Lomovtsev
2018-04-05 15:07 ` Christoph Hellwig
2018-04-05 15:07   ` Christoph Hellwig
2018-04-05 16:07   ` Vadim Lomovtsev
2018-04-05 16:07     ` Vadim Lomovtsev
2018-04-05 16:15     ` Christoph Hellwig
2018-04-05 16:15       ` Christoph Hellwig
2018-04-06 11:14 ` [PATCH v2] " Vadim Lomovtsev
2018-04-06 11:14   ` Vadim Lomovtsev
2018-04-06 11:36   ` Gustavo A. R. Silva
2018-04-06 11:36     ` Gustavo A. R. Silva
2018-04-06 11:43     ` Vadim Lomovtsev
2018-04-06 11:43       ` Vadim Lomovtsev
2018-04-06 11:47       ` Gustavo A. R. Silva
2018-04-06 11:47         ` Gustavo A. R. Silva
2018-04-06 11:53         ` Vadim Lomovtsev
2018-04-06 11:53           ` Vadim Lomovtsev
2018-04-06 11:48   ` Robin Murphy
2018-04-06 11:48     ` Robin Murphy
2018-04-06 12:07     ` Vadim Lomovtsev
2018-04-06 12:07       ` Vadim Lomovtsev
2018-04-06 14:04   ` [PATCH v3] " Vadim Lomovtsev
2018-04-06 14:04     ` Vadim Lomovtsev
2018-04-06 15:16     ` Vadim Lomovtsev
2018-04-06 15:16       ` Vadim Lomovtsev
2018-04-06 19:53     ` [PATCH v4] " Vadim Lomovtsev
2018-04-06 19:53       ` Vadim Lomovtsev
2018-04-08 16:42       ` David Miller [this message]
2018-04-08 16:42         ` David Miller
2018-04-09  9:42         ` Vadim Lomovtsev
2018-04-09  9:42           ` Vadim Lomovtsev
2018-04-09 13:24       ` [PATCH v5] " Vadim Lomovtsev
2018-04-09 13:24         ` Vadim Lomovtsev
2018-04-09 15:00         ` David Miller
2018-04-09 15:00           ` David Miller
2018-04-06 15:06   ` [PATCH v2] " David Miller
2018-04-06 15:06     ` David Miller
2018-04-06 15:14     ` Vadim Lomovtsev
2018-04-06 15:14       ` Vadim Lomovtsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180408.124200.2204489876311923873.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Vadim.Lomovtsev@cavium.com \
    --cc=Vadim.Lomovtsev@caviumnetworks.com \
    --cc=dnelson@redhat.com \
    --cc=gustavo@embeddedor.com \
    --cc=hch@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=rric@kernel.org \
    --cc=sgoutham@cavium.com \
    --cc=sunil.kovvuri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.