All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel@ffwll.ch (Daniel Vetter)
To: linux-snps-arc@lists.infradead.org
Subject: DRM_UDL and GPU under Xserver
Date: Mon, 9 Apr 2018 11:17:06 +0200	[thread overview]
Message-ID: <20180409091706.GU31310@phenom.ffwll.local> (raw)
In-Reply-To: <1523264135.5268.14.camel@synopsys.com>

On Mon, Apr 09, 2018@08:55:36AM +0000, Alexey Brodkin wrote:
> Hi Daniel,
> 
> On Mon, 2018-04-09@10:31 +0200, Daniel Vetter wrote:
> > On Thu, Apr 05, 2018@06:39:41PM +0000, Alexey Brodkin wrote:
> > > Hi Daniel, all,
> 
> [snip]
> 
> > > Ok it was quite some time ago so I forgot about that completely.
> > > I really made one trivial change in xf86-video-armada:
> > > ------------------------>8--------------------------
> > > --- a/src/armada_module.c
> > > +++ b/src/armada_module.c
> > > @@ -26,7 +26,7 @@
> > >  #define ARMADA_NAME            "armada"
> > >  #define ARMADA_DRIVER_NAME     "armada"
> > >  
> > > -#define DRM_MODULE_NAMES       "armada-drm", "imx-drm"
> > > +#define DRM_MODULE_NAMES       "armada-drm", "imx-drm", "udl"
> > >  #define DRM_DEFAULT_BUS_ID     NULL
> > > ------------------------>8--------------------------
> > > 
> > > Otherwise Xserver fails on start which is expected given "imx-drm" is intentionally removed.
> 
> Here I meant I explicitly disabled DRM_IMX in the kernel configuraion
> so that it is not used in run-time.
> 
> > You need to keep imx-drm around. And then light up the udl display using
> > prime. Afaiui it should all just work (but with maybe a few disconnected
> > outputs from imx-drm around that you don't need, but that's not a
> > problem).
> 
> And given my comment above I don't really see any difference between
> DRM_IMX and DRM_UDL (except their HW implmentation which I guess should
> not bother upper layers) so why do wee need to treat them differently?
> 
> Most probably I'm missing something but my thought was if we have
> 2 equally well supported KMS devices we may easily swap them and still
> have resulting setup functional.

armada is not a generic drm driver, but can only be used for armada-drm
and imx-drm. You can't just use it with any drm device, for that you need
a generic driver like -modesetting.

Just enable all the drivers you have for your hw, and it should work.
Hacking on drivers without knowing what they expect tends to not work so
well.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"airlied@redhat.com" <airlied@redhat.com>,
	"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
	"daniel.vetter@intel.com" <daniel.vetter@intel.com>,
	"linux-snps-arc@lists.infradead.org"
	<linux-snps-arc@lists.infradead.org>
Subject: Re: DRM_UDL and GPU under Xserver
Date: Mon, 9 Apr 2018 11:17:06 +0200	[thread overview]
Message-ID: <20180409091706.GU31310@phenom.ffwll.local> (raw)
In-Reply-To: <1523264135.5268.14.camel@synopsys.com>

On Mon, Apr 09, 2018 at 08:55:36AM +0000, Alexey Brodkin wrote:
> Hi Daniel,
> 
> On Mon, 2018-04-09 at 10:31 +0200, Daniel Vetter wrote:
> > On Thu, Apr 05, 2018 at 06:39:41PM +0000, Alexey Brodkin wrote:
> > > Hi Daniel, all,
> 
> [snip]
> 
> > > Ok it was quite some time ago so I forgot about that completely.
> > > I really made one trivial change in xf86-video-armada:
> > > ------------------------>8--------------------------
> > > --- a/src/armada_module.c
> > > +++ b/src/armada_module.c
> > > @@ -26,7 +26,7 @@
> > >  #define ARMADA_NAME            "armada"
> > >  #define ARMADA_DRIVER_NAME     "armada"
> > >  
> > > -#define DRM_MODULE_NAMES       "armada-drm", "imx-drm"
> > > +#define DRM_MODULE_NAMES       "armada-drm", "imx-drm", "udl"
> > >  #define DRM_DEFAULT_BUS_ID     NULL
> > > ------------------------>8--------------------------
> > > 
> > > Otherwise Xserver fails on start which is expected given "imx-drm" is intentionally removed.
> 
> Here I meant I explicitly disabled DRM_IMX in the kernel configuraion
> so that it is not used in run-time.
> 
> > You need to keep imx-drm around. And then light up the udl display using
> > prime. Afaiui it should all just work (but with maybe a few disconnected
> > outputs from imx-drm around that you don't need, but that's not a
> > problem).
> 
> And given my comment above I don't really see any difference between
> DRM_IMX and DRM_UDL (except their HW implmentation which I guess should
> not bother upper layers) so why do wee need to treat them differently?
> 
> Most probably I'm missing something but my thought was if we have
> 2 equally well supported KMS devices we may easily swap them and still
> have resulting setup functional.

armada is not a generic drm driver, but can only be used for armada-drm
and imx-drm. You can't just use it with any drm device, for that you need
a generic driver like -modesetting.

Just enable all the drivers you have for your hw, and it should work.
Hacking on drivers without knowing what they expect tends to not work so
well.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-04-09  9:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04 20:06 DRM_UDL and GPU under Xserver Alexey Brodkin
2018-04-04 20:06 ` Alexey Brodkin
2018-04-05  6:18 ` Daniel Vetter
2018-04-05  6:18   ` Daniel Vetter
2018-04-05  7:16   ` Alexey Brodkin
2018-04-05  7:16     ` Alexey Brodkin
2018-04-05  9:32     ` Daniel Vetter
2018-04-05  9:32       ` Daniel Vetter
2018-04-05 10:10       ` Jose Abreu
2018-04-05 10:10         ` Jose Abreu
2018-04-05 10:29       ` Lucas Stach
2018-04-05 10:29         ` Lucas Stach
2018-04-05 10:59         ` Daniel Vetter
2018-04-05 10:59           ` Daniel Vetter
2018-04-05 11:10           ` Alexey Brodkin
2018-04-05 11:10             ` Alexey Brodkin
2018-04-05 13:44             ` Daniel Vetter
2018-04-05 13:44               ` Daniel Vetter
2018-04-05 18:39               ` Alexey Brodkin
2018-04-05 18:39                 ` Alexey Brodkin
2018-04-09  8:31                 ` Daniel Vetter
2018-04-09  8:31                   ` Daniel Vetter
2018-04-09  8:55                   ` Alexey Brodkin
2018-04-09  8:55                     ` Alexey Brodkin
2018-04-09  9:17                     ` Daniel Vetter [this message]
2018-04-09  9:17                       ` Daniel Vetter
2018-04-09  9:45                       ` Alexey Brodkin
2018-04-09  9:45                         ` Alexey Brodkin
2018-04-13 15:52                         ` Daniel Vetter
2018-04-13 15:52                           ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180409091706.GU31310@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.