[PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Chris Wilson]

If we try to suspend a wedged device following a GPU reset failure, we
will also fail to turn off the rc6 powerwells (on vlv), leading to a
*ERROR*. This is quite expected in this case, so the best we can do is
shake our heads and reduce the *ERROR* to a debug so CI stops
complaining.

Testcase: igt/gem_eio/in-flight-suspend #vlv
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index f770be18b2d7..db6fc176ec3c 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -2462,10 +2462,13 @@ static void vlv_wait_for_gt_wells(struct drm_i915_private *dev_priv,
 	/*
 	 * RC6 transitioning can be delayed up to 2 msec (see
 	 * valleyview_enable_rps), use 3 msec for safety.
+	 *
+	 * This can fail to turn off the rc6 if the GPU is stuck after a failed
+	 * reset and we are trying to force the machine to sleep.
 	 */
 	if (vlv_wait_for_pw_status(dev_priv, mask, val))
-		DRM_ERROR("timeout waiting for GT wells to go %s\n",
-			  onoff(wait_for_on));
+		DRM_DEBUG_DRIVER("timeout waiting for GT wells to go %s\n",
+				 onoff(wait_for_on));
 }
 
 static void vlv_check_no_gt_access(struct drm_i915_private *dev_priv)
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Chris Wilson]

Quoting Chris Wilson (2018-04-09 10:49:05)
> If we try to suspend a wedged device following a GPU reset failure, we
> will also fail to turn off the rc6 powerwells (on vlv), leading to a
> *ERROR*. This is quite expected in this case, so the best we can do is
> shake our heads and reduce the *ERROR* to a debug so CI stops
> complaining.
> 
> Testcase: igt/gem_eio/in-flight-suspend #vlv
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105583
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Patchwork]

== Series Details ==

Series: drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells
URL   : https://patchwork.freedesktop.org/series/41350/
State : success

== Summary ==

Series 41350v1 drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells
https://patchwork.freedesktop.org/api/1.0/series/41350/revisions/1/mbox/

---- Known issues:

Test debugfs_test:
        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713
Test gem_ctx_param:
        Subgroup basic-default:
                incomplete -> PASS       (fi-cnl-y3) fdo#105086
Test kms_chamelium:
        Subgroup dp-edid-read:
                fail       -> PASS       (fi-kbl-7500u) fdo#102505
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (fi-cfl-s3) fdo#100368
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                pass       -> INCOMPLETE (fi-bxt-dsi) fdo#103927

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#105086 https://bugs.freedesktop.org/show_bug.cgi?id=105086
fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:434s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:379s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:542s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:299s
fi-bxt-dsi       total:243  pass:216  dwarn:0   dfail:0   fail:0   skip:26 
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:512s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:521s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:509s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:410s
fi-cfl-s3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:561s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:510s
fi-cnl-y3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:588s
fi-elk-e7500     total:285  pass:226  dwarn:0   dfail:0   fail:0   skip:59  time:429s
fi-gdg-551       total:285  pass:176  dwarn:0   dfail:0   fail:1   skip:108 time:317s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:540s
fi-glk-j4005     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:403s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:420s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:441s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:470s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:463s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:508s
fi-pnv-d510      total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:666s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:438s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:544s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:503s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:499s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:426s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:446s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:584s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:403s

1be073153147c5c39cdcbdfdeb4e2595ba595bf7 drm-tip: 2018y-04m-07d-22h-26m-31s UTC integration manifest
a64a9e12899b drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8636/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Patchwork]

== Series Details ==

Series: drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells
URL   : https://patchwork.freedesktop.org/series/41350/
State : success

== Summary ==

---- Possible new issues:

Test gem_pwrite:
        Subgroup big-gtt-backwards:
                skip       -> PASS       (shard-apl)

---- Known issues:

Test kms_flip:
        Subgroup 2x-flip-vs-expired-vblank-interruptible:
                fail       -> PASS       (shard-hsw) fdo#102887 +1
        Subgroup 2x-plain-flip-fb-recreate:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_sysfs_edid_timing:
                pass       -> WARN       (shard-apl) fdo#100047

fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047

shard-apl        total:2680 pass:1835 dwarn:1   dfail:0   fail:7   skip:836 time:12699s
shard-hsw        total:2680 pass:1785 dwarn:1   dfail:0   fail:2   skip:891 time:11415s
Blacklisted hosts:
shard-kbl        total:2680 pass:1962 dwarn:2   dfail:0   fail:7   skip:709 time:9180s
shard-snb        total:2680 pass:1377 dwarn:1   dfail:0   fail:3   skip:1299 time:6908s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8636/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Chris Wilson]

Quoting Chris Wilson (2018-04-09 10:54:46)
> Quoting Chris Wilson (2018-04-09 10:49:05)
> > If we try to suspend a wedged device following a GPU reset failure, we
> > will also fail to turn off the rc6 powerwells (on vlv), leading to a
> > *ERROR*. This is quite expected in this case, so the best we can do is
> > shake our heads and reduce the *ERROR* to a debug so CI stops
> > complaining.
> > 
> > Testcase: igt/gem_eio/in-flight-suspend #vlv
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105583

Does anyone want to keep this *ERROR* that we can trigger at will?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Jani Nikula]

On Wed, 02 May 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Chris Wilson (2018-04-09 10:54:46)
>> Quoting Chris Wilson (2018-04-09 10:49:05)
>> > If we try to suspend a wedged device following a GPU reset failure, we
>> > will also fail to turn off the rc6 powerwells (on vlv), leading to a
>> > *ERROR*. This is quite expected in this case, so the best we can do is
>> > shake our heads and reduce the *ERROR* to a debug so CI stops
>> > complaining.
>> > 
>> > Testcase: igt/gem_eio/in-flight-suspend #vlv
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105583
>
> Does anyone want to keep this *ERROR* that we can trigger at will?

No strong feelings. I guess my question is, can this happen when there's
no GPU reset failures, and the change would silence that?

Anyway, if it makes CI less noisy,

Acked-by: Jani Nikula <jani.nikula@intel.com>






-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Silence debugging DRM_ERROR for failing to suspend vlv powerwells

[Chris Wilson]

Quoting Jani Nikula (2018-05-03 09:58:17)
> On Wed, 02 May 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Chris Wilson (2018-04-09 10:54:46)
> >> Quoting Chris Wilson (2018-04-09 10:49:05)
> >> > If we try to suspend a wedged device following a GPU reset failure, we
> >> > will also fail to turn off the rc6 powerwells (on vlv), leading to a
> >> > *ERROR*. This is quite expected in this case, so the best we can do is
> >> > shake our heads and reduce the *ERROR* to a debug so CI stops
> >> > complaining.
> >> > 
> >> > Testcase: igt/gem_eio/in-flight-suspend #vlv
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105583
> >
> > Does anyone want to keep this *ERROR* that we can trigger at will?
> 
> No strong feelings. I guess my question is, can this happen when there's
> no GPU reset failures, and the change would silence that?

It hasn't occurred yet, but we see reset failures in the wild (just not
on byt afair). From the code pov, it is marked as a debug feature and
called before system suspend, so should be harmless (famous last words).
 
> Anyway, if it makes CI less noisy,
> 
> Acked-by: Jani Nikula <jani.nikula@intel.com>

Thanks,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx