All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries
@ 2018-04-09  9:46 Valentin Korenblit
  2018-04-09  9:46 ` [Buildroot] [PATCH 2/2] package/llvm: add dependency on wchar Valentin Korenblit
  2018-04-09 19:11 ` [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries Thomas Petazzoni
  0 siblings, 2 replies; 5+ messages in thread
From: Valentin Korenblit @ 2018-04-09  9:46 UTC (permalink / raw)
  To: buildroot

llvm generates libLLVM.so, so it won't work if BR2_STATIC_LIBS is set

Also propagate llvm dependency to mesa3d.

Link to report from autobuilders:
http://lists.busybox.net/pipermail/buildroot/2018-April/218296.html

Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
---
 package/llvm/Config.in   | 6 ++++--
 package/mesa3d/Config.in | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/package/llvm/Config.in b/package/llvm/Config.in
index 15f2507ef2..e007397fa7 100644
--- a/package/llvm/Config.in
+++ b/package/llvm/Config.in
@@ -19,6 +19,7 @@ config BR2_PACKAGE_LLVM
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
+	depends on !BR2_STATIC_LIBS
 	help
 	  The LLVM Project is a collection of modular and reusable
 	  compiler and toolchain technologies.
@@ -35,10 +36,11 @@ config BR2_PACKAGE_LLVM_AMDGPU
 
 endif
 
-comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8"
+comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
-		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
+		|| BR2_STATIC_LIBS
 
 comment "llvm needs a toolchain not affected by GCC bug 64735"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 8f347ffe0c..7dab883aad 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -33,12 +33,14 @@ config BR2_PACKAGE_MESA3D_LLVM
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_LLVM
 
-comment "llvm support needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8"
+comment "llvm support needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
-		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
+		|| BR2_STATIC_LIBS
 
 comment "llvm support needs a toolchain not affected by GCC bug 64735"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] package/llvm: add dependency on wchar
  2018-04-09  9:46 [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries Valentin Korenblit
@ 2018-04-09  9:46 ` Valentin Korenblit
  2018-04-09 19:11 ` [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Valentin Korenblit @ 2018-04-09  9:46 UTC (permalink / raw)
  To: buildroot

Extract from log:

output/build/llvm-5.0.1/include/llvm/Support/ConvertUTF.h:203:53:
error: ?std::wstring? has not been declared
bool ConvertUTF8toWide(llvm::StringRef Source, std::wstring &Result);

Also propagate dependency to mesa3d

Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
---
 package/llvm/Config.in   | 5 +++--
 package/mesa3d/Config.in | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/package/llvm/Config.in b/package/llvm/Config.in
index e007397fa7..83e94660eb 100644
--- a/package/llvm/Config.in
+++ b/package/llvm/Config.in
@@ -20,6 +20,7 @@ config BR2_PACKAGE_LLVM
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_USE_WCHAR # std::wstring
 	help
 	  The LLVM Project is a collection of modular and reusable
 	  compiler and toolchain technologies.
@@ -36,11 +37,11 @@ config BR2_PACKAGE_LLVM_AMDGPU
 
 endif
 
-comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
+comment "llvm needs a toolchain w/ wchar, threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
-		|| BR2_STATIC_LIBS
+		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR
 
 comment "llvm needs a toolchain not affected by GCC bug 64735"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 7dab883aad..1476b39acc 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -34,13 +34,14 @@ config BR2_PACKAGE_MESA3D_LLVM
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_USE_WCHAR # std::wstring
 	select BR2_PACKAGE_LLVM
 
-comment "llvm support needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
+comment "llvm support needs a toolchain w/ wchar, threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
-		|| BR2_STATIC_LIBS
+		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR
 
 comment "llvm support needs a toolchain not affected by GCC bug 64735"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries
  2018-04-09  9:46 [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries Valentin Korenblit
  2018-04-09  9:46 ` [Buildroot] [PATCH 2/2] package/llvm: add dependency on wchar Valentin Korenblit
@ 2018-04-09 19:11 ` Thomas Petazzoni
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-04-09 19:11 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  9 Apr 2018 11:46:06 +0200, Valentin Korenblit wrote:
> llvm generates libLLVM.so, so it won't work if BR2_STATIC_LIBS is set
> 
> Also propagate llvm dependency to mesa3d.
> 
> Link to report from autobuilders:
> http://lists.busybox.net/pipermail/buildroot/2018-April/218296.html
> 
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
> ---
>  package/llvm/Config.in   | 6 ++++--
>  package/mesa3d/Config.in | 6 ++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)

Both applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries
  2018-04-07  8:31 Valentin Korenblit
@ 2018-04-07 15:21 ` Romain Naour
  0 siblings, 0 replies; 5+ messages in thread
From: Romain Naour @ 2018-04-07 15:21 UTC (permalink / raw)
  To: buildroot

Hi Valentin,

Le 07/04/2018 ? 10:31, Valentin Korenblit a ?crit?:
> llvm generates libLLVM.so, so it won't work if BR2_STATIC_LIBS is set

You can add a link to the report [1] or copy past it.

[1] http://lists.busybox.net/pipermail/buildroot/2018-April/218296.html

Best regards,
Romain

> 
> Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
> ---
>  package/llvm/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/llvm/Config.in b/package/llvm/Config.in
> index 15f2507ef2..e007397fa7 100644
> --- a/package/llvm/Config.in
> +++ b/package/llvm/Config.in
> @@ -19,6 +19,7 @@ config BR2_PACKAGE_LLVM
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
> +	depends on !BR2_STATIC_LIBS
>  	help
>  	  The LLVM Project is a collection of modular and reusable
>  	  compiler and toolchain technologies.
> @@ -35,10 +36,11 @@ config BR2_PACKAGE_LLVM_AMDGPU
>  
>  endif
>  
> -comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8"
> +comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
>  	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
> -		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> +		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
> +		|| BR2_STATIC_LIBS
>  
>  comment "llvm needs a toolchain not affected by GCC bug 64735"
>  	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries
@ 2018-04-07  8:31 Valentin Korenblit
  2018-04-07 15:21 ` Romain Naour
  0 siblings, 1 reply; 5+ messages in thread
From: Valentin Korenblit @ 2018-04-07  8:31 UTC (permalink / raw)
  To: buildroot

llvm generates libLLVM.so, so it won't work if BR2_STATIC_LIBS is set

Signed-off-by: Valentin Korenblit <valentin.korenblit@smile.fr>
---
 package/llvm/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/llvm/Config.in b/package/llvm/Config.in
index 15f2507ef2..e007397fa7 100644
--- a/package/llvm/Config.in
+++ b/package/llvm/Config.in
@@ -19,6 +19,7 @@ config BR2_PACKAGE_LLVM
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::shared_future
+	depends on !BR2_STATIC_LIBS
 	help
 	  The LLVM Project is a collection of modular and reusable
 	  compiler and toolchain technologies.
@@ -35,10 +36,11 @@ config BR2_PACKAGE_LLVM_AMDGPU
 
 endif
 
-comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8"
+comment "llvm needs a toolchain w/ threads, C++, gcc >= 4.8, host gcc >= 4.8, dynamic library"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
-		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
+		|| BR2_STATIC_LIBS
 
 comment "llvm needs a toolchain not affected by GCC bug 64735"
 	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-09 19:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09  9:46 [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries Valentin Korenblit
2018-04-09  9:46 ` [Buildroot] [PATCH 2/2] package/llvm: add dependency on wchar Valentin Korenblit
2018-04-09 19:11 ` [Buildroot] [PATCH 1/2] package/llvm: add dependency on shared libraries Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2018-04-07  8:31 Valentin Korenblit
2018-04-07 15:21 ` Romain Naour

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.