All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Tobias Regnery <tobias.regnery@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error
Date: Tue, 10 Apr 2018 10:39:06 +0300	[thread overview]
Message-ID: <20180410073906.GC10141@kuha.fi.intel.com> (raw)
In-Reply-To: <20180409114053.GA9417@builder>

Hi Tobias,

On Mon, Apr 09, 2018 at 01:40:53PM +0200, Tobias Regnery wrote:
> You are right, building a defconfig, enable the UCSI driver and disable
> CONFIG_FTRACE indeed builds without problems. So it must be some other
> combination of config options. Attached is the randconfig which triggers
> the problem with linux-next from today.
> 
> Regardless of the root cause, building trace.c conditionally on
> CONFIG_TRACING works and the build failure goes away. Grepping through
> the tree this seems to be the right option to depend on, as other users
> of tracepoints are doing the same.

Fair enough. I'll send a fix for that.


Thanks,

-- 
heikki

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Tobias Regnery <tobias.regnery@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: usb: typec: ucsi: fix tracepoint related build error
Date: Tue, 10 Apr 2018 10:39:06 +0300	[thread overview]
Message-ID: <20180410073906.GC10141@kuha.fi.intel.com> (raw)

Hi Tobias,

On Mon, Apr 09, 2018 at 01:40:53PM +0200, Tobias Regnery wrote:
> You are right, building a defconfig, enable the UCSI driver and disable
> CONFIG_FTRACE indeed builds without problems. So it must be some other
> combination of config options. Attached is the randconfig which triggers
> the problem with linux-next from today.
> 
> Regardless of the root cause, building trace.c conditionally on
> CONFIG_TRACING works and the build failure goes away. Grepping through
> the tree this seems to be the right option to depend on, as other users
> of tracepoints are doing the same.

Fair enough. I'll send a fix for that.


Thanks,

  reply	other threads:[~2018-04-10  7:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09  7:55 [PATCH] usb: typec: ucsi: fix tracepoint related build error Tobias Regnery
2018-04-09  7:55 ` Tobias Regnery
2018-04-09 10:01 ` [PATCH] " Heikki Krogerus
2018-04-09 10:01   ` Heikki Krogerus
2018-04-09 11:40   ` [PATCH] " Tobias Regnery
2018-04-09 11:40     ` Tobias Regnery
2018-04-10  7:39     ` Heikki Krogerus [this message]
2018-04-10  7:39       ` Heikki Krogerus
2018-04-10  8:05     ` [PATCH] " Tobias Regnery
2018-04-10  8:05       ` Tobias Regnery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410073906.GC10141@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tobias.regnery@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.