* [PATCH] usb: typec: ucsi: fix link error on randconfig
@ 2018-04-10 7:51 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2018-04-10 7:51 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Tobias Regnery, linux-usb, stable
If building a kernel without FTRACE but with TRACING,
ucsi.ko fails to link due to missing trace events. Fix this
by using the correct Kconfig symbol on Makefile.
Reported-by: Tobias Regnery <tobias.regnery@gmail.com>
Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
Cc: <stable@vger.kernel.org>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/usb/typec/ucsi/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi/Makefile
index b57891c1fd31..7afbea512207 100644
--- a/drivers/usb/typec/ucsi/Makefile
+++ b/drivers/usb/typec/ucsi/Makefile
@@ -5,6 +5,6 @@ obj-$(CONFIG_TYPEC_UCSI) += typec_ucsi.o
typec_ucsi-y := ucsi.o
-typec_ucsi-$(CONFIG_FTRACE) += trace.o
+typec_ucsi-$(CONFIG_TRACING) += trace.o
obj-$(CONFIG_UCSI_ACPI) += ucsi_acpi.o
--
2.16.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* usb: typec: ucsi: fix link error on randconfig
@ 2018-04-10 7:51 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2018-04-10 7:51 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Tobias Regnery, linux-usb, stable
If building a kernel without FTRACE but with TRACING,
ucsi.ko fails to link due to missing trace events. Fix this
by using the correct Kconfig symbol on Makefile.
Reported-by: Tobias Regnery <tobias.regnery@gmail.com>
Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
Cc: <stable@vger.kernel.org>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/usb/typec/ucsi/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi/Makefile
index b57891c1fd31..7afbea512207 100644
--- a/drivers/usb/typec/ucsi/Makefile
+++ b/drivers/usb/typec/ucsi/Makefile
@@ -5,6 +5,6 @@ obj-$(CONFIG_TYPEC_UCSI) += typec_ucsi.o
typec_ucsi-y := ucsi.o
-typec_ucsi-$(CONFIG_FTRACE) += trace.o
+typec_ucsi-$(CONFIG_TRACING) += trace.o
obj-$(CONFIG_UCSI_ACPI) += ucsi_acpi.o
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: ucsi: fix link error on randconfig
@ 2018-04-12 7:25 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2018-04-12 7:25 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Tobias Regnery, linux-usb, stable
On Tue, Apr 10, 2018 at 10:51:13AM +0300, Heikki Krogerus wrote:
> If building a kernel without FTRACE but with TRACING,
> ucsi.ko fails to link due to missing trace events. Fix this
> by using the correct Kconfig symbol on Makefile.
>
> Reported-by: Tobias Regnery <tobias.regnery@gmail.com>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi/Makefile
> index b57891c1fd31..7afbea512207 100644
> --- a/drivers/usb/typec/ucsi/Makefile
> +++ b/drivers/usb/typec/ucsi/Makefile
> @@ -5,6 +5,6 @@ obj-$(CONFIG_TYPEC_UCSI) += typec_ucsi.o
>
> typec_ucsi-y := ucsi.o
>
> -typec_ucsi-$(CONFIG_FTRACE) += trace.o
> +typec_ucsi-$(CONFIG_TRACING) += trace.o
>
> obj-$(CONFIG_UCSI_ACPI) += ucsi_acpi.o
Tobias send his own version for this. His patch has a better
explanation, so let's use that instead.
Thanks,
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
* usb: typec: ucsi: fix link error on randconfig
@ 2018-04-12 7:25 ` Heikki Krogerus
0 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2018-04-12 7:25 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Tobias Regnery, linux-usb, stable
On Tue, Apr 10, 2018 at 10:51:13AM +0300, Heikki Krogerus wrote:
> If building a kernel without FTRACE but with TRACING,
> ucsi.ko fails to link due to missing trace events. Fix this
> by using the correct Kconfig symbol on Makefile.
>
> Reported-by: Tobias Regnery <tobias.regnery@gmail.com>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi/Makefile
> index b57891c1fd31..7afbea512207 100644
> --- a/drivers/usb/typec/ucsi/Makefile
> +++ b/drivers/usb/typec/ucsi/Makefile
> @@ -5,6 +5,6 @@ obj-$(CONFIG_TYPEC_UCSI) += typec_ucsi.o
>
> typec_ucsi-y := ucsi.o
>
> -typec_ucsi-$(CONFIG_FTRACE) += trace.o
> +typec_ucsi-$(CONFIG_TRACING) += trace.o
>
> obj-$(CONFIG_UCSI_ACPI) += ucsi_acpi.o
Tobias send his own version for this. His patch has a better
explanation, so let's use that instead.
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-12 7:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 7:51 [PATCH] usb: typec: ucsi: fix link error on randconfig Heikki Krogerus
2018-04-10 7:51 ` Heikki Krogerus
2018-04-12 7:25 ` [PATCH] " Heikki Krogerus
2018-04-12 7:25 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.