From: Boris Brezillon <boris.brezillon@bootlin.com> To: David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Boris Brezillon <boris.brezillon@bootlin.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, linux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>, Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org Cc: "Yogesh Gaur" <yogeshnarayan.gaur@nxp.com>, "Vignesh R" <vigneshr@ti.com>, "Kamal Dasu" <kdasu.kdev@gmail.com>, "Maxime Chevallier" <maxime.chevallier@bootlin.com>, "Peter Pan" <peterpansjtu@gmail.com>, "Frieder Schrempf" <frieder.schrempf@exceet.de>, "Rafał Miłecki" <rafal@milecki.pl>, "Sourav Poddar" <sourav.poddar@ti.com> Subject: [PATCH v2 03/10] spi: Add an helper to flush the message queue Date: Wed, 11 Apr 2018 00:44:32 +0200 [thread overview] Message-ID: <20180410224439.9260-4-boris.brezillon@bootlin.com> (raw) In-Reply-To: <20180410224439.9260-1-boris.brezillon@bootlin.com> This is needed by the spi-mem logic to force all messages that have been queued before a memory operation to be sent before we start the memory operation. We do that in order to guarantee that spi-mem operations do not preempt regular SPI transfers. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- As for the spi_map/unmap_buf() I'd suggest to move the prototype definition to an internal header file. --- drivers/spi/spi.c | 16 ++++++++++++++++ include/linux/spi/spi.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 308e4c2114d8..d7e046128b3f 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1520,6 +1520,22 @@ static int spi_controller_initialize_queue(struct spi_controller *ctlr) return ret; } +/** + * spi_flush_queue - Send all pending messages in the queue from the callers' + * context + * @ctlr: controller to process queue for + * + * This should be used when one wants to ensure all pending messages have been + * sent before doing something. Is used by the spi-mem code to make sure SPI + * memory operations do not preempt regular SPI transfers that have been queued + * before the spi-mem operation. + */ +void spi_flush_queue(struct spi_controller *ctlr) +{ + if (ctlr->transfer == spi_queued_transfer) + __spi_pump_messages(ctlr, false); +} + /*-------------------------------------------------------------------------*/ #if defined(CONFIG_OF) diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index de6fd95a61c5..3489fc9c0410 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -619,6 +619,8 @@ extern int spi_controller_resume(struct spi_controller *ctlr); * Helpers needed by the spi-mem logic. Should not be used outside of * spi-mem.c */ +void spi_flush_queue(struct spi_controller *ctrl); + #ifdef CONFIG_HAS_DMA int spi_map_buf(struct spi_controller *ctlr, struct device *dev, struct sg_table *sgt, void *buf, size_t len, -- 2.14.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@bootlin.com> To: David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Boris Brezillon <boris.brezillon@bootlin.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, linux-mtd@lists.infradead.org, Miquel Raynal <miquel.raynal@bootlin.com>, Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org Cc: "Peter Pan" <peterpansjtu@gmail.com>, "Frieder Schrempf" <frieder.schrempf@exceet.de>, "Vignesh R" <vigneshr@ti.com>, "Yogesh Gaur" <yogeshnarayan.gaur@nxp.com>, "Rafał Miłecki" <rafal@milecki.pl>, "Kamal Dasu" <kdasu.kdev@gmail.com>, "Sourav Poddar" <sourav.poddar@ti.com>, "Maxime Chevallier" <maxime.chevallier@bootlin.com> Subject: [PATCH v2 03/10] spi: Add an helper to flush the message queue Date: Wed, 11 Apr 2018 00:44:32 +0200 [thread overview] Message-ID: <20180410224439.9260-4-boris.brezillon@bootlin.com> (raw) In-Reply-To: <20180410224439.9260-1-boris.brezillon@bootlin.com> This is needed by the spi-mem logic to force all messages that have been queued before a memory operation to be sent before we start the memory operation. We do that in order to guarantee that spi-mem operations do not preempt regular SPI transfers. Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> --- As for the spi_map/unmap_buf() I'd suggest to move the prototype definition to an internal header file. --- drivers/spi/spi.c | 16 ++++++++++++++++ include/linux/spi/spi.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 308e4c2114d8..d7e046128b3f 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1520,6 +1520,22 @@ static int spi_controller_initialize_queue(struct spi_controller *ctlr) return ret; } +/** + * spi_flush_queue - Send all pending messages in the queue from the callers' + * context + * @ctlr: controller to process queue for + * + * This should be used when one wants to ensure all pending messages have been + * sent before doing something. Is used by the spi-mem code to make sure SPI + * memory operations do not preempt regular SPI transfers that have been queued + * before the spi-mem operation. + */ +void spi_flush_queue(struct spi_controller *ctlr) +{ + if (ctlr->transfer == spi_queued_transfer) + __spi_pump_messages(ctlr, false); +} + /*-------------------------------------------------------------------------*/ #if defined(CONFIG_OF) diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index de6fd95a61c5..3489fc9c0410 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -619,6 +619,8 @@ extern int spi_controller_resume(struct spi_controller *ctlr); * Helpers needed by the spi-mem logic. Should not be used outside of * spi-mem.c */ +void spi_flush_queue(struct spi_controller *ctrl); + #ifdef CONFIG_HAS_DMA int spi_map_buf(struct spi_controller *ctlr, struct device *dev, struct sg_table *sgt, void *buf, size_t len, -- 2.14.1
next prev parent reply other threads:[~2018-04-10 22:44 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-10 22:44 [PATCH v2 00/10] spi: Extend the framework to generically support memory devices Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-10 22:44 ` [PATCH v2 01/10] spi: Check presence the of ->transfer[_xxx]() before registering a controller Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-16 12:13 ` Applied "spi: Check presence the of ->transfer[_xxx]() before registering a controller" to the spi tree Mark Brown 2018-04-16 12:13 ` Mark Brown 2018-04-26 12:14 ` Boris Brezillon 2018-04-26 12:14 ` Boris Brezillon 2018-04-26 12:37 ` Mark Brown 2018-04-26 12:37 ` Mark Brown 2018-04-26 12:54 ` Mark Brown 2018-04-26 12:54 ` Mark Brown 2018-04-10 22:44 ` [PATCH v2 02/10] spi: Expose spi_{map,unmap}_buf() for internal use Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-16 12:11 ` Mark Brown 2018-04-16 12:11 ` Mark Brown 2018-04-18 14:20 ` Boris Brezillon 2018-04-18 14:20 ` Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon [this message] 2018-04-10 22:44 ` [PATCH v2 03/10] spi: Add an helper to flush the message queue Boris Brezillon 2018-04-10 22:44 ` [PATCH v2 04/10] spi: Extend the core to ease integration of SPI memory controllers Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-12 14:38 ` Vignesh R 2018-04-12 14:38 ` Vignesh R 2018-04-12 15:10 ` Boris Brezillon 2018-04-12 15:10 ` Boris Brezillon 2018-04-12 19:59 ` Boris Brezillon 2018-04-12 19:59 ` Boris Brezillon 2018-04-17 4:12 ` Vignesh R 2018-04-17 4:12 ` Vignesh R 2018-04-18 14:17 ` Boris Brezillon 2018-04-18 14:17 ` Boris Brezillon 2018-04-16 10:33 ` Frieder Schrempf 2018-04-16 10:33 ` Frieder Schrempf 2018-04-18 14:23 ` Boris Brezillon 2018-04-18 14:23 ` Boris Brezillon 2018-04-10 22:44 ` [PATCH v2 05/10] spi: Make support for regular transfers optional when ->mem_ops != NULL Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-10 22:44 ` [PATCH v2 06/10] spi: bcm-qspi: Implement the spi_mem interface Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-05-11 2:56 ` Applied "spi: bcm-qspi: Implement the spi_mem interface" to the spi tree Mark Brown 2018-05-11 2:56 ` Mark Brown 2018-04-10 22:44 ` [PATCH v2 07/10] spi: bcm53xx: Implement the spi_mem interface Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-12 13:09 ` Boris Brezillon 2018-04-12 13:09 ` Boris Brezillon 2018-05-07 9:35 ` Rafał Miłecki 2018-05-07 9:35 ` Rafał Miłecki 2018-04-10 22:44 ` [PATCH v2 08/10] spi: ti-qspi: " Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-10 22:44 ` [PATCH v2 09/10] mtd: spi-nor: Use the spi_mem_xx() API Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-05-11 2:55 ` Applied "mtd: spi-nor: Use the spi_mem_xx() API" to the spi tree Mark Brown 2018-05-11 2:55 ` Mark Brown 2018-04-10 22:44 ` [PATCH v2 10/10] spi: Get rid of the spi_flash_read() API Boris Brezillon 2018-04-10 22:44 ` Boris Brezillon 2018-04-17 10:57 ` [PATCH v2 00/10] spi: Extend the framework to generically support memory devices Mark Brown 2018-04-17 10:57 ` Mark Brown 2018-04-18 14:25 ` Boris Brezillon 2018-04-18 14:25 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180410224439.9260-4-boris.brezillon@bootlin.com \ --to=boris.brezillon@bootlin.com \ --cc=broonie@kernel.org \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@wedev4u.fr \ --cc=dwmw2@infradead.org \ --cc=frieder.schrempf@exceet.de \ --cc=kdasu.kdev@gmail.com \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=marek.vasut@gmail.com \ --cc=maxime.chevallier@bootlin.com \ --cc=miquel.raynal@bootlin.com \ --cc=peterpansjtu@gmail.com \ --cc=rafal@milecki.pl \ --cc=richard@nod.at \ --cc=sourav.poddar@ti.com \ --cc=vigneshr@ti.com \ --cc=yogeshnarayan.gaur@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.