* [PATCH] btrfs-progs: configure: check if xmlto exists at configure time
@ 2018-04-11 8:29 Misono Tomohiro
2018-04-11 8:41 ` Qu Wenruo
2018-04-11 13:16 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Misono Tomohiro @ 2018-04-11 8:29 UTC (permalink / raw)
To: linux-btrfs
AC_PATH_PROG won't fail even if it fails to find command path.
xmlto is required for document build and we should report error
if it doesn't exist at configure time.
Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
---
configure.ac | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index af13a959..a4c98b31 100644
--- a/configure.ac
+++ b/configure.ac
@@ -93,7 +93,11 @@ AC_SUBST([DISABLE_DOCUMENTATION])
dnl detect tools to build documentation
ASCIIDOC_TOOL="none"
if test "x$enable_documentation" = xyes; then
- AC_PATH_PROG([XMLTO], [xmlto], [xmlto])
+ AC_PATH_PROG([XMLTO], [xmlto])
+ if test -z "$XMLTO"; then
+ AC_MSG_ERROR([cannot find xmlto, cannot build documentation])
+ fi
+
AC_PATH_PROG([GZIP], [gzip], [gzip])
AC_PATH_PROG([MV], [mv], [mv])
AC_PROG_SED
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: configure: check if xmlto exists at configure time
2018-04-11 8:29 [PATCH] btrfs-progs: configure: check if xmlto exists at configure time Misono Tomohiro
@ 2018-04-11 8:41 ` Qu Wenruo
2018-04-11 13:16 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2018-04-11 8:41 UTC (permalink / raw)
To: Misono Tomohiro, linux-btrfs
On 2018年04月11日 16:29, Misono Tomohiro wrote:
> AC_PATH_PROG won't fail even if it fails to find command path.
> xmlto is required for document build and we should report error
> if it doesn't exist at configure time.
>
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
Looks good.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> configure.ac | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index af13a959..a4c98b31 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -93,7 +93,11 @@ AC_SUBST([DISABLE_DOCUMENTATION])
> dnl detect tools to build documentation
> ASCIIDOC_TOOL="none"
> if test "x$enable_documentation" = xyes; then
> - AC_PATH_PROG([XMLTO], [xmlto], [xmlto])
> + AC_PATH_PROG([XMLTO], [xmlto])
> + if test -z "$XMLTO"; then
> + AC_MSG_ERROR([cannot find xmlto, cannot build documentation])
> + fi
> +
> AC_PATH_PROG([GZIP], [gzip], [gzip])
> AC_PATH_PROG([MV], [mv], [mv])
> AC_PROG_SED
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs-progs: configure: check if xmlto exists at configure time
2018-04-11 8:29 [PATCH] btrfs-progs: configure: check if xmlto exists at configure time Misono Tomohiro
2018-04-11 8:41 ` Qu Wenruo
@ 2018-04-11 13:16 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2018-04-11 13:16 UTC (permalink / raw)
To: Misono Tomohiro; +Cc: linux-btrfs
On Wed, Apr 11, 2018 at 05:29:00PM +0900, Misono Tomohiro wrote:
> AC_PATH_PROG won't fail even if it fails to find command path.
> xmlto is required for document build and we should report error
> if it doesn't exist at configure time.
>
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-11 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 8:29 [PATCH] btrfs-progs: configure: check if xmlto exists at configure time Misono Tomohiro
2018-04-11 8:41 ` Qu Wenruo
2018-04-11 13:16 ` David Sterba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.