All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mkimage: do not fail if there is no print_header function
@ 2018-03-30  8:28 Guillaume GARDET
  2018-03-30  8:46 ` Dr. Philipp Tomsich
  2018-04-11 14:04 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Guillaume GARDET @ 2018-03-30  8:28 UTC (permalink / raw)
  To: u-boot

Commit 253c60a breaks the exit value of 'mkimage -T rkimage'
and print the following  error:
  mkimage: Can't print header for Rockchip Boot Image support: Success

It is not a failure to not print headers, so just display the warning message,
and finish the function properly.

Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>

Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
 tools/mkimage.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 28ff35e670..4e561820e7 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -588,9 +588,8 @@ int main(int argc, char **argv)
 	if (tparams->print_header)
 		tparams->print_header (ptr);
 	else {
-		fprintf (stderr, "%s: Can't print header for %s: %s\n",
-			params.cmdname, tparams->name, strerror(errno));
-		exit (EXIT_FAILURE);
+		fprintf (stderr, "%s: Can't print header for %s\n",
+			params.cmdname, tparams->name);
 	}
 
 	(void) munmap((void *)ptr, sbuf.st_size);
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mkimage: do not fail if there is no print_header function
  2018-03-30  8:28 [U-Boot] [PATCH] mkimage: do not fail if there is no print_header function Guillaume GARDET
@ 2018-03-30  8:46 ` Dr. Philipp Tomsich
  2018-04-11 14:04 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Dr. Philipp Tomsich @ 2018-03-30  8:46 UTC (permalink / raw)
  To: u-boot


> On 30 Mar 2018, at 10:28, Guillaume GARDET <guillaume.gardet@free.fr> wrote:
> 
> Commit 253c60a breaks the exit value of 'mkimage -T rkimage'
> and print the following  error:
>  mkimage: Can't print header for Rockchip Boot Image support: Success
> 
> It is not a failure to not print headers, so just display the warning message,
> and finish the function properly.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> tools/mkimage.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/mkimage.c b/tools/mkimage.c
> index 28ff35e670..4e561820e7 100644
> --- a/tools/mkimage.c
> +++ b/tools/mkimage.c
> @@ -588,9 +588,8 @@ int main(int argc, char **argv)
> 	if (tparams->print_header)
> 		tparams->print_header (ptr);
> 	else {
> -		fprintf (stderr, "%s: Can't print header for %s: %s\n",
> -			params.cmdname, tparams->name, strerror(errno));
> -		exit (EXIT_FAILURE);
> +		fprintf (stderr, "%s: Can't print header for %s\n",
> +			params.cmdname, tparams->name);
> 	}
> 
> 	(void) munmap((void *)ptr, sbuf.st_size);
> -- 
> 2.13.6
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] mkimage: do not fail if there is no print_header function
  2018-03-30  8:28 [U-Boot] [PATCH] mkimage: do not fail if there is no print_header function Guillaume GARDET
  2018-03-30  8:46 ` Dr. Philipp Tomsich
@ 2018-04-11 14:04 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2018-04-11 14:04 UTC (permalink / raw)
  To: u-boot

On Fri, Mar 30, 2018 at 10:28:19AM +0200, Guillaume GARDET wrote:

> Commit 253c60a breaks the exit value of 'mkimage -T rkimage'
> and print the following  error:
>   mkimage: Can't print header for Rockchip Boot Image support: Success
> 
> It is not a failure to not print headers, so just display the warning message,
> and finish the function properly.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> 
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180411/c03f2ae5/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-11 14:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30  8:28 [U-Boot] [PATCH] mkimage: do not fail if there is no print_header function Guillaume GARDET
2018-03-30  8:46 ` Dr. Philipp Tomsich
2018-04-11 14:04 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.