All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kubakici@wp.pl>
To: Michael Chan <michael.chan@broadcom.com>,
	Andy Gospodarek <andrew.gospodarek@broadcom.com>
Cc: David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net v2 2/6] bnxt_en: do not allow wildcard matches for L2 flows
Date: Wed, 11 Apr 2018 14:19:28 -0700	[thread overview]
Message-ID: <20180411141928.491dfb6f@cakuba.netronome.com> (raw)
In-Reply-To: <CACKFLinjsSyMDSyut3h1Qyzrn0HGjaGTROdA-5U-syezEopkxQ@mail.gmail.com>

On Wed, 11 Apr 2018 13:55:11 -0700, Michael Chan wrote:
> On Wed, Apr 11, 2018 at 1:50 PM, Andy Gospodarek wrote:
> > On Wed, Apr 11, 2018 at 01:41:31PM -0700, Michael Chan wrote:  
> > True, but I'm not sure that tc_cls_common_offload is used in all cases.
> > Take red_offload() as one of those.  
> 
> For Flower, we know we have the extack pointer in
> tc_cls_common_offload struct and we can use it to set the netlink
> error message.  The point is that we don't have to modify
> ndo_setup_tc().

Yes, the extack is actually only populated when skip_sw is specified to
avoid warning users who don't care about offloads.

Flower offloads don't go via .ndo_setup_tc but TC block callbacks.  But
one day we will hopefully find a reasonable way to pass extack to qdisc
offloads as well..

FWIW your driver is actually already using extack under the veil of
tc_cls_can_offload_and_chain0() :)

  reply	other threads:[~2018-04-11 21:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 15:50 [PATCH net v2 0/6] bnxt_en: Fixes for net Michael Chan
2018-04-11 15:50 ` [PATCH net v2 1/6] bnxt_en: Fix ethtool -x crash when device is down Michael Chan
2018-04-11 15:50 ` [PATCH net v2 2/6] bnxt_en: do not allow wildcard matches for L2 flows Michael Chan
2018-04-11 18:43   ` Jakub Kicinski
2018-04-11 20:21     ` Michael Chan
2018-04-11 20:31     ` Andy Gospodarek
2018-04-11 20:41       ` Michael Chan
2018-04-11 20:50         ` Andy Gospodarek
2018-04-11 20:55           ` Michael Chan
2018-04-11 21:19             ` Jakub Kicinski [this message]
2018-04-11 15:50 ` [PATCH net v2 3/6] bnxt_en: Ignore src port field in decap filter nodes Michael Chan
2018-04-11 15:50 ` [PATCH net v2 4/6] bnxt_en: Support max-mtu with VF-reps Michael Chan
2018-04-11 15:50 ` [PATCH net v2 5/6] bnxt_en: Need to include RDMA rings in bnxt_check_rings() Michael Chan
2018-04-11 15:50 ` [PATCH net v2 6/6] bnxt_en: Fix NULL pointer dereference at bnxt_free_irq() Michael Chan
2018-04-11 18:42 ` [PATCH net v2 0/6] bnxt_en: Fixes for net David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180411141928.491dfb6f@cakuba.netronome.com \
    --to=kubakici@wp.pl \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.