* [Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d
@ 2018-04-11 21:27 Andre Renaud
2018-04-12 11:38 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Andre Renaud @ 2018-04-11 21:27 UTC (permalink / raw)
To: buildroot
From: Andre Renaud <arenaud@designa-electronics.com>
---
package/mesa3d/Config.in | 7 +++++++
package/mesa3d/mesa3d.mk | 1 +
2 files changed, 8 insertions(+)
diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 1476b39acc..5005c98cee 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -85,6 +85,13 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV
help
Mesa driver for Vivante GPUs.
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO
+ bool "Gallium freedreno driver"
+ select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+ select BR2_PACKAGE_LIBDRM_FREEDRENO
+ help
+ Mesa driver for Freedreno GPUs.
+
config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
bool "Gallium nouveau driver"
depends on BR2_i386 || BR2_x86_64
diff --git a/package/mesa3d/mesa3d.mk b/package/mesa3d/mesa3d.mk
index 506f84274f..bf177591c7 100644
--- a/package/mesa3d/mesa3d.mk
+++ b/package/mesa3d/mesa3d.mk
@@ -78,6 +78,7 @@ endif
#Gallium Drivers
MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV) += etnaviv imx
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_FREEDRENO) += freedreno
MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU) += nouveau
MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600) += r600
MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA) += svga
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d
2018-04-11 21:27 [Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d Andre Renaud
@ 2018-04-12 11:38 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-04-12 11:38 UTC (permalink / raw)
To: buildroot
Hello Andre,
Thanks for this new version, this is almost good, but not yet :)
On Thu, 12 Apr 2018 09:27:41 +1200, Andre Renaud wrote:
> From: Andre Renaud <arenaud@designa-electronics.com>
>
Your Signed-off-by line is missing here, could you resend with this
Signed-off-by line added ?
Also, please change the commit title to:
mesa3d: add option to enable Freedreno gallium driver
Indeed:
- We also want the commit log to have the format "<package>:
<description>"
- Using a past tense "Added" doesn't make a lot of sense. Your commit
has not "added" something, it is adding something. So using just
"add" makes a lot more sense
Could you resend after fixing those minor issues? I had fixed myself
the commit title issue and was about to push your patch, but the
missing Signed-off-by requires you to resend a new version.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-12 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11 21:27 [Buildroot] [PATCH] Added option to enable Freedreno gallium driver in mesa3d Andre Renaud
2018-04-12 11:38 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.