From: Andrew Lunn <andrew@lunn.ch> To: Phil Elwell <phil@raspberrypi.org> Cc: Woojung Huh <woojung.huh@microchip.com>, Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "David S. Miller" <davem@davemloft.net>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Walleij <linus.walleij@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, Randy Dunlap <rdunlap@infradead.org>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/4] lan78xx: Read LED modes from Device Tree Date: Thu, 12 Apr 2018 16:26:15 +0200 [thread overview] Message-ID: <20180412142615.GO28963@lunn.ch> (raw) In-Reply-To: <1523541336-145953-4-git-send-email-phil@raspberrypi.org> On Thu, Apr 12, 2018 at 02:55:35PM +0100, Phil Elwell wrote: > Add support for DT property "microchip,led-modes", a vector of two > cells (u32s) in the range 0-15, each of which sets the mode for one > of the two LEDs. Some possible values are: > > 0=link/activity 1=link1000/activity > 2=link100/activity 3=link10/activity > 4=link100/1000/activity 5=link10/1000/activity > 6=link10/100/activity 14=off 15=on > > Also use the presence of the DT property to indicate that the > LEDs should be enabled - necessary in the event that no valid OTP > or EEPROM is available. I'm not a fan of this, but at the moment, we don't have anything better. Please follow what mscc does, add a header file for the LED settings. Andrew > > Signed-off-by: Phil Elwell <phil@raspberrypi.org> > --- > drivers/net/usb/lan78xx.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c > index d98397b..ffb483d 100644 > --- a/drivers/net/usb/lan78xx.c > +++ b/drivers/net/usb/lan78xx.c > @@ -2008,6 +2008,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) > { > int ret; > u32 mii_adv; > + u32 led_modes[2]; > struct phy_device *phydev; > > phydev = phy_find_first(dev->mdiobus); > @@ -2097,6 +2098,25 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) > (void)lan78xx_set_eee(dev->net, &edata); > } > > + if (!of_property_read_u32_array(dev->udev->dev.of_node, > + "microchip,led-modes", > + led_modes, ARRAY_SIZE(led_modes))) { > + u32 reg; > + int i; > + > + reg = phy_read(phydev, 0x1d); > + for (i = 0; i < ARRAY_SIZE(led_modes); i++) { > + reg &= ~(0xf << (i * 4)); > + reg |= (led_modes[i] & 0xf) << (i * 4); > + } Please add range checks for led_modes[i] and return -EINVAL if the check fails. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> To: Phil Elwell <phil@raspberrypi.org> Cc: Woojung Huh <woojung.huh@microchip.com>, Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, "David S. Miller" <davem@davemloft.net>, Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Walleij <linus.walleij@linaro.org>, Andrew Morton <akpm@linux-foundation.org>, Randy Dunlap <rdunlap@infradead.org>, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [3/4] lan78xx: Read LED modes from Device Tree Date: Thu, 12 Apr 2018 16:26:15 +0200 [thread overview] Message-ID: <20180412142615.GO28963@lunn.ch> (raw) On Thu, Apr 12, 2018 at 02:55:35PM +0100, Phil Elwell wrote: > Add support for DT property "microchip,led-modes", a vector of two > cells (u32s) in the range 0-15, each of which sets the mode for one > of the two LEDs. Some possible values are: > > 0=link/activity 1=link1000/activity > 2=link100/activity 3=link10/activity > 4=link100/1000/activity 5=link10/1000/activity > 6=link10/100/activity 14=off 15=on > > Also use the presence of the DT property to indicate that the > LEDs should be enabled - necessary in the event that no valid OTP > or EEPROM is available. I'm not a fan of this, but at the moment, we don't have anything better. Please follow what mscc does, add a header file for the LED settings. Andrew > > Signed-off-by: Phil Elwell <phil@raspberrypi.org> > --- > drivers/net/usb/lan78xx.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c > index d98397b..ffb483d 100644 > --- a/drivers/net/usb/lan78xx.c > +++ b/drivers/net/usb/lan78xx.c > @@ -2008,6 +2008,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) > { > int ret; > u32 mii_adv; > + u32 led_modes[2]; > struct phy_device *phydev; > > phydev = phy_find_first(dev->mdiobus); > @@ -2097,6 +2098,25 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) > (void)lan78xx_set_eee(dev->net, &edata); > } > > + if (!of_property_read_u32_array(dev->udev->dev.of_node, > + "microchip,led-modes", > + led_modes, ARRAY_SIZE(led_modes))) { > + u32 reg; > + int i; > + > + reg = phy_read(phydev, 0x1d); > + for (i = 0; i < ARRAY_SIZE(led_modes); i++) { > + reg &= ~(0xf << (i * 4)); > + reg |= (led_modes[i] & 0xf) << (i * 4); > + } Please add range checks for led_modes[i] and return -EINVAL if the check fails. Andrew --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-12 14:26 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-12 13:55 [PATCH 0/4] lan78xx: Read configuration from Device Tree Phil Elwell 2018-04-12 13:55 ` [PATCH 1/4] lan78xx: Read MAC address from DT if present Phil Elwell 2018-04-12 13:55 ` [1/4] " Phil Elwell 2018-04-12 14:06 ` [PATCH 1/4] " Andrew Lunn 2018-04-12 14:06 ` [1/4] " Andrew Lunn 2018-04-12 14:18 ` [PATCH 1/4] " Phil Elwell 2018-04-12 14:18 ` [1/4] " Phil Elwell 2018-04-12 13:55 ` [PATCH 2/4] lan78xx: Read initial EEE setting from Device Tree Phil Elwell 2018-04-12 13:55 ` [2/4] " Phil Elwell 2018-04-12 14:16 ` [PATCH 2/4] " Andrew Lunn 2018-04-12 14:16 ` [2/4] " Andrew Lunn 2018-04-12 15:17 ` [PATCH 2/4] " Phil Elwell 2018-04-12 15:17 ` [2/4] " Phil Elwell 2018-04-12 13:55 ` [PATCH 3/4] lan78xx: Read LED modes " Phil Elwell 2018-04-12 13:55 ` [3/4] " Phil Elwell 2018-04-12 14:26 ` Andrew Lunn [this message] 2018-04-12 14:26 ` Andrew Lunn 2018-04-12 14:30 ` [PATCH 3/4] " Phil Elwell 2018-04-12 14:30 ` [3/4] " Phil Elwell 2018-04-12 14:36 ` [PATCH 3/4] " Andrew Lunn 2018-04-12 14:36 ` [3/4] " Andrew Lunn 2018-04-12 15:21 ` [PATCH 3/4] " Woojung.Huh 2018-04-12 15:21 ` [3/4] " Woojung.Huh 2018-04-12 15:21 ` [PATCH 3/4] " Woojung.Huh 2018-04-12 13:55 ` [PATCH 4/4] dt-bindings: Document the DT bindings for lan78xx Phil Elwell 2018-04-12 13:55 ` [4/4] " Phil Elwell 2018-04-12 14:04 ` [PATCH 4/4] " Andrew Lunn 2018-04-12 14:04 ` [4/4] " Andrew Lunn 2018-04-12 14:10 ` [PATCH 4/4] " Phil Elwell 2018-04-12 14:10 ` [4/4] " Phil Elwell 2018-04-12 14:17 ` [PATCH 4/4] " Andrew Lunn 2018-04-12 14:17 ` [4/4] " Andrew Lunn 2018-04-12 14:30 ` [PATCH 4/4] " Andrew Lunn 2018-04-12 14:30 ` [4/4] " Andrew Lunn 2018-04-12 14:33 ` [PATCH 4/4] " Phil Elwell 2018-04-12 14:33 ` [4/4] " Phil Elwell 2018-04-16 19:22 ` [PATCH 4/4] " Rob Herring 2018-04-16 19:22 ` [4/4] " Rob Herring 2018-04-17 11:35 ` [PATCH 4/4] " Phil Elwell 2018-04-17 11:35 ` [4/4] " Phil Elwell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180412142615.GO28963@lunn.ch \ --to=andrew@lunn.ch \ --cc=UNGLinuxDriver@microchip.com \ --cc=akpm@linux-foundation.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linus.walleij@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=netdev@vger.kernel.org \ --cc=phil@raspberrypi.org \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=woojung.huh@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.