From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: tfa9879: switch to using .probe_new
Date: Thu, 12 Apr 2018 23:14:32 +0200 [thread overview]
Message-ID: <20180412211437.21599-1-peda@axentia.se> (raw)
In-Reply-To: <20180412161601.GI9929@sirena.org.uk>
On 2018-04-12 18:16, Mark Brown wrote:
> On Wed, Apr 11, 2018 at 02:42:38PM +0200, Peter Rosin wrote:
>
>> Use the new probe style for i2c drivers.
> This doesn't apply against current code, please check and resend.
That's not my fault. Somebody forgot to drop a note with the maintainer
so I was completely unaware of this change. It seems to have been a
cocci-script or something behind that change because the code looks
like shit afterwards.
For the record, I wish to be on Cc for changes to files I maintain.
That is one of the core functions of the MAINTAINERS file, right?
Anyway, I added a couple of fixups for that mess and I also did a SPDX
conversion while at it since I noticed it was needed. Finishing off with
the rebased patch.
Cheers,
Peter
Peter Rosin (5):
ASoC: max9860: fix whitespace issues caused by mindless conversion
ASoC: tfa9879: fix whitespace issues caused by mindless conversion
ASoC: max9860: switch to SPDX license tag
ASoC: tfa9879: switch to SPDX license tag
ASoC: tfa9879: switch to using .probe_new
sound/soc/codecs/max9860.c | 18 ++++++------------
sound/soc/codecs/max9860.h | 10 +---------
sound/soc/codecs/tfa9879.c | 37 ++++++++++++++++---------------------
sound/soc/codecs/tfa9879.h | 7 +------
4 files changed, 24 insertions(+), 48 deletions(-)
--
2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH 2/2] ASoC: tfa9879: switch to using .probe_new
Date: Thu, 12 Apr 2018 23:14:32 +0200 [thread overview]
Message-ID: <20180412211437.21599-1-peda@axentia.se> (raw)
In-Reply-To: <20180412161601.GI9929@sirena.org.uk>
On 2018-04-12 18:16, Mark Brown wrote:
> On Wed, Apr 11, 2018 at 02:42:38PM +0200, Peter Rosin wrote:
>
>> Use the new probe style for i2c drivers.
> This doesn't apply against current code, please check and resend.
That's not my fault. Somebody forgot to drop a note with the maintainer
so I was completely unaware of this change. It seems to have been a
cocci-script or something behind that change because the code looks
like shit afterwards.
For the record, I wish to be on Cc for changes to files I maintain.
That is one of the core functions of the MAINTAINERS file, right?
Anyway, I added a couple of fixups for that mess and I also did a SPDX
conversion while at it since I noticed it was needed. Finishing off with
the rebased patch.
Cheers,
Peter
Peter Rosin (5):
ASoC: max9860: fix whitespace issues caused by mindless conversion
ASoC: tfa9879: fix whitespace issues caused by mindless conversion
ASoC: max9860: switch to SPDX license tag
ASoC: tfa9879: switch to SPDX license tag
ASoC: tfa9879: switch to using .probe_new
sound/soc/codecs/max9860.c | 18 ++++++------------
sound/soc/codecs/max9860.h | 10 +---------
sound/soc/codecs/tfa9879.c | 37 ++++++++++++++++---------------------
sound/soc/codecs/tfa9879.h | 7 +------
4 files changed, 24 insertions(+), 48 deletions(-)
--
2.11.0
next prev parent reply other threads:[~2018-04-12 21:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 12:42 [PATCH 1/2] ASoC: max9860: switch to using .probe_new Peter Rosin
2018-04-11 12:42 ` Peter Rosin
2018-04-11 12:42 ` [PATCH 2/2] ASoC: tfa9879: " Peter Rosin
2018-04-12 16:16 ` Mark Brown
2018-04-12 21:14 ` Peter Rosin [this message]
2018-04-12 21:14 ` Peter Rosin
2018-04-12 21:14 ` [PATCH v2 1/5] ASoC: max9860: fix whitespace issues caused by mindless conversion Peter Rosin
2018-04-13 11:23 ` Applied "ASoC: max9860: fix whitespace issues caused by mindless conversion" to the asoc tree Mark Brown
2018-04-13 11:23 ` Mark Brown
2018-04-12 21:14 ` [PATCH v2 2/5] ASoC: tfa9879: fix whitespace issues caused by mindless conversion Peter Rosin
2018-04-12 21:14 ` Peter Rosin
2018-04-13 11:22 ` Applied "ASoC: tfa9879: fix whitespace issues caused by mindless conversion" to the asoc tree Mark Brown
2018-04-13 11:22 ` Mark Brown
2018-04-16 11:40 ` Mark Brown
2018-04-16 11:40 ` Mark Brown
2018-04-12 21:14 ` [PATCH v2 3/5] ASoC: max9860: switch to SPDX license tag Peter Rosin
2018-04-13 11:19 ` Mark Brown
2018-04-13 11:47 ` [PATCH v3 0/2] ASoC: max9860/tfa9879: " Peter Rosin
2018-04-13 11:47 ` Peter Rosin
2018-04-13 11:47 ` [PATCH v3 1/2] ASoC: max9860: " Peter Rosin
2018-04-13 11:47 ` Peter Rosin
2018-04-16 11:39 ` Applied "ASoC: max9860: switch to SPDX license tag" to the asoc tree Mark Brown
2018-04-16 11:39 ` Mark Brown
2018-04-16 11:59 ` Mark Brown
2018-04-16 11:59 ` Mark Brown
2018-04-13 11:47 ` [PATCH v3 2/2] ASoC: tfa9879: switch to SPDX license tag Peter Rosin
2018-04-13 13:43 ` Applied "ASoC: tfa9879: switch to SPDX license tag" to the asoc tree Mark Brown
2018-04-13 13:43 ` Mark Brown
2018-04-16 11:39 ` Mark Brown
2018-04-16 11:39 ` Mark Brown
2018-04-16 12:00 ` Mark Brown
2018-04-16 12:00 ` Mark Brown
2018-04-13 13:41 ` [PATCH v3 0/2] ASoC: max9860/tfa9879: switch to SPDX license tag Mark Brown
2018-04-15 7:32 ` [PATCH v2 3/5] ASoC: max9860: " Christoph Hellwig
2018-04-16 11:35 ` Mark Brown
2018-04-12 21:14 ` [PATCH v2 4/5] ASoC: tfa9879: " Peter Rosin
2018-04-12 21:14 ` [PATCH v2 5/5] ASoC: tfa9879: switch to using .probe_new Peter Rosin
2018-04-13 11:22 ` Applied "ASoC: tfa9879: switch to using .probe_new" to the asoc tree Mark Brown
2018-04-13 11:22 ` Mark Brown
2018-04-16 11:40 ` Mark Brown
2018-04-16 11:40 ` Mark Brown
2018-04-13 11:21 ` [PATCH 2/2] ASoC: tfa9879: switch to using .probe_new Mark Brown
2018-04-12 16:16 ` Applied "ASoC: max9860: switch to using .probe_new" to the asoc tree Mark Brown
2018-04-12 16:16 ` Mark Brown
2018-04-13 10:56 ` Mark Brown
2018-04-13 10:56 ` Mark Brown
2018-04-13 11:24 ` Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180412211437.21599-1-peda@axentia.se \
--to=peda@axentia.se \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.