* [Qemu-devel] [PATCH v2 0/3] pc-dimm: factor out MemoryDevice
@ 2018-04-12 14:36 David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Hildenbrand @ 2018-04-12 14:36 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-s390x, Michael S . Tsirkin, Igor Mammedov, Marcel Apfelbaum,
Paolo Bonzini, Richard Henderson, Eduardo Habkost, David Gibson,
Markus Armbruster, qemu-ppc, Pankaj Gupta
Right now we can only map PCDIMM/NVDIMM into guest address space. In the
future, we might want to do the same for virtio devices - e.g.
virtio-pmem or virtio-mem. Especially, they should be able to live side
by side to each other.
E.g. the virto based memory devices regions will not be exposed via ACPI
and friends. They will be detected just like other virtio devices and
indicate the applicable memory region. This makes it possible to also use
them on architectures without memory device detection support (e.g. s390x).
Let's factor out the memory device code into a MemoryDevice interface.
See the patch descriptions for details.
v1 -> v2:
- Fix compile issues on ppc (still untested O:-) )
David Hildenbrand (3):
pc-dimm: factor out MemoryDevice interface
machine: make MemoryHotplugState accessible via the machine
pc-dimm: factor out address space logic into MemoryDevice code
hw/i386/acpi-build.c | 3 +-
hw/i386/pc.c | 24 ++-
hw/mem/Makefile.objs | 1 +
hw/mem/memory-device.c | 281 +++++++++++++++++++++++++
hw/mem/pc-dimm.c | 304 +++++++--------------------
hw/ppc/spapr.c | 24 ++-
hw/ppc/spapr_hcall.c | 1 +
include/hw/boards.h | 16 ++
include/hw/mem/memory-device.h | 48 +++++
include/hw/mem/pc-dimm.h | 26 +--
numa.c | 3 +-
qmp.c | 4 +-
stubs/Makefile.objs | 2 +-
stubs/{qmp_pc_dimm.c => qmp_memory_device.c} | 4 +-
14 files changed, 464 insertions(+), 277 deletions(-)
create mode 100644 hw/mem/memory-device.c
create mode 100644 include/hw/mem/memory-device.h
rename stubs/{qmp_pc_dimm.c => qmp_memory_device.c} (61%)
--
2.14.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface
2018-04-12 14:36 [Qemu-devel] [PATCH v2 0/3] pc-dimm: factor out MemoryDevice David Hildenbrand
@ 2018-04-12 14:36 ` David Hildenbrand
2018-04-13 3:25 ` David Gibson
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 2/3] machine: make MemoryHotplugState accessible via the machine David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 3/3] pc-dimm: factor out address space logic into MemoryDevice code David Hildenbrand
2 siblings, 1 reply; 6+ messages in thread
From: David Hildenbrand @ 2018-04-12 14:36 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-s390x, Michael S . Tsirkin, Igor Mammedov, Marcel Apfelbaum,
Paolo Bonzini, Richard Henderson, Eduardo Habkost, David Gibson,
Markus Armbruster, qemu-ppc, Pankaj Gupta, David Hildenbrand
On the qmp level, we already have the concept of memory devices:
"query-memory-devices"
Right now, we only support NVDIMM and PCDIMM.
We want to map other devices later into the address space of the guest.
Such device could e.g. be virtio devices. These devices will have a
guest memory range assigned but won't be exposed via e.g. ACPI. We want
to make them look like memory device, but not glued to pc-dimm.
Especially, it will not always be possible to have TYPE_PC_DIMM as a parent
class (e.g. virtio devices). Let's use an interface instead. As a first
part, convert handling of
- qmp_pc_dimm_device_list
- get_plugged_memory_size
to our new model. plug/unplug stuff etc. will follow later.
A memory device will have to provide the following functions:
- get_addr(): Necessary, as the property "addr" can e.g. not be used for
virtio devices (already defined).
- get_plugged_size(): The amount this device offers to the guest as of
now.
- get_region_size(): Because this can later on be bigger than the
plugged size.
- fill_device_info(): Fill MemoryDeviceInfo, e.g. for qmp.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/i386/acpi-build.c | 3 +-
hw/mem/Makefile.objs | 1 +
hw/mem/memory-device.c | 119 +++++++++++++++++++++++++++
hw/mem/pc-dimm.c | 119 ++++++++++++++-------------
hw/ppc/spapr.c | 3 +-
hw/ppc/spapr_hcall.c | 1 +
include/hw/mem/memory-device.h | 44 ++++++++++
include/hw/mem/pc-dimm.h | 2 -
numa.c | 3 +-
qmp.c | 4 +-
stubs/Makefile.objs | 2 +-
stubs/{qmp_pc_dimm.c => qmp_memory_device.c} | 4 +-
12 files changed, 239 insertions(+), 66 deletions(-)
create mode 100644 hw/mem/memory-device.c
create mode 100644 include/hw/mem/memory-device.h
rename stubs/{qmp_pc_dimm.c => qmp_memory_device.c} (61%)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 3cf2a1679c..ca3645d57b 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -46,6 +46,7 @@
#include "hw/acpi/vmgenid.h"
#include "sysemu/tpm_backend.h"
#include "hw/timer/mc146818rtc_regs.h"
+#include "hw/mem/memory-device.h"
#include "sysemu/numa.h"
/* Supported chipsets: */
@@ -2253,7 +2254,7 @@ build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog)
static void build_srat_hotpluggable_memory(GArray *table_data, uint64_t base,
uint64_t len, int default_node)
{
- MemoryDeviceInfoList *info_list = qmp_pc_dimm_device_list();
+ MemoryDeviceInfoList *info_list = qmp_memory_device_list();
MemoryDeviceInfoList *info;
MemoryDeviceInfo *mi;
PCDIMMDeviceInfo *di;
diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
index f12f8b97a2..10be4df2a2 100644
--- a/hw/mem/Makefile.objs
+++ b/hw/mem/Makefile.objs
@@ -1,2 +1,3 @@
common-obj-$(CONFIG_MEM_HOTPLUG) += pc-dimm.o
+common-obj-$(CONFIG_MEM_HOTPLUG) += memory-device.o
common-obj-$(CONFIG_NVDIMM) += nvdimm.o
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
new file mode 100644
index 0000000000..0e0d6b539a
--- /dev/null
+++ b/hw/mem/memory-device.c
@@ -0,0 +1,119 @@
+/*
+ * Memory Device Interface
+ *
+ * Copyright ProfitBricks GmbH 2012
+ * Copyright (C) 2014 Red Hat Inc
+ * Copyright (c) 2018 Red Hat Inc
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#include "qemu/osdep.h"
+#include "hw/mem/memory-device.h"
+#include "hw/qdev.h"
+#include "qapi/error.h"
+#include "hw/boards.h"
+#include "qemu/range.h"
+
+static gint memory_device_addr_sort(gconstpointer a, gconstpointer b)
+{
+ MemoryDeviceState *md_a = MEMORY_DEVICE(a);
+ MemoryDeviceState *md_b = MEMORY_DEVICE(b);
+ MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(a);
+ const uint64_t addr_a = mdc->get_addr(md_a);
+ const uint64_t addr_b = mdc->get_addr(md_b);
+
+ if (addr_a > addr_b) {
+ return 1;
+ } else if (addr_a < addr_b) {
+ return -1;
+ }
+ return 0;
+}
+
+static int memory_device_built_list(Object *obj, void *opaque)
+{
+ GSList **list = opaque;
+
+ if (object_dynamic_cast(obj, TYPE_MEMORY_DEVICE)) {
+ DeviceState *dev = DEVICE(obj);
+ if (dev->realized) { /* only realized memory devices matter */
+ *list = g_slist_insert_sorted(*list, dev, memory_device_addr_sort);
+ }
+ }
+
+ object_child_foreach(obj, memory_device_built_list, opaque);
+ return 0;
+}
+
+MemoryDeviceInfoList *qmp_memory_device_list(void)
+{
+ GSList *devices = NULL, *item;
+ MemoryDeviceInfoList *list = NULL, *prev = NULL;
+
+ object_child_foreach(qdev_get_machine(), memory_device_built_list,
+ &devices);
+
+ for (item = devices; item; item = g_slist_next(item)) {
+ MemoryDeviceState *md = MEMORY_DEVICE(item->data);
+ MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(item->data);
+ MemoryDeviceInfoList *elem = g_new0(MemoryDeviceInfoList, 1);
+ MemoryDeviceInfo *info = g_new0(MemoryDeviceInfo, 1);
+
+ mdc->fill_device_info(md, info);
+
+ elem->value = info;
+ elem->next = NULL;
+ if (prev) {
+ prev->next = elem;
+ } else {
+ list = elem;
+ }
+ prev = elem;
+ }
+
+ g_slist_free(devices);
+
+ return list;
+}
+
+static int memory_device_plugged_size(Object *obj, void *opaque)
+{
+ uint64_t *size = opaque;
+
+ if (object_dynamic_cast(obj, TYPE_MEMORY_DEVICE)) {
+ DeviceState *dev = DEVICE(obj);
+ MemoryDeviceState *md = MEMORY_DEVICE(obj);
+ MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(obj);
+
+ if (dev->realized) {
+ *size += mdc->get_plugged_size(md, &error_abort);
+ }
+ }
+
+ object_child_foreach(obj, memory_device_plugged_size, opaque);
+ return 0;
+}
+
+uint64_t get_plugged_memory_size(void)
+{
+ uint64_t size = 0;
+
+ memory_device_plugged_size(qdev_get_machine(), &size);
+
+ return size;
+}
+
+static const TypeInfo memory_device_info = {
+ .name = TYPE_MEMORY_DEVICE,
+ .parent = TYPE_INTERFACE,
+ .class_size = sizeof(MemoryDeviceClass),
+};
+
+static void memory_device_register_types(void)
+{
+ type_register_static(&memory_device_info);
+}
+
+type_init(memory_device_register_types)
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 51350d9c2d..1dbf699e02 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -21,6 +21,7 @@
#include "qemu/osdep.h"
#include "hw/mem/pc-dimm.h"
#include "hw/mem/nvdimm.h"
+#include "hw/mem/memory-device.h"
#include "qapi/error.h"
#include "qemu/config-file.h"
#include "qapi/visitor.h"
@@ -158,11 +159,6 @@ uint64_t pc_existing_dimms_capacity(Error **errp)
return cap.size;
}
-uint64_t get_plugged_memory_size(void)
-{
- return pc_existing_dimms_capacity(&error_abort);
-}
-
static int pc_dimm_slot2bitmap(Object *obj, void *opaque)
{
unsigned long *bitmap = opaque;
@@ -238,57 +234,6 @@ static int pc_dimm_built_list(Object *obj, void *opaque)
return 0;
}
-MemoryDeviceInfoList *qmp_pc_dimm_device_list(void)
-{
- GSList *dimms = NULL, *item;
- MemoryDeviceInfoList *list = NULL, *prev = NULL;
-
- object_child_foreach(qdev_get_machine(), pc_dimm_built_list, &dimms);
-
- for (item = dimms; item; item = g_slist_next(item)) {
- PCDIMMDevice *dimm = PC_DIMM(item->data);
- Object *obj = OBJECT(dimm);
- MemoryDeviceInfoList *elem = g_new0(MemoryDeviceInfoList, 1);
- MemoryDeviceInfo *info = g_new0(MemoryDeviceInfo, 1);
- PCDIMMDeviceInfo *di = g_new0(PCDIMMDeviceInfo, 1);
- bool is_nvdimm = object_dynamic_cast(obj, TYPE_NVDIMM);
- DeviceClass *dc = DEVICE_GET_CLASS(obj);
- DeviceState *dev = DEVICE(obj);
-
- if (dev->id) {
- di->has_id = true;
- di->id = g_strdup(dev->id);
- }
- di->hotplugged = dev->hotplugged;
- di->hotpluggable = dc->hotpluggable;
- di->addr = dimm->addr;
- di->slot = dimm->slot;
- di->node = dimm->node;
- di->size = object_property_get_uint(obj, PC_DIMM_SIZE_PROP, NULL);
- di->memdev = object_get_canonical_path(OBJECT(dimm->hostmem));
-
- if (!is_nvdimm) {
- info->u.dimm.data = di;
- info->type = MEMORY_DEVICE_INFO_KIND_DIMM;
- } else {
- info->u.nvdimm.data = di;
- info->type = MEMORY_DEVICE_INFO_KIND_NVDIMM;
- }
- elem->value = info;
- elem->next = NULL;
- if (prev) {
- prev->next = elem;
- } else {
- list = elem;
- }
- prev = elem;
- }
-
- g_slist_free(dimms);
-
- return list;
-}
-
uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
uint64_t address_space_size,
uint64_t *hint, uint64_t align, uint64_t size,
@@ -445,10 +390,62 @@ static MemoryRegion *pc_dimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
}
+static uint64_t pc_dimm_md_get_addr(MemoryDeviceState *md)
+{
+ PCDIMMDevice *dimm = PC_DIMM(md);
+
+ return dimm->addr;
+}
+
+static uint64_t pc_dimm_md_get_region_size(MemoryDeviceState *md, Error **errp)
+{
+ PCDIMMDevice *dimm = PC_DIMM(md);
+ PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(md);
+ MemoryRegion *mr;
+
+ mr = ddc->get_memory_region(dimm, errp);
+ if (!mr) {
+ return 0;
+ }
+
+ return memory_region_size(mr);
+}
+
+static void pc_dimm_md_fill_device_info(MemoryDeviceState *md,
+ MemoryDeviceInfo *info)
+{
+ PCDIMMDeviceInfo *di = g_new0(PCDIMMDeviceInfo, 1);
+ DeviceClass *dc = DEVICE_GET_CLASS(md);
+ PCDIMMDevice *dimm = PC_DIMM(md);
+ DeviceState *dev = DEVICE(md);
+
+ if (dev->id) {
+ di->has_id = true;
+ di->id = g_strdup(dev->id);
+ }
+ di->hotplugged = dev->hotplugged;
+ di->hotpluggable = dc->hotpluggable;
+ di->addr = dimm->addr;
+ di->slot = dimm->slot;
+ di->node = dimm->node;
+ di->size = object_property_get_uint(OBJECT(dimm), PC_DIMM_SIZE_PROP,
+ NULL);
+ di->memdev = object_get_canonical_path(OBJECT(dimm->hostmem));
+
+ if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
+ info->u.nvdimm.data = di;
+ info->type = MEMORY_DEVICE_INFO_KIND_NVDIMM;
+ } else {
+ info->u.dimm.data = di;
+ info->type = MEMORY_DEVICE_INFO_KIND_DIMM;
+ }
+}
+
static void pc_dimm_class_init(ObjectClass *oc, void *data)
{
DeviceClass *dc = DEVICE_CLASS(oc);
PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc);
+ MemoryDeviceClass *mdc = MEMORY_DEVICE_CLASS(oc);
dc->realize = pc_dimm_realize;
dc->unrealize = pc_dimm_unrealize;
@@ -457,6 +454,12 @@ static void pc_dimm_class_init(ObjectClass *oc, void *data)
ddc->get_memory_region = pc_dimm_get_memory_region;
ddc->get_vmstate_memory_region = pc_dimm_get_vmstate_memory_region;
+
+ mdc->get_addr = pc_dimm_md_get_addr;
+ /* for a dimm plugged_size == region_size */
+ mdc->get_plugged_size = pc_dimm_md_get_region_size;
+ mdc->get_region_size = pc_dimm_md_get_region_size;
+ mdc->fill_device_info = pc_dimm_md_fill_device_info;
}
static TypeInfo pc_dimm_info = {
@@ -466,6 +469,10 @@ static TypeInfo pc_dimm_info = {
.instance_init = pc_dimm_init,
.class_init = pc_dimm_class_init,
.class_size = sizeof(PCDIMMDeviceClass),
+ .interfaces = (InterfaceInfo[]) {
+ { TYPE_MEMORY_DEVICE },
+ { }
+ },
};
static void pc_dimm_register_types(void)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index a81570e7c8..a7428f7da7 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -74,6 +74,7 @@
#include "hw/compat.h"
#include "qemu/cutils.h"
#include "hw/ppc/spapr_cpu_core.h"
+#include "hw/mem/memory-device.h"
#include <libfdt.h>
@@ -722,7 +723,7 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
}
if (hotplug_lmb_start) {
- dimms = qmp_pc_dimm_device_list();
+ dimms = qmp_memory_device_list();
}
/* ibm,dynamic-memory */
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 16bccdd5c0..4cdae3ca3a 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -14,6 +14,7 @@
#include "kvm_ppc.h"
#include "hw/ppc/spapr_ovec.h"
#include "mmu-book3s-v3.h"
+#include "hw/mem/memory-device.h"
struct SPRSyncState {
int spr;
diff --git a/include/hw/mem/memory-device.h b/include/hw/mem/memory-device.h
new file mode 100644
index 0000000000..3e498b2e61
--- /dev/null
+++ b/include/hw/mem/memory-device.h
@@ -0,0 +1,44 @@
+/*
+ * Memory Device Interface
+ *
+ * Copyright (c) 2018 Red Hat, Inc.
+ *
+ * Authors:
+ * David Hildenbrand <david@redhat.com>
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+
+#ifndef MEMORY_DEVICE_H
+#define MEMORY_DEVICE_H
+
+#include "qom/object.h"
+#include "hw/qdev.h"
+
+#define TYPE_MEMORY_DEVICE "memory-device"
+
+#define MEMORY_DEVICE_CLASS(klass) \
+ OBJECT_CLASS_CHECK(MemoryDeviceClass, (klass), TYPE_MEMORY_DEVICE)
+#define MEMORY_DEVICE_GET_CLASS(obj) \
+ OBJECT_GET_CLASS(MemoryDeviceClass, (obj), TYPE_MEMORY_DEVICE)
+#define MEMORY_DEVICE(obj) \
+ INTERFACE_CHECK(MemoryDeviceState, (obj), TYPE_MEMORY_DEVICE)
+
+typedef struct MemoryDeviceState {
+ Object parent_obj;
+} MemoryDeviceState;
+
+typedef struct MemoryDeviceClass {
+ InterfaceClass parent_class;
+
+ uint64_t (*get_addr)(MemoryDeviceState *md);
+ uint64_t (*get_plugged_size)(MemoryDeviceState *md, Error **errp);
+ uint64_t (*get_region_size)(MemoryDeviceState *md, Error **errp);
+ void (*fill_device_info)(MemoryDeviceState *md, MemoryDeviceInfo *info);
+} MemoryDeviceClass;
+
+MemoryDeviceInfoList *qmp_memory_device_list(void);
+uint64_t get_plugged_memory_size(void);
+
+#endif
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index 1fc479281c..e88073321f 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -93,9 +93,7 @@ uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
int pc_dimm_get_free_slot(const int *hint, int max_slots, Error **errp);
-MemoryDeviceInfoList *qmp_pc_dimm_device_list(void);
uint64_t pc_existing_dimms_capacity(Error **errp);
-uint64_t get_plugged_memory_size(void);
void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms,
MemoryRegion *mr, uint64_t align, Error **errp);
void pc_dimm_memory_unplug(DeviceState *dev, MemoryHotplugState *hpms,
diff --git a/numa.c b/numa.c
index 1116c90af9..6a0eaebc01 100644
--- a/numa.c
+++ b/numa.c
@@ -36,6 +36,7 @@
#include "hw/boards.h"
#include "sysemu/hostmem.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/memory-device.h"
#include "qemu/option.h"
#include "qemu/config-file.h"
#include "qemu/cutils.h"
@@ -520,7 +521,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
static void numa_stat_memory_devices(NumaNodeMem node_mem[])
{
- MemoryDeviceInfoList *info_list = qmp_pc_dimm_device_list();
+ MemoryDeviceInfoList *info_list = qmp_memory_device_list();
MemoryDeviceInfoList *info;
PCDIMMDeviceInfo *pcdimm_info;
diff --git a/qmp.c b/qmp.c
index f72261667f..3de029946a 100644
--- a/qmp.c
+++ b/qmp.c
@@ -39,7 +39,7 @@
#include "qapi/qobject-input-visitor.h"
#include "hw/boards.h"
#include "qom/object_interfaces.h"
-#include "hw/mem/pc-dimm.h"
+#include "hw/mem/memory-device.h"
#include "hw/acpi/acpi_dev_interface.h"
NameInfo *qmp_query_name(Error **errp)
@@ -731,7 +731,7 @@ void qmp_object_del(const char *id, Error **errp)
MemoryDeviceInfoList *qmp_query_memory_devices(Error **errp)
{
- return qmp_pc_dimm_device_list();
+ return qmp_memory_device_list();
}
ACPIOSTInfoList *qmp_query_acpi_ospm_status(Error **errp)
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index 2d59d84091..53d3f32cb2 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -34,7 +34,7 @@ stub-obj-y += uuid.o
stub-obj-y += vm-stop.o
stub-obj-y += vmstate.o
stub-obj-$(CONFIG_WIN32) += fd-register.o
-stub-obj-y += qmp_pc_dimm.o
+stub-obj-y += qmp_memory_device.o
stub-obj-y += target-monitor-defs.o
stub-obj-y += target-get-monitor-def.o
stub-obj-y += pc_madt_cpu_entry.o
diff --git a/stubs/qmp_pc_dimm.c b/stubs/qmp_memory_device.c
similarity index 61%
rename from stubs/qmp_pc_dimm.c
rename to stubs/qmp_memory_device.c
index b6b2cca89e..85ff8f2d7e 100644
--- a/stubs/qmp_pc_dimm.c
+++ b/stubs/qmp_memory_device.c
@@ -1,8 +1,8 @@
#include "qemu/osdep.h"
#include "qom/object.h"
-#include "hw/mem/pc-dimm.h"
+#include "hw/mem/memory-device.h"
-MemoryDeviceInfoList *qmp_pc_dimm_device_list(void)
+MemoryDeviceInfoList *qmp_memory_device_list(void)
{
return NULL;
}
--
2.14.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v2 2/3] machine: make MemoryHotplugState accessible via the machine
2018-04-12 14:36 [Qemu-devel] [PATCH v2 0/3] pc-dimm: factor out MemoryDevice David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface David Hildenbrand
@ 2018-04-12 14:36 ` David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 3/3] pc-dimm: factor out address space logic into MemoryDevice code David Hildenbrand
2 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand @ 2018-04-12 14:36 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-s390x, Michael S . Tsirkin, Igor Mammedov, Marcel Apfelbaum,
Paolo Bonzini, Richard Henderson, Eduardo Habkost, David Gibson,
Markus Armbruster, qemu-ppc, Pankaj Gupta, David Hildenbrand
Let's allow to query the MemoryHotplugState from the machine.
This allows us to generically detect if a certain machine has support
for memory devices, and to generically manage it (find free address
range, plug/unplug a memory region).
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/i386/pc.c | 12 ++++++++++++
hw/ppc/spapr.c | 12 ++++++++++++
include/hw/boards.h | 16 ++++++++++++++++
include/hw/mem/pc-dimm.h | 12 +-----------
4 files changed, 41 insertions(+), 11 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index d36bac8c89..fa8862af33 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -2337,6 +2337,17 @@ static void x86_nmi(NMIState *n, int cpu_index, Error **errp)
}
}
+static MemoryHotplugState *pc_machine_get_memory_hotplug_state(MachineState *ms)
+{
+ PCMachineState *pcms = PC_MACHINE(ms);
+
+ if (!pcms->hotplug_memory.base) {
+ /* hotplug not supported */
+ return NULL;
+ }
+ return &pcms->hotplug_memory;
+}
+
static void pc_machine_class_init(ObjectClass *oc, void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
@@ -2376,6 +2387,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
hc->unplug = pc_machine_device_unplug_cb;
nc->nmi_monitor_handler = x86_nmi;
mc->default_cpu_type = TARGET_DEFAULT_CPU_TYPE;
+ mc->get_memory_hotplug_state = pc_machine_get_memory_hotplug_state;
object_class_property_add(oc, PC_MACHINE_MEMHP_REGION_SIZE, "int",
pc_machine_get_hotplug_memory_region_size, NULL,
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index a7428f7da7..7ccdb705b3 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3868,6 +3868,17 @@ PowerPCCPU *spapr_find_cpu(int vcpu_id)
return NULL;
}
+static MemoryHotplugState *spapr_get_memory_hotplug_state(MachineState *ms)
+{
+ sPAPRMachineState *spapr = SPAPR_MACHINE(ms);
+
+ if (!spapr->hotplug_memory.base) {
+ /* hotplug not supported */
+ return NULL;
+ }
+ return &spapr->hotplug_memory;
+}
+
static void spapr_machine_class_init(ObjectClass *oc, void *data)
{
MachineClass *mc = MACHINE_CLASS(oc);
@@ -3927,6 +3938,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data)
* in which LMBs are represented and hot-added
*/
mc->numa_mem_align_shift = 28;
+ mc->get_memory_hotplug_state = spapr_get_memory_hotplug_state;
smc->default_caps.caps[SPAPR_CAP_HTM] = SPAPR_CAP_OFF;
smc->default_caps.caps[SPAPR_CAP_VSX] = SPAPR_CAP_ON;
diff --git a/include/hw/boards.h b/include/hw/boards.h
index a609239112..447bdc7219 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -105,6 +105,17 @@ typedef struct {
CPUArchId cpus[0];
} CPUArchIdList;
+/**
+ * MemoryHotplugState:
+ * @base: address in guest physical address space where hotplug memory
+ * address space begins.
+ * @mr: hotplug memory address space container
+ */
+typedef struct MemoryHotplugState {
+ hwaddr base;
+ MemoryRegion mr;
+} MemoryHotplugState;
+
/**
* MachineClass:
* @max_cpus: maximum number of CPUs supported. Default: 1
@@ -156,6 +167,10 @@ typedef struct {
* should instead use "unimplemented-device" for all memory ranges where
* the guest will attempt to probe for a device that QEMU doesn't
* implement and a stub device is required.
+ * @get_memory_hotplug_state:
+ * If a machine support memory hotplug, the returned data ontains
+ * information about the portion of guest physical address space
+ * where memory devices can be mapped to (e.g. to hotplug a pc-dimm).
*/
struct MachineClass {
/*< private >*/
@@ -212,6 +227,7 @@ struct MachineClass {
unsigned cpu_index);
const CPUArchIdList *(*possible_cpu_arch_ids)(MachineState *machine);
int64_t (*get_default_cpu_node_id)(const MachineState *ms, int idx);
+ MemoryHotplugState *(*get_memory_hotplug_state)(MachineState *ms);
};
/**
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index e88073321f..8bda37adab 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -19,6 +19,7 @@
#include "exec/memory.h"
#include "sysemu/hostmem.h"
#include "hw/qdev.h"
+#include "hw/boards.h"
#define TYPE_PC_DIMM "pc-dimm"
#define PC_DIMM(obj) \
@@ -75,17 +76,6 @@ typedef struct PCDIMMDeviceClass {
MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm);
} PCDIMMDeviceClass;
-/**
- * MemoryHotplugState:
- * @base: address in guest physical address space where hotplug memory
- * address space begins.
- * @mr: hotplug memory address space container
- */
-typedef struct MemoryHotplugState {
- hwaddr base;
- MemoryRegion mr;
-} MemoryHotplugState;
-
uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
uint64_t address_space_size,
uint64_t *hint, uint64_t align, uint64_t size,
--
2.14.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH v2 3/3] pc-dimm: factor out address space logic into MemoryDevice code
2018-04-12 14:36 [Qemu-devel] [PATCH v2 0/3] pc-dimm: factor out MemoryDevice David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 2/3] machine: make MemoryHotplugState accessible via the machine David Hildenbrand
@ 2018-04-12 14:36 ` David Hildenbrand
2 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand @ 2018-04-12 14:36 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-s390x, Michael S . Tsirkin, Igor Mammedov, Marcel Apfelbaum,
Paolo Bonzini, Richard Henderson, Eduardo Habkost, David Gibson,
Markus Armbruster, qemu-ppc, Pankaj Gupta, David Hildenbrand
To be able to reuse MemoryDevice logic from other devices besides
pc-dimm, factor the relevant stuff out into the MemoryDevice code.
As we don't care about slots for memory devices that are not pc-dimm,
don't factor that part out.
Most of this patch just moves checks and logic around. While at it, make
the code properly detect certain error conditions better (e.g. fragmented
memory).
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/i386/pc.c | 12 +--
hw/mem/memory-device.c | 162 ++++++++++++++++++++++++++++++++++++
hw/mem/pc-dimm.c | 185 +++--------------------------------------
hw/ppc/spapr.c | 9 +-
include/hw/mem/memory-device.h | 4 +
include/hw/mem/pc-dimm.h | 14 +---
6 files changed, 185 insertions(+), 201 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index fa8862af33..1c25546a0c 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1711,7 +1711,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
goto out;
}
- pc_dimm_memory_plug(dev, &pcms->hotplug_memory, mr, align, &local_err);
+ pc_dimm_memory_plug(dev, align, &local_err);
if (local_err) {
goto out;
}
@@ -1761,17 +1761,9 @@ static void pc_dimm_unplug(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp)
{
PCMachineState *pcms = PC_MACHINE(hotplug_dev);
- PCDIMMDevice *dimm = PC_DIMM(dev);
- PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
- MemoryRegion *mr;
HotplugHandlerClass *hhc;
Error *local_err = NULL;
- mr = ddc->get_memory_region(dimm, &local_err);
- if (local_err) {
- goto out;
- }
-
hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev);
hhc->unplug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
@@ -1779,7 +1771,7 @@ static void pc_dimm_unplug(HotplugHandler *hotplug_dev,
goto out;
}
- pc_dimm_memory_unplug(dev, &pcms->hotplug_memory, mr);
+ pc_dimm_memory_unplug(dev);
object_unparent(OBJECT(dev));
out:
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 0e0d6b539a..611c3252f0 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -15,6 +15,8 @@
#include "qapi/error.h"
#include "hw/boards.h"
#include "qemu/range.h"
+#include "hw/virtio/vhost.h"
+#include "sysemu/kvm.h"
static gint memory_device_addr_sort(gconstpointer a, gconstpointer b)
{
@@ -105,6 +107,166 @@ uint64_t get_plugged_memory_size(void)
return size;
}
+static int memory_device_used_region_size_internal(Object *obj, void *opaque)
+{
+ uint64_t *size = opaque;
+
+ if (object_dynamic_cast(obj, TYPE_MEMORY_DEVICE)) {
+ DeviceState *dev = DEVICE(obj);
+ MemoryDeviceState *md = MEMORY_DEVICE(obj);
+ MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(obj);
+
+ if (dev->realized) {
+ *size += mdc->get_region_size(md, &error_abort);
+ }
+ }
+
+ object_child_foreach(obj, memory_device_used_region_size_internal, opaque);
+ return 0;
+}
+
+static uint64_t memory_device_used_region_size(void)
+{
+ uint64_t size = 0;
+
+ memory_device_used_region_size_internal(qdev_get_machine(), &size);
+
+ return size;
+}
+
+uint64_t memory_device_get_free_addr(uint64_t *hint, uint64_t align,
+ uint64_t size, Error **errp)
+{
+ const uint64_t used_region_size = memory_device_used_region_size();
+ uint64_t address_space_start, address_space_end;
+ MachineState *machine = MACHINE(qdev_get_machine());
+ MachineClass *mc = MACHINE_GET_CLASS(machine);
+ MemoryHotplugState *hpms;
+ GSList *list = NULL, *item;
+ uint64_t new_addr = 0;
+
+ if (!mc->get_memory_hotplug_state) {
+ error_setg(errp, "memory devices (e.g. for memory hotplug) are not "
+ "supported by the machine");
+ return 0;
+ }
+
+ hpms = mc->get_memory_hotplug_state(machine);
+ if (!hpms || !memory_region_size(&hpms->mr)) {
+ error_setg(errp, "memory devices (e.g. for memory hotplug) are not "
+ "enabled, please specify the maxmem option");
+ return 0;
+ }
+ address_space_start = hpms->base;
+ address_space_end = address_space_start + memory_region_size(&hpms->mr);
+ g_assert(address_space_end >= address_space_start);
+
+ if (used_region_size + size > machine->maxram_size - machine->ram_size) {
+ error_setg(errp, "not enough space, currently 0x%" PRIx64
+ " in use of total hot pluggable 0x" RAM_ADDR_FMT,
+ used_region_size, machine->maxram_size - machine->ram_size);
+ return 0;
+ }
+
+ if (hint && QEMU_ALIGN_UP(*hint, align) != *hint) {
+ error_setg(errp, "address must be aligned to 0x%" PRIx64 " bytes",
+ align);
+ return 0;
+ }
+
+ if (QEMU_ALIGN_UP(size, align) != size) {
+ error_setg(errp, "backend memory size must be multiple of 0x%"
+ PRIx64, align);
+ return 0;
+ }
+
+ if (hint) {
+ new_addr = *hint;
+ if (new_addr < address_space_start) {
+ error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
+ "] at 0x%" PRIx64, new_addr, size, address_space_start);
+ return 0;
+ } else if ((new_addr + size) > address_space_end) {
+ error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
+ "] beyond 0x%" PRIx64, new_addr, size,
+ address_space_end);
+ return 0;
+ }
+ } else {
+ new_addr = address_space_start;
+ }
+
+ /* find address range that will fit new memory device */
+ object_child_foreach(qdev_get_machine(), memory_device_built_list, &list);
+ for (item = list; item; item = g_slist_next(item)) {
+ MemoryDeviceState *md = item->data;
+ MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(OBJECT(md));
+ uint64_t md_size, md_addr;
+
+ md_addr = mdc->get_addr(md);
+ md_size = mdc->get_region_size(md, errp);
+ if (*errp) {
+ goto out;
+ }
+
+ if (ranges_overlap(md_addr, md_size, new_addr, size)) {
+ if (hint) {
+ DeviceState *d = DEVICE(md);
+ error_setg(errp, "address range conflicts with '%s'", d->id);
+ goto out;
+ }
+ new_addr = QEMU_ALIGN_UP(md_addr + md_size, align);
+ }
+ }
+
+ if (new_addr + size > address_space_end) {
+ error_setg(errp, "could not find position in guest address space for "
+ "memory device - memory fragmented due to alignments");
+ goto out;
+ }
+out:
+ g_slist_free(list);
+ return new_addr;
+}
+
+void memory_device_plug_region(MemoryRegion *mr, uint64_t addr, Error **errp)
+{
+ MachineState *machine = MACHINE(qdev_get_machine());
+ MachineClass *mc = MACHINE_GET_CLASS(machine);
+ MemoryHotplugState *hpms;
+
+ /* we expect a previous call to memory_device_get_free_addr() */
+ g_assert(mc->get_memory_hotplug_state);
+ hpms = mc->get_memory_hotplug_state(machine);
+ g_assert(hpms);
+
+ /* we will need a new memory slot for kvm and vhost */
+ if (kvm_enabled() && !kvm_has_free_slot(machine)) {
+ error_setg(errp, "hypervisor has no free memory slots left");
+ return;
+ }
+ if (!vhost_has_free_slot()) {
+ error_setg(errp, "a used vhost backend has no free memory slots left");
+ return;
+ }
+
+ memory_region_add_subregion(&hpms->mr, addr - hpms->base, mr);
+}
+
+void memory_device_unplug_region(MemoryRegion *mr)
+{
+ MachineState *machine = MACHINE(qdev_get_machine());
+ MachineClass *mc = MACHINE_GET_CLASS(machine);
+ MemoryHotplugState *hpms;
+
+ /* we expect a previous call to memory_device_get_free_addr() */
+ g_assert(mc->get_memory_hotplug_state);
+ hpms = mc->get_memory_hotplug_state(machine);
+ g_assert(hpms);
+
+ memory_region_del_subregion(&hpms->mr, mr);
+}
+
static const TypeInfo memory_device_info = {
.name = TYPE_MEMORY_DEVICE,
.parent = TYPE_INTERFACE,
diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 1dbf699e02..cf23ab5d76 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -25,19 +25,10 @@
#include "qapi/error.h"
#include "qemu/config-file.h"
#include "qapi/visitor.h"
-#include "qemu/range.h"
#include "sysemu/numa.h"
-#include "sysemu/kvm.h"
#include "trace.h"
-#include "hw/virtio/vhost.h"
-typedef struct pc_dimms_capacity {
- uint64_t size;
- Error **errp;
-} pc_dimms_capacity;
-
-void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms,
- MemoryRegion *mr, uint64_t align, Error **errp)
+void pc_dimm_memory_plug(DeviceState *dev, uint64_t align, Error **errp)
{
int slot;
MachineState *machine = MACHINE(qdev_get_machine());
@@ -45,37 +36,26 @@ void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms,
PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
Error *local_err = NULL;
- uint64_t existing_dimms_capacity = 0;
+ MemoryRegion *mr;
uint64_t addr;
- addr = object_property_get_uint(OBJECT(dimm),
- PC_DIMM_ADDR_PROP, &local_err);
+ mr = ddc->get_memory_region(dimm, &local_err);
if (local_err) {
goto out;
}
- addr = pc_dimm_get_free_addr(hpms->base,
- memory_region_size(&hpms->mr),
- !addr ? NULL : &addr, align,
- memory_region_size(mr), &local_err);
+ addr = object_property_get_uint(OBJECT(dimm),
+ PC_DIMM_ADDR_PROP, &local_err);
if (local_err) {
goto out;
}
- existing_dimms_capacity = pc_existing_dimms_capacity(&local_err);
+ addr = memory_device_get_free_addr(!addr ? NULL : &addr, align,
+ memory_region_size(mr), &local_err);
if (local_err) {
goto out;
}
- if (existing_dimms_capacity + memory_region_size(mr) >
- machine->maxram_size - machine->ram_size) {
- error_setg(&local_err, "not enough space, currently 0x%" PRIx64
- " in use of total hot pluggable 0x" RAM_ADDR_FMT,
- existing_dimms_capacity,
- machine->maxram_size - machine->ram_size);
- goto out;
- }
-
object_property_set_uint(OBJECT(dev), addr, PC_DIMM_ADDR_PROP, &local_err);
if (local_err) {
goto out;
@@ -98,67 +78,27 @@ void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms,
}
trace_mhp_pc_dimm_assigned_slot(slot);
- if (kvm_enabled() && !kvm_has_free_slot(machine)) {
- error_setg(&local_err, "hypervisor has no free memory slots left");
- goto out;
- }
-
- if (!vhost_has_free_slot()) {
- error_setg(&local_err, "a used vhost backend has no free"
- " memory slots left");
+ memory_device_plug_region(mr, addr, &local_err);
+ if (local_err) {
goto out;
}
-
- memory_region_add_subregion(&hpms->mr, addr - hpms->base, mr);
vmstate_register_ram(vmstate_mr, dev);
out:
error_propagate(errp, local_err);
}
-void pc_dimm_memory_unplug(DeviceState *dev, MemoryHotplugState *hpms,
- MemoryRegion *mr)
+void pc_dimm_memory_unplug(DeviceState *dev)
{
PCDIMMDevice *dimm = PC_DIMM(dev);
PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
+ MemoryRegion *mr = ddc->get_memory_region(dimm, &error_abort);
- memory_region_del_subregion(&hpms->mr, mr);
+ memory_device_unplug_region(mr);
vmstate_unregister_ram(vmstate_mr, dev);
}
-static int pc_existing_dimms_capacity_internal(Object *obj, void *opaque)
-{
- pc_dimms_capacity *cap = opaque;
- uint64_t *size = &cap->size;
-
- if (object_dynamic_cast(obj, TYPE_PC_DIMM)) {
- DeviceState *dev = DEVICE(obj);
-
- if (dev->realized) {
- (*size) += object_property_get_uint(obj, PC_DIMM_SIZE_PROP,
- cap->errp);
- }
-
- if (cap->errp && *cap->errp) {
- return 1;
- }
- }
- object_child_foreach(obj, pc_existing_dimms_capacity_internal, opaque);
- return 0;
-}
-
-uint64_t pc_existing_dimms_capacity(Error **errp)
-{
- pc_dimms_capacity cap;
-
- cap.size = 0;
- cap.errp = errp;
-
- pc_existing_dimms_capacity_internal(qdev_get_machine(), &cap);
- return cap.size;
-}
-
static int pc_dimm_slot2bitmap(Object *obj, void *opaque)
{
unsigned long *bitmap = opaque;
@@ -205,107 +145,6 @@ out:
return slot;
}
-static gint pc_dimm_addr_sort(gconstpointer a, gconstpointer b)
-{
- PCDIMMDevice *x = PC_DIMM(a);
- PCDIMMDevice *y = PC_DIMM(b);
- Int128 diff = int128_sub(int128_make64(x->addr), int128_make64(y->addr));
-
- if (int128_lt(diff, int128_zero())) {
- return -1;
- } else if (int128_gt(diff, int128_zero())) {
- return 1;
- }
- return 0;
-}
-
-static int pc_dimm_built_list(Object *obj, void *opaque)
-{
- GSList **list = opaque;
-
- if (object_dynamic_cast(obj, TYPE_PC_DIMM)) {
- DeviceState *dev = DEVICE(obj);
- if (dev->realized) { /* only realized DIMMs matter */
- *list = g_slist_insert_sorted(*list, dev, pc_dimm_addr_sort);
- }
- }
-
- object_child_foreach(obj, pc_dimm_built_list, opaque);
- return 0;
-}
-
-uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
- uint64_t address_space_size,
- uint64_t *hint, uint64_t align, uint64_t size,
- Error **errp)
-{
- GSList *list = NULL, *item;
- uint64_t new_addr, ret = 0;
- uint64_t address_space_end = address_space_start + address_space_size;
-
- g_assert(QEMU_ALIGN_UP(address_space_start, align) == address_space_start);
-
- if (!address_space_size) {
- error_setg(errp, "memory hotplug is not enabled, "
- "please add maxmem option");
- goto out;
- }
-
- if (hint && QEMU_ALIGN_UP(*hint, align) != *hint) {
- error_setg(errp, "address must be aligned to 0x%" PRIx64 " bytes",
- align);
- goto out;
- }
-
- if (QEMU_ALIGN_UP(size, align) != size) {
- error_setg(errp, "backend memory size must be multiple of 0x%"
- PRIx64, align);
- goto out;
- }
-
- assert(address_space_end > address_space_start);
- object_child_foreach(qdev_get_machine(), pc_dimm_built_list, &list);
-
- if (hint) {
- new_addr = *hint;
- } else {
- new_addr = address_space_start;
- }
-
- /* find address range that will fit new DIMM */
- for (item = list; item; item = g_slist_next(item)) {
- PCDIMMDevice *dimm = item->data;
- uint64_t dimm_size = object_property_get_uint(OBJECT(dimm),
- PC_DIMM_SIZE_PROP,
- errp);
- if (errp && *errp) {
- goto out;
- }
-
- if (ranges_overlap(dimm->addr, dimm_size, new_addr, size)) {
- if (hint) {
- DeviceState *d = DEVICE(dimm);
- error_setg(errp, "address range conflicts with '%s'", d->id);
- goto out;
- }
- new_addr = QEMU_ALIGN_UP(dimm->addr + dimm_size, align);
- }
- }
- ret = new_addr;
-
- if (new_addr < address_space_start) {
- error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
- "] at 0x%" PRIx64, new_addr, size, address_space_start);
- } else if ((new_addr + size) > address_space_end) {
- error_setg(errp, "can't add memory [0x%" PRIx64 ":0x%" PRIx64
- "] beyond 0x%" PRIx64, new_addr, size, address_space_end);
- }
-
-out:
- g_slist_free(list);
- return ret;
-}
-
static Property pc_dimm_properties[] = {
DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMDevice, addr, 0),
DEFINE_PROP_UINT32(PC_DIMM_NODE_PROP, PCDIMMDevice, node, 0),
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 7ccdb705b3..7757a49335 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3041,7 +3041,7 @@ static void spapr_memory_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
align = memory_region_get_alignment(mr);
size = memory_region_size(mr);
- pc_dimm_memory_plug(dev, &ms->hotplug_memory, mr, align, &local_err);
+ pc_dimm_memory_plug(dev, align, &local_err);
if (local_err) {
goto out;
}
@@ -3062,7 +3062,7 @@ static void spapr_memory_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
return;
out_unplug:
- pc_dimm_memory_unplug(dev, &ms->hotplug_memory, mr);
+ pc_dimm_memory_unplug(dev);
out:
error_propagate(errp, local_err);
}
@@ -3180,9 +3180,6 @@ static sPAPRDIMMState *spapr_recover_pending_dimm_state(sPAPRMachineState *ms,
void spapr_lmb_release(DeviceState *dev)
{
sPAPRMachineState *spapr = SPAPR_MACHINE(qdev_get_hotplug_handler(dev));
- PCDIMMDevice *dimm = PC_DIMM(dev);
- PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
- MemoryRegion *mr = ddc->get_memory_region(dimm, &error_abort);
sPAPRDIMMState *ds = spapr_pending_dimm_unplugs_find(spapr, PC_DIMM(dev));
/* This information will get lost if a migration occurs
@@ -3202,7 +3199,7 @@ void spapr_lmb_release(DeviceState *dev)
* Now that all the LMBs have been removed by the guest, call the
* pc-dimm unplug handler to cleanup up the pc-dimm device.
*/
- pc_dimm_memory_unplug(dev, &spapr->hotplug_memory, mr);
+ pc_dimm_memory_unplug(dev);
object_unparent(OBJECT(dev));
spapr_pending_dimm_unplugs_remove(spapr, ds);
}
diff --git a/include/hw/mem/memory-device.h b/include/hw/mem/memory-device.h
index 3e498b2e61..722620da24 100644
--- a/include/hw/mem/memory-device.h
+++ b/include/hw/mem/memory-device.h
@@ -40,5 +40,9 @@ typedef struct MemoryDeviceClass {
MemoryDeviceInfoList *qmp_memory_device_list(void);
uint64_t get_plugged_memory_size(void);
+uint64_t memory_device_get_free_addr(uint64_t *hint, uint64_t align,
+ uint64_t size, Error **errp);
+void memory_device_plug_region(MemoryRegion *mr, uint64_t addr, Error **errp);
+void memory_device_unplug_region(MemoryRegion *mr);
#endif
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index 8bda37adab..2e7c2abe35 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -19,7 +19,6 @@
#include "exec/memory.h"
#include "sysemu/hostmem.h"
#include "hw/qdev.h"
-#include "hw/boards.h"
#define TYPE_PC_DIMM "pc-dimm"
#define PC_DIMM(obj) \
@@ -76,16 +75,7 @@ typedef struct PCDIMMDeviceClass {
MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm);
} PCDIMMDeviceClass;
-uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
- uint64_t address_space_size,
- uint64_t *hint, uint64_t align, uint64_t size,
- Error **errp);
-
int pc_dimm_get_free_slot(const int *hint, int max_slots, Error **errp);
-
-uint64_t pc_existing_dimms_capacity(Error **errp);
-void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms,
- MemoryRegion *mr, uint64_t align, Error **errp);
-void pc_dimm_memory_unplug(DeviceState *dev, MemoryHotplugState *hpms,
- MemoryRegion *mr);
+void pc_dimm_memory_plug(DeviceState *dev, uint64_t align, Error **errp);
+void pc_dimm_memory_unplug(DeviceState *dev);
#endif
--
2.14.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface David Hildenbrand
@ 2018-04-13 3:25 ` David Gibson
2018-04-13 6:36 ` David Hildenbrand
0 siblings, 1 reply; 6+ messages in thread
From: David Gibson @ 2018-04-13 3:25 UTC (permalink / raw)
To: David Hildenbrand
Cc: qemu-devel, qemu-s390x, Michael S . Tsirkin, Igor Mammedov,
Marcel Apfelbaum, Paolo Bonzini, Richard Henderson,
Eduardo Habkost, Markus Armbruster, qemu-ppc, Pankaj Gupta
[-- Attachment #1: Type: text/plain, Size: 19786 bytes --]
On Thu, Apr 12, 2018 at 04:36:33PM +0200, David Hildenbrand wrote:
> On the qmp level, we already have the concept of memory devices:
> "query-memory-devices"
> Right now, we only support NVDIMM and PCDIMM.
>
> We want to map other devices later into the address space of the guest.
> Such device could e.g. be virtio devices. These devices will have a
> guest memory range assigned but won't be exposed via e.g. ACPI. We want
> to make them look like memory device, but not glued to pc-dimm.
>
> Especially, it will not always be possible to have TYPE_PC_DIMM as a parent
> class (e.g. virtio devices). Let's use an interface instead. As a first
> part, convert handling of
> - qmp_pc_dimm_device_list
> - get_plugged_memory_size
> to our new model. plug/unplug stuff etc. will follow later.
>
> A memory device will have to provide the following functions:
> - get_addr(): Necessary, as the property "addr" can e.g. not be used for
> virtio devices (already defined).
Is the assumption here that a memory device has a fixed RAM address
(GPA) from when it is realized? It seems to me plausible that you
could have a memory device that has a specific size, but has a BAR of
some sort that's programmed by the guest as part of the "plug"
process.
> - get_plugged_size(): The amount this device offers to the guest as of
> now.
> - get_region_size(): Because this can later on be bigger than the
> plugged size.
> - fill_device_info(): Fill MemoryDeviceInfo, e.g. for qmp.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/i386/acpi-build.c | 3 +-
> hw/mem/Makefile.objs | 1 +
> hw/mem/memory-device.c | 119 +++++++++++++++++++++++++++
> hw/mem/pc-dimm.c | 119 ++++++++++++++-------------
> hw/ppc/spapr.c | 3 +-
> hw/ppc/spapr_hcall.c | 1 +
> include/hw/mem/memory-device.h | 44 ++++++++++
> include/hw/mem/pc-dimm.h | 2 -
> numa.c | 3 +-
> qmp.c | 4 +-
> stubs/Makefile.objs | 2 +-
> stubs/{qmp_pc_dimm.c => qmp_memory_device.c} | 4 +-
> 12 files changed, 239 insertions(+), 66 deletions(-)
> create mode 100644 hw/mem/memory-device.c
> create mode 100644 include/hw/mem/memory-device.h
> rename stubs/{qmp_pc_dimm.c => qmp_memory_device.c} (61%)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 3cf2a1679c..ca3645d57b 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -46,6 +46,7 @@
> #include "hw/acpi/vmgenid.h"
> #include "sysemu/tpm_backend.h"
> #include "hw/timer/mc146818rtc_regs.h"
> +#include "hw/mem/memory-device.h"
> #include "sysemu/numa.h"
>
> /* Supported chipsets: */
> @@ -2253,7 +2254,7 @@ build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog)
> static void build_srat_hotpluggable_memory(GArray *table_data, uint64_t base,
> uint64_t len, int default_node)
> {
> - MemoryDeviceInfoList *info_list = qmp_pc_dimm_device_list();
> + MemoryDeviceInfoList *info_list = qmp_memory_device_list();
> MemoryDeviceInfoList *info;
> MemoryDeviceInfo *mi;
> PCDIMMDeviceInfo *di;
> diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
> index f12f8b97a2..10be4df2a2 100644
> --- a/hw/mem/Makefile.objs
> +++ b/hw/mem/Makefile.objs
> @@ -1,2 +1,3 @@
> common-obj-$(CONFIG_MEM_HOTPLUG) += pc-dimm.o
> +common-obj-$(CONFIG_MEM_HOTPLUG) += memory-device.o
> common-obj-$(CONFIG_NVDIMM) += nvdimm.o
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> new file mode 100644
> index 0000000000..0e0d6b539a
> --- /dev/null
> +++ b/hw/mem/memory-device.c
> @@ -0,0 +1,119 @@
> +/*
> + * Memory Device Interface
> + *
> + * Copyright ProfitBricks GmbH 2012
> + * Copyright (C) 2014 Red Hat Inc
> + * Copyright (c) 2018 Red Hat Inc
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#include "qemu/osdep.h"
> +#include "hw/mem/memory-device.h"
> +#include "hw/qdev.h"
> +#include "qapi/error.h"
> +#include "hw/boards.h"
> +#include "qemu/range.h"
> +
> +static gint memory_device_addr_sort(gconstpointer a, gconstpointer b)
> +{
> + MemoryDeviceState *md_a = MEMORY_DEVICE(a);
> + MemoryDeviceState *md_b = MEMORY_DEVICE(b);
> + MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(a);
AFAICT from the code below, the two devices don't necessarily have to
have the same class, so I think you need to get the class pointers for
each of them separately. (Or if they do have to be the same by
design, I think there should at least be an assert).
> + const uint64_t addr_a = mdc->get_addr(md_a);
> + const uint64_t addr_b = mdc->get_addr(md_b);
> +
> + if (addr_a > addr_b) {
> + return 1;
> + } else if (addr_a < addr_b) {
> + return -1;
> + }
> + return 0;
> +}
> +
> +static int memory_device_built_list(Object *obj, void *opaque)
> +{
> + GSList **list = opaque;
> +
> + if (object_dynamic_cast(obj, TYPE_MEMORY_DEVICE)) {
> + DeviceState *dev = DEVICE(obj);
> + if (dev->realized) { /* only realized memory devices matter */
> + *list = g_slist_insert_sorted(*list, dev, memory_device_addr_sort);
> + }
> + }
> +
> + object_child_foreach(obj, memory_device_built_list, opaque);
> + return 0;
> +}
> +
> +MemoryDeviceInfoList *qmp_memory_device_list(void)
> +{
> + GSList *devices = NULL, *item;
> + MemoryDeviceInfoList *list = NULL, *prev = NULL;
> +
> + object_child_foreach(qdev_get_machine(), memory_device_built_list,
> + &devices);
> +
> + for (item = devices; item; item = g_slist_next(item)) {
> + MemoryDeviceState *md = MEMORY_DEVICE(item->data);
> + MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(item->data);
> + MemoryDeviceInfoList *elem = g_new0(MemoryDeviceInfoList, 1);
> + MemoryDeviceInfo *info = g_new0(MemoryDeviceInfo, 1);
> +
> + mdc->fill_device_info(md, info);
> +
> + elem->value = info;
> + elem->next = NULL;
> + if (prev) {
> + prev->next = elem;
> + } else {
> + list = elem;
> + }
> + prev = elem;
> + }
> +
> + g_slist_free(devices);
> +
> + return list;
> +}
> +
> +static int memory_device_plugged_size(Object *obj, void *opaque)
> +{
> + uint64_t *size = opaque;
> +
> + if (object_dynamic_cast(obj, TYPE_MEMORY_DEVICE)) {
> + DeviceState *dev = DEVICE(obj);
> + MemoryDeviceState *md = MEMORY_DEVICE(obj);
> + MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(obj);
> +
> + if (dev->realized) {
> + *size += mdc->get_plugged_size(md, &error_abort);
> + }
> + }
> +
> + object_child_foreach(obj, memory_device_plugged_size, opaque);
> + return 0;
> +}
> +
> +uint64_t get_plugged_memory_size(void)
> +{
> + uint64_t size = 0;
> +
> + memory_device_plugged_size(qdev_get_machine(), &size);
> +
> + return size;
> +}
> +
> +static const TypeInfo memory_device_info = {
> + .name = TYPE_MEMORY_DEVICE,
> + .parent = TYPE_INTERFACE,
> + .class_size = sizeof(MemoryDeviceClass),
> +};
> +
> +static void memory_device_register_types(void)
> +{
> + type_register_static(&memory_device_info);
> +}
> +
> +type_init(memory_device_register_types)
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 51350d9c2d..1dbf699e02 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -21,6 +21,7 @@
> #include "qemu/osdep.h"
> #include "hw/mem/pc-dimm.h"
> #include "hw/mem/nvdimm.h"
> +#include "hw/mem/memory-device.h"
> #include "qapi/error.h"
> #include "qemu/config-file.h"
> #include "qapi/visitor.h"
> @@ -158,11 +159,6 @@ uint64_t pc_existing_dimms_capacity(Error **errp)
> return cap.size;
> }
>
> -uint64_t get_plugged_memory_size(void)
> -{
> - return pc_existing_dimms_capacity(&error_abort);
> -}
> -
> static int pc_dimm_slot2bitmap(Object *obj, void *opaque)
> {
> unsigned long *bitmap = opaque;
> @@ -238,57 +234,6 @@ static int pc_dimm_built_list(Object *obj, void *opaque)
> return 0;
> }
>
> -MemoryDeviceInfoList *qmp_pc_dimm_device_list(void)
> -{
> - GSList *dimms = NULL, *item;
> - MemoryDeviceInfoList *list = NULL, *prev = NULL;
> -
> - object_child_foreach(qdev_get_machine(), pc_dimm_built_list, &dimms);
> -
> - for (item = dimms; item; item = g_slist_next(item)) {
> - PCDIMMDevice *dimm = PC_DIMM(item->data);
> - Object *obj = OBJECT(dimm);
> - MemoryDeviceInfoList *elem = g_new0(MemoryDeviceInfoList, 1);
> - MemoryDeviceInfo *info = g_new0(MemoryDeviceInfo, 1);
> - PCDIMMDeviceInfo *di = g_new0(PCDIMMDeviceInfo, 1);
> - bool is_nvdimm = object_dynamic_cast(obj, TYPE_NVDIMM);
> - DeviceClass *dc = DEVICE_GET_CLASS(obj);
> - DeviceState *dev = DEVICE(obj);
> -
> - if (dev->id) {
> - di->has_id = true;
> - di->id = g_strdup(dev->id);
> - }
> - di->hotplugged = dev->hotplugged;
> - di->hotpluggable = dc->hotpluggable;
> - di->addr = dimm->addr;
> - di->slot = dimm->slot;
> - di->node = dimm->node;
> - di->size = object_property_get_uint(obj, PC_DIMM_SIZE_PROP, NULL);
> - di->memdev = object_get_canonical_path(OBJECT(dimm->hostmem));
> -
> - if (!is_nvdimm) {
> - info->u.dimm.data = di;
> - info->type = MEMORY_DEVICE_INFO_KIND_DIMM;
> - } else {
> - info->u.nvdimm.data = di;
> - info->type = MEMORY_DEVICE_INFO_KIND_NVDIMM;
> - }
> - elem->value = info;
> - elem->next = NULL;
> - if (prev) {
> - prev->next = elem;
> - } else {
> - list = elem;
> - }
> - prev = elem;
> - }
> -
> - g_slist_free(dimms);
> -
> - return list;
> -}
> -
> uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
> uint64_t address_space_size,
> uint64_t *hint, uint64_t align, uint64_t size,
> @@ -445,10 +390,62 @@ static MemoryRegion *pc_dimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
> return host_memory_backend_get_memory(dimm->hostmem, &error_abort);
> }
>
> +static uint64_t pc_dimm_md_get_addr(MemoryDeviceState *md)
> +{
> + PCDIMMDevice *dimm = PC_DIMM(md);
> +
> + return dimm->addr;
> +}
> +
> +static uint64_t pc_dimm_md_get_region_size(MemoryDeviceState *md, Error **errp)
> +{
> + PCDIMMDevice *dimm = PC_DIMM(md);
> + PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(md);
> + MemoryRegion *mr;
> +
> + mr = ddc->get_memory_region(dimm, errp);
> + if (!mr) {
> + return 0;
> + }
> +
> + return memory_region_size(mr);
> +}
> +
> +static void pc_dimm_md_fill_device_info(MemoryDeviceState *md,
> + MemoryDeviceInfo *info)
> +{
> + PCDIMMDeviceInfo *di = g_new0(PCDIMMDeviceInfo, 1);
> + DeviceClass *dc = DEVICE_GET_CLASS(md);
> + PCDIMMDevice *dimm = PC_DIMM(md);
> + DeviceState *dev = DEVICE(md);
> +
> + if (dev->id) {
> + di->has_id = true;
> + di->id = g_strdup(dev->id);
> + }
> + di->hotplugged = dev->hotplugged;
> + di->hotpluggable = dc->hotpluggable;
> + di->addr = dimm->addr;
> + di->slot = dimm->slot;
> + di->node = dimm->node;
> + di->size = object_property_get_uint(OBJECT(dimm), PC_DIMM_SIZE_PROP,
> + NULL);
> + di->memdev = object_get_canonical_path(OBJECT(dimm->hostmem));
> +
> + if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
> + info->u.nvdimm.data = di;
> + info->type = MEMORY_DEVICE_INFO_KIND_NVDIMM;
> + } else {
> + info->u.dimm.data = di;
> + info->type = MEMORY_DEVICE_INFO_KIND_DIMM;
> + }
> +}
> +
> static void pc_dimm_class_init(ObjectClass *oc, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(oc);
> PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc);
> + MemoryDeviceClass *mdc = MEMORY_DEVICE_CLASS(oc);
>
> dc->realize = pc_dimm_realize;
> dc->unrealize = pc_dimm_unrealize;
> @@ -457,6 +454,12 @@ static void pc_dimm_class_init(ObjectClass *oc, void *data)
>
> ddc->get_memory_region = pc_dimm_get_memory_region;
> ddc->get_vmstate_memory_region = pc_dimm_get_vmstate_memory_region;
> +
> + mdc->get_addr = pc_dimm_md_get_addr;
> + /* for a dimm plugged_size == region_size */
> + mdc->get_plugged_size = pc_dimm_md_get_region_size;
> + mdc->get_region_size = pc_dimm_md_get_region_size;
> + mdc->fill_device_info = pc_dimm_md_fill_device_info;
> }
>
> static TypeInfo pc_dimm_info = {
> @@ -466,6 +469,10 @@ static TypeInfo pc_dimm_info = {
> .instance_init = pc_dimm_init,
> .class_init = pc_dimm_class_init,
> .class_size = sizeof(PCDIMMDeviceClass),
> + .interfaces = (InterfaceInfo[]) {
> + { TYPE_MEMORY_DEVICE },
> + { }
> + },
> };
>
> static void pc_dimm_register_types(void)
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index a81570e7c8..a7428f7da7 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -74,6 +74,7 @@
> #include "hw/compat.h"
> #include "qemu/cutils.h"
> #include "hw/ppc/spapr_cpu_core.h"
> +#include "hw/mem/memory-device.h"
>
> #include <libfdt.h>
>
> @@ -722,7 +723,7 @@ static int spapr_populate_drconf_memory(sPAPRMachineState *spapr, void *fdt)
> }
>
> if (hotplug_lmb_start) {
> - dimms = qmp_pc_dimm_device_list();
> + dimms = qmp_memory_device_list();
> }
>
> /* ibm,dynamic-memory */
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index 16bccdd5c0..4cdae3ca3a 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -14,6 +14,7 @@
> #include "kvm_ppc.h"
> #include "hw/ppc/spapr_ovec.h"
> #include "mmu-book3s-v3.h"
> +#include "hw/mem/memory-device.h"
>
> struct SPRSyncState {
> int spr;
> diff --git a/include/hw/mem/memory-device.h b/include/hw/mem/memory-device.h
> new file mode 100644
> index 0000000000..3e498b2e61
> --- /dev/null
> +++ b/include/hw/mem/memory-device.h
> @@ -0,0 +1,44 @@
> +/*
> + * Memory Device Interface
> + *
> + * Copyright (c) 2018 Red Hat, Inc.
> + *
> + * Authors:
> + * David Hildenbrand <david@redhat.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#ifndef MEMORY_DEVICE_H
> +#define MEMORY_DEVICE_H
> +
> +#include "qom/object.h"
> +#include "hw/qdev.h"
> +
> +#define TYPE_MEMORY_DEVICE "memory-device"
> +
> +#define MEMORY_DEVICE_CLASS(klass) \
> + OBJECT_CLASS_CHECK(MemoryDeviceClass, (klass), TYPE_MEMORY_DEVICE)
> +#define MEMORY_DEVICE_GET_CLASS(obj) \
> + OBJECT_GET_CLASS(MemoryDeviceClass, (obj), TYPE_MEMORY_DEVICE)
> +#define MEMORY_DEVICE(obj) \
> + INTERFACE_CHECK(MemoryDeviceState, (obj), TYPE_MEMORY_DEVICE)
> +
> +typedef struct MemoryDeviceState {
> + Object parent_obj;
> +} MemoryDeviceState;
> +
> +typedef struct MemoryDeviceClass {
> + InterfaceClass parent_class;
> +
> + uint64_t (*get_addr)(MemoryDeviceState *md);
> + uint64_t (*get_plugged_size)(MemoryDeviceState *md, Error **errp);
> + uint64_t (*get_region_size)(MemoryDeviceState *md, Error **errp);
> + void (*fill_device_info)(MemoryDeviceState *md, MemoryDeviceInfo *info);
> +} MemoryDeviceClass;
> +
> +MemoryDeviceInfoList *qmp_memory_device_list(void);
> +uint64_t get_plugged_memory_size(void);
> +
> +#endif
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index 1fc479281c..e88073321f 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -93,9 +93,7 @@ uint64_t pc_dimm_get_free_addr(uint64_t address_space_start,
>
> int pc_dimm_get_free_slot(const int *hint, int max_slots, Error **errp);
>
> -MemoryDeviceInfoList *qmp_pc_dimm_device_list(void);
> uint64_t pc_existing_dimms_capacity(Error **errp);
> -uint64_t get_plugged_memory_size(void);
> void pc_dimm_memory_plug(DeviceState *dev, MemoryHotplugState *hpms,
> MemoryRegion *mr, uint64_t align, Error **errp);
> void pc_dimm_memory_unplug(DeviceState *dev, MemoryHotplugState *hpms,
> diff --git a/numa.c b/numa.c
> index 1116c90af9..6a0eaebc01 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -36,6 +36,7 @@
> #include "hw/boards.h"
> #include "sysemu/hostmem.h"
> #include "hw/mem/pc-dimm.h"
> +#include "hw/mem/memory-device.h"
> #include "qemu/option.h"
> #include "qemu/config-file.h"
> #include "qemu/cutils.h"
> @@ -520,7 +521,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, Object *owner,
>
> static void numa_stat_memory_devices(NumaNodeMem node_mem[])
> {
> - MemoryDeviceInfoList *info_list = qmp_pc_dimm_device_list();
> + MemoryDeviceInfoList *info_list = qmp_memory_device_list();
> MemoryDeviceInfoList *info;
> PCDIMMDeviceInfo *pcdimm_info;
>
> diff --git a/qmp.c b/qmp.c
> index f72261667f..3de029946a 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -39,7 +39,7 @@
> #include "qapi/qobject-input-visitor.h"
> #include "hw/boards.h"
> #include "qom/object_interfaces.h"
> -#include "hw/mem/pc-dimm.h"
> +#include "hw/mem/memory-device.h"
> #include "hw/acpi/acpi_dev_interface.h"
>
> NameInfo *qmp_query_name(Error **errp)
> @@ -731,7 +731,7 @@ void qmp_object_del(const char *id, Error **errp)
>
> MemoryDeviceInfoList *qmp_query_memory_devices(Error **errp)
> {
> - return qmp_pc_dimm_device_list();
> + return qmp_memory_device_list();
> }
>
> ACPIOSTInfoList *qmp_query_acpi_ospm_status(Error **errp)
> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
> index 2d59d84091..53d3f32cb2 100644
> --- a/stubs/Makefile.objs
> +++ b/stubs/Makefile.objs
> @@ -34,7 +34,7 @@ stub-obj-y += uuid.o
> stub-obj-y += vm-stop.o
> stub-obj-y += vmstate.o
> stub-obj-$(CONFIG_WIN32) += fd-register.o
> -stub-obj-y += qmp_pc_dimm.o
> +stub-obj-y += qmp_memory_device.o
> stub-obj-y += target-monitor-defs.o
> stub-obj-y += target-get-monitor-def.o
> stub-obj-y += pc_madt_cpu_entry.o
> diff --git a/stubs/qmp_pc_dimm.c b/stubs/qmp_memory_device.c
> similarity index 61%
> rename from stubs/qmp_pc_dimm.c
> rename to stubs/qmp_memory_device.c
> index b6b2cca89e..85ff8f2d7e 100644
> --- a/stubs/qmp_pc_dimm.c
> +++ b/stubs/qmp_memory_device.c
> @@ -1,8 +1,8 @@
> #include "qemu/osdep.h"
> #include "qom/object.h"
> -#include "hw/mem/pc-dimm.h"
> +#include "hw/mem/memory-device.h"
>
> -MemoryDeviceInfoList *qmp_pc_dimm_device_list(void)
> +MemoryDeviceInfoList *qmp_memory_device_list(void)
> {
> return NULL;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface
2018-04-13 3:25 ` David Gibson
@ 2018-04-13 6:36 ` David Hildenbrand
0 siblings, 0 replies; 6+ messages in thread
From: David Hildenbrand @ 2018-04-13 6:36 UTC (permalink / raw)
To: David Gibson
Cc: qemu-devel, qemu-s390x, Michael S . Tsirkin, Igor Mammedov,
Marcel Apfelbaum, Paolo Bonzini, Richard Henderson,
Eduardo Habkost, Markus Armbruster, qemu-ppc, Pankaj Gupta
On 13.04.2018 05:25, David Gibson wrote:
> On Thu, Apr 12, 2018 at 04:36:33PM +0200, David Hildenbrand wrote:
>> On the qmp level, we already have the concept of memory devices:
>> "query-memory-devices"
>> Right now, we only support NVDIMM and PCDIMM.
>>
>> We want to map other devices later into the address space of the guest.
>> Such device could e.g. be virtio devices. These devices will have a
>> guest memory range assigned but won't be exposed via e.g. ACPI. We want
>> to make them look like memory device, but not glued to pc-dimm.
>>
>> Especially, it will not always be possible to have TYPE_PC_DIMM as a parent
>> class (e.g. virtio devices). Let's use an interface instead. As a first
>> part, convert handling of
>> - qmp_pc_dimm_device_list
>> - get_plugged_memory_size
>> to our new model. plug/unplug stuff etc. will follow later.
>>
>> A memory device will have to provide the following functions:
>> - get_addr(): Necessary, as the property "addr" can e.g. not be used for
>> virtio devices (already defined).
>
> Is the assumption here that a memory device has a fixed RAM address
> (GPA) from when it is realized? It seems to me plausible that you
> could have a memory device that has a specific size, but has a BAR of
> some sort that's programmed by the guest as part of the "plug"
> process.
Yes, the assumption is that the
a) address in physical memory
b) region size
Are defined at realize time. Which holds true for DIMM/NVDIMM and will
hold true for the two virtio device types we have in mind
(virtio-mem/virtio-pmem).
Both basically allow to find free address ranges.
>
>> - get_plugged_size(): The amount this device offers to the guest as of
>> now.
>> - get_region_size(): Because this can later on be bigger than the
>> plugged size.
>> - fill_device_info(): Fill MemoryDeviceInfo, e.g. for qmp.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> hw/i386/acpi-build.c | 3 +-
>> hw/mem/Makefile.objs | 1 +
>> hw/mem/memory-device.c | 119 +++++++++++++++++++++++++++
>> hw/mem/pc-dimm.c | 119 ++++++++++++++-------------
>> hw/ppc/spapr.c | 3 +-
>> hw/ppc/spapr_hcall.c | 1 +
>> include/hw/mem/memory-device.h | 44 ++++++++++
>> include/hw/mem/pc-dimm.h | 2 -
>> numa.c | 3 +-
>> qmp.c | 4 +-
>> stubs/Makefile.objs | 2 +-
>> stubs/{qmp_pc_dimm.c => qmp_memory_device.c} | 4 +-
>> 12 files changed, 239 insertions(+), 66 deletions(-)
>> create mode 100644 hw/mem/memory-device.c
>> create mode 100644 include/hw/mem/memory-device.h
>> rename stubs/{qmp_pc_dimm.c => qmp_memory_device.c} (61%)
>>
>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
>> index 3cf2a1679c..ca3645d57b 100644
>> --- a/hw/i386/acpi-build.c
>> +++ b/hw/i386/acpi-build.c
>> @@ -46,6 +46,7 @@
>> #include "hw/acpi/vmgenid.h"
>> #include "sysemu/tpm_backend.h"
>> #include "hw/timer/mc146818rtc_regs.h"
>> +#include "hw/mem/memory-device.h"
>> #include "sysemu/numa.h"
>>
>> /* Supported chipsets: */
>> @@ -2253,7 +2254,7 @@ build_tpm2(GArray *table_data, BIOSLinker *linker, GArray *tcpalog)
>> static void build_srat_hotpluggable_memory(GArray *table_data, uint64_t base,
>> uint64_t len, int default_node)
>> {
>> - MemoryDeviceInfoList *info_list = qmp_pc_dimm_device_list();
>> + MemoryDeviceInfoList *info_list = qmp_memory_device_list();
>> MemoryDeviceInfoList *info;
>> MemoryDeviceInfo *mi;
>> PCDIMMDeviceInfo *di;
>> diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
>> index f12f8b97a2..10be4df2a2 100644
>> --- a/hw/mem/Makefile.objs
>> +++ b/hw/mem/Makefile.objs
>> @@ -1,2 +1,3 @@
>> common-obj-$(CONFIG_MEM_HOTPLUG) += pc-dimm.o
>> +common-obj-$(CONFIG_MEM_HOTPLUG) += memory-device.o
>> common-obj-$(CONFIG_NVDIMM) += nvdimm.o
>> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
>> new file mode 100644
>> index 0000000000..0e0d6b539a
>> --- /dev/null
>> +++ b/hw/mem/memory-device.c
>> @@ -0,0 +1,119 @@
>> +/*
>> + * Memory Device Interface
>> + *
>> + * Copyright ProfitBricks GmbH 2012
>> + * Copyright (C) 2014 Red Hat Inc
>> + * Copyright (c) 2018 Red Hat Inc
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
>> + * See the COPYING file in the top-level directory.
>> + */
>> +
>> +#include "qemu/osdep.h"
>> +#include "hw/mem/memory-device.h"
>> +#include "hw/qdev.h"
>> +#include "qapi/error.h"
>> +#include "hw/boards.h"
>> +#include "qemu/range.h"
>> +
>> +static gint memory_device_addr_sort(gconstpointer a, gconstpointer b)
>> +{
>> + MemoryDeviceState *md_a = MEMORY_DEVICE(a);
>> + MemoryDeviceState *md_b = MEMORY_DEVICE(b);
>> + MemoryDeviceClass *mdc = MEMORY_DEVICE_GET_CLASS(a);
>
> AFAICT from the code below, the two devices don't necessarily have to
> have the same class, so I think you need to get the class pointers for
> each of them separately. (Or if they do have to be the same by
> design, I think there should at least be an assert).
Haven't considered that, my assumption was that any memory device class
would be sufficient to find/use the pointer (as that layout should not
change). But I might be wrong, so I'll lookup both pointers, thanks!
>
>> + const uint64_t addr_a = mdc->get_addr(md_a);
>> + const uint64_t addr_b = mdc->get_addr(md_b);
>> +
>> + if (addr_a > addr_b) {
>> + return 1;
>> + } else if (addr_a < addr_b) {
>> + return -1;
>> + }
>> + return 0;
>> +}
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-13 6:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 14:36 [Qemu-devel] [PATCH v2 0/3] pc-dimm: factor out MemoryDevice David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 1/3] pc-dimm: factor out MemoryDevice interface David Hildenbrand
2018-04-13 3:25 ` David Gibson
2018-04-13 6:36 ` David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 2/3] machine: make MemoryHotplugState accessible via the machine David Hildenbrand
2018-04-12 14:36 ` [Qemu-devel] [PATCH v2 3/3] pc-dimm: factor out address space logic into MemoryDevice code David Hildenbrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.