From: Jack Pham <jackp@codeaurora.org> To: Manu Gautam <mgautam@codeaurora.org> Cc: balbi@kernel.org, robh@kernel.org, andy.gross@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: Re: [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver Date: Fri, 13 Apr 2018 10:33:22 -0700 [thread overview] Message-ID: <20180413173322.GA30306@usblab-sd-06.qualcomm.com> (raw) In-Reply-To: <1523638285-5742-3-git-send-email-mgautam@codeaurora.org> Hi Manu, On Fri, Apr 13, 2018 at 10:21:23PM +0530, Manu Gautam wrote: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override vbus-override > and lane0-pwr-present signals going to hardware. These > must be updated in peripheral mode for DWC3 if vbus lines > are not connected to hardware block. Otherwise RX termination > in SS mode or DP pull-up is not applied by device controller. > - pwr_events_irq_stat support to check if USB2 PHY is in L2 state > before glue driver proceeds with suspend. > - Support for wakeup interrupts lines that are asserted whenever > there is any wakeup event on USB3 or USB2 bus. > - Support to replace pip3 clock going to DWC3 with utmi clock > for hardware configuration where SSPHY is not used with DWC3. > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> <snip> > +static int dwc3_qcom_register_extcon(struct dwc3_qcom *qcom) > +{ > + struct device *dev = qcom->dev; > + struct extcon_dev *host_edev; > + int ret; > + > + if (!of_property_read_bool(dev->of_node, "extcon")) > + return 0; > + > + qcom->edev = extcon_get_edev_by_phandle(dev, 0); Are the extcon phandles bound to the glue node? I don't see the description in the bindings doc in PATCH 1/3. And if so, would it be a duplicate of the child node's extcon binding? Then again, the alternative would be to grab it directly from the child (i.e. qcom->dwc3->dev.of_node) which I'm not sure is ok to do or not. Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Jack Pham <jackp@codeaurora.org> To: Manu Gautam <mgautam@codeaurora.org> Cc: balbi@kernel.org, robh@kernel.org, andy.gross@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: [v2,2/3] usb: dwc3: Add Qualcomm DWC3 glue driver Date: Fri, 13 Apr 2018 10:33:22 -0700 [thread overview] Message-ID: <20180413173322.GA30306@usblab-sd-06.qualcomm.com> (raw) Hi Manu, On Fri, Apr 13, 2018 at 10:21:23PM +0530, Manu Gautam wrote: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override vbus-override > and lane0-pwr-present signals going to hardware. These > must be updated in peripheral mode for DWC3 if vbus lines > are not connected to hardware block. Otherwise RX termination > in SS mode or DP pull-up is not applied by device controller. > - pwr_events_irq_stat support to check if USB2 PHY is in L2 state > before glue driver proceeds with suspend. > - Support for wakeup interrupts lines that are asserted whenever > there is any wakeup event on USB3 or USB2 bus. > - Support to replace pip3 clock going to DWC3 with utmi clock > for hardware configuration where SSPHY is not used with DWC3. > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> <snip> > +static int dwc3_qcom_register_extcon(struct dwc3_qcom *qcom) > +{ > + struct device *dev = qcom->dev; > + struct extcon_dev *host_edev; > + int ret; > + > + if (!of_property_read_bool(dev->of_node, "extcon")) > + return 0; > + > + qcom->edev = extcon_get_edev_by_phandle(dev, 0); Are the extcon phandles bound to the glue node? I don't see the description in the bindings doc in PATCH 1/3. And if so, would it be a duplicate of the child node's extcon binding? Then again, the alternative would be to grab it directly from the child (i.e. qcom->dwc3->dev.of_node) which I'm not sure is ok to do or not. Jack
next prev parent reply other threads:[~2018-04-13 17:33 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-13 16:51 [PATCH v2 0/3] usb: dwc3: support for Qualcomm DWC3 glue Manu Gautam 2018-04-13 16:51 ` [PATCH v2 1/3] dt-bindings: usb: Update documentation for Qualcomm DWC3 driver Manu Gautam 2018-04-13 16:51 ` [v2,1/3] " Manu Gautam 2018-04-16 20:38 ` [PATCH v2 1/3] " Rob Herring 2018-04-16 20:38 ` [v2,1/3] " Rob Herring 2018-04-17 3:39 ` [PATCH v2 1/3] " Manu Gautam 2018-04-17 3:39 ` [v2,1/3] " Manu Gautam 2018-04-13 16:51 ` [PATCH v2 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver Manu Gautam 2018-04-13 16:51 ` [v2,2/3] " Manu Gautam 2018-04-13 17:33 ` Jack Pham [this message] 2018-04-13 17:33 ` Jack Pham 2018-04-13 18:02 ` [PATCH v2 2/3] " Manu Gautam 2018-04-13 18:02 ` [v2,2/3] " Manu Gautam 2018-04-13 18:23 ` [PATCH v2 2/3] " Jack Pham 2018-04-13 18:23 ` [v2,2/3] " Jack Pham 2018-04-13 16:51 ` [PATCH v2 3/3] usb: dwc3: core: Suspend PHYs on runtime suspend in host mode Manu Gautam 2018-04-13 16:51 ` [v2,3/3] " Manu Gautam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180413173322.GA30306@usblab-sd-06.qualcomm.com \ --to=jackp@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=balbi@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mgautam@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.