All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michel Pollet <michel.pollet@bp.renesas.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	phil.edworthy@renesas.com, buserror+upstream@gmail.com,
	Magnus Damm <magnus.damm@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	Russell King <linux@armlinux.org.uk>,
	Sebastian Reichel <sre@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 3/8] dt-bindings: mfd: renesas,rzn1-sysctrl: document RZ/N1 sysctrl node
Date: Fri, 13 Apr 2018 13:05:49 -0500	[thread overview]
Message-ID: <20180413180549.yjzkl2yf7osz7myt@rob-hp-laptop> (raw)
In-Reply-To: <1523349015-37985-4-git-send-email-michel.pollet@bp.renesas.com>

On Tue, Apr 10, 2018 at 09:30:03AM +0100, Michel Pollet wrote:
> The Renesas RZ/N1 Family (Part #R9A06G0xx) has a multi-function
> system controller. This documents the node used to encapsulate
> it's sub drivers.
> 
> Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com>
> ---
>  .../bindings/mfd/renesas,rzn1-sysctrl.txt          | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt b/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt
> new file mode 100644
> index 0000000..9897f8f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt
> @@ -0,0 +1,23 @@
> +DT bindings for the Renesas RZ/N1 System Controller
> +
> +== System Controller Node ==
> +
> +The system controller node currently only hosts a single sub-node to handle
> +the rebooting of the CPU. Eventually it will host the clock driver, SMP
> +start handler, watchdog etc.

Please submit a complete binding for the h/w block.

Again, if the only reason you have sub nodes is to define compatible 
strings and in turn enumerate drivers, then you don't need the nodes in 
DT. DT is not the only way to instantiate drivers.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/8] dt-bindings: mfd: renesas,rzn1-sysctrl: document RZ/N1 sysctrl node
Date: Fri, 13 Apr 2018 13:05:49 -0500	[thread overview]
Message-ID: <20180413180549.yjzkl2yf7osz7myt@rob-hp-laptop> (raw)
In-Reply-To: <1523349015-37985-4-git-send-email-michel.pollet@bp.renesas.com>

On Tue, Apr 10, 2018 at 09:30:03AM +0100, Michel Pollet wrote:
> The Renesas RZ/N1 Family (Part #R9A06G0xx) has a multi-function
> system controller. This documents the node used to encapsulate
> it's sub drivers.
> 
> Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com>
> ---
>  .../bindings/mfd/renesas,rzn1-sysctrl.txt          | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt b/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt
> new file mode 100644
> index 0000000..9897f8f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/renesas,rzn1-sysctrl.txt
> @@ -0,0 +1,23 @@
> +DT bindings for the Renesas RZ/N1 System Controller
> +
> +== System Controller Node ==
> +
> +The system controller node currently only hosts a single sub-node to handle
> +the rebooting of the CPU. Eventually it will host the clock driver, SMP
> +start handler, watchdog etc.

Please submit a complete binding for the h/w block.

Again, if the only reason you have sub nodes is to define compatible 
strings and in turn enumerate drivers, then you don't need the nodes in 
DT. DT is not the only way to instantiate drivers.

Rob

  reply	other threads:[~2018-04-13 18:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10  8:30 [PATCH v4 0/8] arm: Base support for Renesas RZN1D-DB Board Michel Pollet
2018-04-10  8:30 ` Michel Pollet
2018-04-10  8:30 ` [PATCH v4 1/8] arm: shmobile: Add the RZ/N1 arch to the shmobile Kconfig Michel Pollet
2018-04-10  8:30   ` Michel Pollet
2018-04-12  8:00   ` Simon Horman
2018-04-12  8:00     ` Simon Horman
2018-04-10  8:30 ` [PATCH v4 2/8] arm: shmobile: Add the RZ/N1D (R9A06G032) " Michel Pollet
2018-04-10  8:30   ` Michel Pollet
2018-04-10  8:30 ` [PATCH v4 3/8] dt-bindings: mfd: renesas,rzn1-sysctrl: document RZ/N1 sysctrl node Michel Pollet
2018-04-10  8:30   ` [PATCH v4 3/8] dt-bindings: mfd: renesas, rzn1-sysctrl: " Michel Pollet
2018-04-13 18:05   ` Rob Herring [this message]
2018-04-13 18:05     ` [PATCH v4 3/8] dt-bindings: mfd: renesas,rzn1-sysctrl: " Rob Herring
2018-04-17  7:56     ` Michel Pollet
2018-04-17  7:56       ` Michel Pollet
2018-04-17  8:31       ` Geert Uytterhoeven
2018-04-17  8:31         ` Geert Uytterhoeven
2018-04-10  8:30 ` [PATCH v4 4/8] dt-bindings: reset: renesas,rzn1-reboot: document RZ/N1 reboot driver Michel Pollet
2018-04-10  8:30   ` [PATCH v4 4/8] dt-bindings: reset: renesas, rzn1-reboot: " Michel Pollet
2018-04-10  8:30 ` [PATCH v4 5/8] dt-bindings: arm: Document the RZN1D-DB board Michel Pollet
2018-04-10  8:30   ` Michel Pollet
2018-04-13 18:32   ` Rob Herring
2018-04-13 18:32     ` Rob Herring
2018-04-10  8:30 ` [PATCH v4 6/8] ARM: dts: Renesas RZ/N1 SoC base device tree file Michel Pollet
2018-04-10  8:30   ` Michel Pollet
2018-04-10  8:30 ` [PATCH v4 7/8] ARM: dts: Renesas RZN1D-DB Board base file Michel Pollet
2018-04-10  8:30   ` Michel Pollet
2018-04-10  8:30 ` [PATCH v4 8/8] reset: Renesas RZ/N1 reboot driver Michel Pollet
2018-04-10  8:30   ` Michel Pollet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180413180549.yjzkl2yf7osz7myt@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=buserror+upstream@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=horms@verge.net.au \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=michel.pollet@bp.renesas.com \
    --cc=phil.edworthy@renesas.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.