[PATCH 1/2] net: netsec: enable tx-irq during open callback

[PATCH 1/2] net: netsec: enable tx-irq during open callback

[jassisinghbrar]

From: Jassi Brar <jaswinder.singh@linaro.org>

Enable TX-irq as well during ndo_open() as we can not count upon
RX to arrive early enough to trigger the napi. This patch is critical
for installation over network.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 drivers/net/ethernet/socionext/netsec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index f4c0b02..f6fe70e 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
 	napi_enable(&priv->napi);
 	netif_start_queue(ndev);
 
-	/* Enable RX intr. */
-	netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
+	/* Enable TX+RX intr. */
+	netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
 
 	return 0;
 err3:
-- 
2.7.4

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

[David Miller]

From: jassisinghbrar@gmail.com
Date: Mon, 16 Apr 2018 12:52:16 +0530

> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
> Enable TX-irq as well during ndo_open() as we can not count upon
> RX to arrive early enough to trigger the napi. This patch is critical
> for installation over network.
> 
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

Applied.

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

[Jassi Brar]

Hi Dave,

On Mon, Apr 16, 2018 at 11:16 PM, David Miller <davem@davemloft.net> wrote:
> From: jassisinghbrar@gmail.com
> Date: Mon, 16 Apr 2018 12:52:16 +0530
>
>> From: Jassi Brar <jaswinder.singh@linaro.org>
>>
>> Enable TX-irq as well during ndo_open() as we can not count upon
>> RX to arrive early enough to trigger the napi. This patch is critical
>> for installation over network.
>>
>> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
>> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
>
> Applied.
>
Just to make sure, let me please mention that c009f413b79de52 and
9a00b697ce31e are very much needed in stable kernel. Without these we
couldn't install any OS over network.

Thanks.

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

[David Miller]

From: Jassi Brar <jassisinghbrar@gmail.com>
Date: Wed, 18 Apr 2018 18:27:59 +0530

> Just to make sure, let me please mention that c009f413b79de52 and
> 9a00b697ce31e are very much needed in stable kernel. Without these we
> couldn't install any OS over network.

Ok, both patches in this series queued up for -stable.

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

[Jassi Brar]

Hi David,

On Wed, Apr 18, 2018 at 11:00 PM, David Miller <davem@davemloft.net> wrote:
> From: Jassi Brar <jassisinghbrar@gmail.com>
> Date: Wed, 18 Apr 2018 18:27:59 +0530
>
>> Just to make sure, let me please mention that c009f413b79de52 and
>> 9a00b697ce31e are very much needed in stable kernel. Without these we
>> couldn't install any OS over network.
>
> Ok, both patches in this series queued up for -stable.
>
 I don't see the patches still. Could you please have a relook.

Thanks.

Re: [PATCH 1/2] net: netsec: enable tx-irq during open callback

[Jassi Brar]

Hi Dave,
   This patch (1/2) seems to have fallen through the cracks. The other
one (2/2), you already picked.
Thanks

On Mon, Apr 16, 2018 at 1:08 PM <jassisinghbrar@gmail.com> wrote:
>
> From: Jassi Brar <jaswinder.singh@linaro.org>
>
> Enable TX-irq as well during ndo_open() as we can not count upon
> RX to arrive early enough to trigger the napi. This patch is critical
> for installation over network.
>
> Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
> ---
>  drivers/net/ethernet/socionext/netsec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index f4c0b02..f6fe70e 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev)
>         napi_enable(&priv->napi);
>         netif_start_queue(ndev);
>
> -       /* Enable RX intr. */
> -       netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX);
> +       /* Enable TX+RX intr. */
> +       netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX);
>
>         return 0;
>  err3:
> --
> 2.7.4
>