* [Buildroot] [git commit] openvpn: don't test if the binary exists in the init script
@ 2018-04-16 5:34 Thomas Petazzoni
0 siblings, 0 replies; only message in thread
From: Thomas Petazzoni @ 2018-04-16 5:34 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=59520e54fe2849ace596b10354152a380d3c7507
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
The test doesn't make sense. It just exits without any error if the
binary doesn't exist, which is silly.
Replace the DAEMON variable, which was used only once, by the full path
of the binary file.
Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/openvpn/S60openvpn | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/package/openvpn/S60openvpn b/package/openvpn/S60openvpn
index de82a5095e..bc1ab01c1a 100755
--- a/package/openvpn/S60openvpn
+++ b/package/openvpn/S60openvpn
@@ -7,13 +7,11 @@
test $DEBIAN_SCRIPT_DEBUG && set -v -x
-DAEMON=/usr/sbin/openvpn
CONFIG_DIR=/etc/openvpn
-test -x $DAEMON || exit 0
test -d $CONFIG_DIR || exit 0
start_vpn () {
- $DAEMON --daemon --writepid /var/run/openvpn.$NAME.pid \
+ /usr/sbin/openvpn --daemon --writepid /var/run/openvpn.$NAME.pid \
--config $CONFIG_DIR/$NAME.conf --cd $CONFIG_DIR || printf " FAILED->"
printf " $NAME"
}
@@ -79,8 +77,6 @@ reload|force-reload)
printf "(restarted)"
else
kill -HUP `cat $PIDFILE` || true
-# start-stop-daemon --stop --signal HUP --quiet --oknodo \
-# --exec $DAEMON --pidfile $PIDFILE
printf " $NAME"
fi
done
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-16 5:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 5:34 [Buildroot] [git commit] openvpn: don't test if the binary exists in the init script Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.