All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-kernel@vger.kernel.org,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] mfd: axp20x: Correct AXP806 POK interrupt prefix
Date: Mon, 16 Apr 2018 10:36:55 +0100	[thread overview]
Message-ID: <20180416093655.d2ni7iypccl72xxu@dell> (raw)
In-Reply-To: <20180329043115.7132-4-wens@csie.org>

On Thu, 29 Mar 2018, Chen-Yu Tsai wrote:

> When AXP806 support was added, POK was incorrectly expanded to PWROK.
> However, the datasheet lists them as POK[LSNP], which is the same as
> on the AXP288. Furthermore, the registers associated with POK functions
> are the same as the PEK on the other AXP PMICs. This suggests that
> "POK" means "Power On Key", much like "PEK" means "Power Enable Key",
> instead of "Power OK".
> 
> This patch changes the "PWROK" prefix to "POK" for these interrupts.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/mfd/axp20x.c       | 8 ++++----
>  include/linux/mfd/axp20x.h | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mfd: axp20x: Correct AXP806 POK interrupt prefix
Date: Mon, 16 Apr 2018 10:36:55 +0100	[thread overview]
Message-ID: <20180416093655.d2ni7iypccl72xxu@dell> (raw)
In-Reply-To: <20180329043115.7132-4-wens@csie.org>

On Thu, 29 Mar 2018, Chen-Yu Tsai wrote:

> When AXP806 support was added, POK was incorrectly expanded to PWROK.
> However, the datasheet lists them as POK[LSNP], which is the same as
> on the AXP288. Furthermore, the registers associated with POK functions
> are the same as the PEK on the other AXP PMICs. This suggests that
> "POK" means "Power On Key", much like "PEK" means "Power Enable Key",
> instead of "Power OK".
> 
> This patch changes the "PWROK" prefix to "POK" for these interrupts.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/mfd/axp20x.c       | 8 ++++----
>  include/linux/mfd/axp20x.h | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

-- 
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2018-04-16  9:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29  4:31 [PATCH 0/3] mfd: axp20x: driver cleanup Chen-Yu Tsai
2018-03-29  4:31 ` Chen-Yu Tsai
2018-03-29  4:31 ` [PATCH 1/3] mfd: axp20x: Const-ify struct mfd_cell and struct resource Chen-Yu Tsai
2018-03-29  4:31   ` Chen-Yu Tsai
2018-04-16  9:36   ` Lee Jones
2018-04-16  9:36     ` Lee Jones
2018-03-29  4:31 ` [PATCH 2/3] mfd: axp20x: Use DEFINE_RES_IRQ to declare resources for mfd_cells Chen-Yu Tsai
2018-03-29  4:31   ` Chen-Yu Tsai
2018-04-16  9:36   ` Lee Jones
2018-04-16  9:36     ` Lee Jones
2018-03-29  4:31 ` [PATCH 3/3] mfd: axp20x: Correct AXP806 POK interrupt prefix Chen-Yu Tsai
2018-03-29  4:31   ` Chen-Yu Tsai
2018-04-16  9:36   ` Lee Jones [this message]
2018-04-16  9:36     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416093655.d2ni7iypccl72xxu@dell \
    --to=lee.jones@linaro.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.