* [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
@ 2018-04-16 9:37 Michael Tokarev
2018-04-16 10:04 ` Philippe Mathieu-Daudé
2018-04-16 17:40 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Michael Tokarev @ 2018-04-16 9:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Tokarev, Bruce Rogers
Fixes 722cd7496474cebb2218f21e038592fad8603365
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 727ef118f3..d71dd5bea4 100644
--- a/Makefile
+++ b/Makefile
@@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
$(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
done
endif
-ifeq ($(CONFIG_GTK),m)
+ifdef CONFIG_GTK
$(MAKE) -C po $@
endif
$(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
2018-04-16 9:37 [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
@ 2018-04-16 10:04 ` Philippe Mathieu-Daudé
2018-04-16 17:40 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-04-16 10:04 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: Bruce Rogers
On 04/16/2018 06:37 AM, Michael Tokarev wrote:
> Fixes 722cd7496474cebb2218f21e038592fad8603365
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 727ef118f3..d71dd5bea4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
> done
> endif
> -ifeq ($(CONFIG_GTK),m)
> +ifdef CONFIG_GTK
> $(MAKE) -C po $@
> endif
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m
2018-04-16 9:37 [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
2018-04-16 10:04 ` Philippe Mathieu-Daudé
@ 2018-04-16 17:40 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-04-16 17:40 UTC (permalink / raw)
To: Michael Tokarev; +Cc: QEMU Developers, Bruce Rogers
On 16 April 2018 at 10:37, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Fixes 722cd7496474cebb2218f21e038592fad8603365
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 727ef118f3..d71dd5bea4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -856,7 +856,7 @@ ifneq ($(BLOBS),)
> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x "$(DESTDIR)$(qemu_datadir)"; \
> done
> endif
> -ifeq ($(CONFIG_GTK),m)
> +ifdef CONFIG_GTK
> $(MAKE) -C po $@
> endif
> $(INSTALL_DIR) "$(DESTDIR)$(qemu_datadir)/keymaps"
> --
> 2.11.0
Applied, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-16 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 9:37 [Qemu-devel] [PATCH v2 for-2.12] Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m Michael Tokarev
2018-04-16 10:04 ` Philippe Mathieu-Daudé
2018-04-16 17:40 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.