From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stefan Agner <stefan@agner.ch>
Cc: s.hauer@pengutronix.de, baruch@tkos.co.il,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: serial: imx: half-duplex RS485 operation with RTS active low
Date: Mon, 16 Apr 2018 20:02:56 +0200 [thread overview]
Message-ID: <20180416180256.s6r7rrcnpevndmrf@pengutronix.de> (raw)
In-Reply-To: <15ca978834ac705c550d9d3339ae1602@agner.ch>
Hallo Stefan,
On Mon, Apr 16, 2018 at 06:12:41PM +0200, Stefan Agner wrote:
> On 16.04.2018 15:42, Uwe Kleine-König wrote:
> > Adding a respective check in the driver would be nice though.
>
> Hm, yes agreed. Where would that check go? In probe? Then I guess it
> only would warn when using device tree properties...?
look at the code between the calls to uart_get_rs485_mode() and
imx_uart_rs485_config(). Something like that would be needed and
imx_uart_rs485_config must adapt the flags accordingly.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: serial: imx: half-duplex RS485 operation with RTS active low
Date: Mon, 16 Apr 2018 20:02:56 +0200 [thread overview]
Message-ID: <20180416180256.s6r7rrcnpevndmrf@pengutronix.de> (raw)
In-Reply-To: <15ca978834ac705c550d9d3339ae1602@agner.ch>
Hallo Stefan,
On Mon, Apr 16, 2018 at 06:12:41PM +0200, Stefan Agner wrote:
> On 16.04.2018 15:42, Uwe Kleine-K?nig wrote:
> > Adding a respective check in the driver would be nice though.
>
> Hm, yes agreed. Where would that check go? In probe? Then I guess it
> only would warn when using device tree properties...?
look at the code between the calls to uart_get_rs485_mode() and
imx_uart_rs485_config(). Something like that would be needed and
imx_uart_rs485_config must adapt the flags accordingly.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-04-16 18:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 9:14 serial: imx: half-duplex RS485 operation with RTS active low Stefan Agner
2018-04-16 9:14 ` Stefan Agner
2018-04-16 9:22 ` Uwe Kleine-König
2018-04-16 9:22 ` Uwe Kleine-König
2018-04-16 10:29 ` Stefan Agner
2018-04-16 10:29 ` Stefan Agner
2018-04-16 13:01 ` Stefan Agner
2018-04-16 13:01 ` Stefan Agner
2018-04-16 13:42 ` Uwe Kleine-König
2018-04-16 13:42 ` Uwe Kleine-König
2018-04-16 16:12 ` Stefan Agner
2018-04-16 16:12 ` Stefan Agner
2018-04-16 18:02 ` Uwe Kleine-König [this message]
2018-04-16 18:02 ` Uwe Kleine-König
2018-04-16 9:54 ` Einar Vading
2018-04-16 9:54 ` Einar Vading
2018-04-16 9:57 ` Einar Vading
2018-04-16 9:57 ` Einar Vading
2018-04-16 10:35 ` Stefan Agner
2018-04-16 10:35 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416180256.s6r7rrcnpevndmrf@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.