* [PATCH] samples/bpf: correct comment in sock_example.c
@ 2018-04-17 2:25 Wang Sheng-Hui
2018-04-17 23:39 ` Alexei Starovoitov
2018-04-18 12:47 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: Wang Sheng-Hui @ 2018-04-17 2:25 UTC (permalink / raw)
To: ast, daniel, netdev
The program run against loopback interace "lo", not "eth0".
Correct the comment.
Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
---
samples/bpf/sock_example.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/samples/bpf/sock_example.c b/samples/bpf/sock_example.c
index 6fc6e193ef1b..33a637507c00 100644
--- a/samples/bpf/sock_example.c
+++ b/samples/bpf/sock_example.c
@@ -9,10 +9,10 @@
* if (value)
* (*(u64*)value) += 1;
*
- * - attaches this program to eth0 raw socket
+ * - attaches this program to loopback interface "lo" raw socket
*
* - every second user space reads map[tcp], map[udp], map[icmp] to see
- * how many packets of given protocol were seen on eth0
+ * how many packets of given protocol were seen on "lo"
*/
#include <stdio.h>
#include <unistd.h>
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] samples/bpf: correct comment in sock_example.c
2018-04-17 2:25 [PATCH] samples/bpf: correct comment in sock_example.c Wang Sheng-Hui
@ 2018-04-17 23:39 ` Alexei Starovoitov
2018-04-18 12:47 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2018-04-17 23:39 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: ast, daniel, netdev
On Tue, Apr 17, 2018 at 10:25:20AM +0800, Wang Sheng-Hui wrote:
> The program run against loopback interace "lo", not "eth0".
> Correct the comment.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
for future patches please use the following format for the subject:
[PATCH bpf-next] samples/bpf: ...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] samples/bpf: correct comment in sock_example.c
2018-04-17 2:25 [PATCH] samples/bpf: correct comment in sock_example.c Wang Sheng-Hui
2018-04-17 23:39 ` Alexei Starovoitov
@ 2018-04-18 12:47 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2018-04-18 12:47 UTC (permalink / raw)
To: Wang Sheng-Hui, ast, netdev
On 04/17/2018 04:25 AM, Wang Sheng-Hui wrote:
> The program run against loopback interace "lo", not "eth0".
> Correct the comment.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
Applied to bpf-next, thanks Wang!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-18 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 2:25 [PATCH] samples/bpf: correct comment in sock_example.c Wang Sheng-Hui
2018-04-17 23:39 ` Alexei Starovoitov
2018-04-18 12:47 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.