[PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One

[PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One

[Chen-Yu Tsai]

In commit f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3
boards"), the hunk that enabled HDMI for the Orange Pi One did not add a

    status = "okay";

line for the HDMI node, inadvertenly using the one for the EMAC. This
resulted in the EMAC now being disabled. Whether this was due to a
rebase error or some other mishap is unknown.

This patch re-enables the EMAC by adding the status line to its node.

Fixes: f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3 boards")
Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
---

First fix for 4.17.

---
 arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
index 3328fe583c9b..232f124ce62c 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
@@ -117,6 +117,7 @@
 	phy-handle = <&int_mii_phy>;
 	phy-mode = "mii";
 	allwinner,leds-active-low;
+	status = "okay";
 };
 
 &hdmi {
-- 
2.17.0

[PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One

[Chen-Yu Tsai]

In commit f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3
boards"), the hunk that enabled HDMI for the Orange Pi One did not add a

    status = "okay";

line for the HDMI node, inadvertenly using the one for the EMAC. This
resulted in the EMAC now being disabled. Whether this was due to a
rebase error or some other mishap is unknown.

This patch re-enables the EMAC by adding the status line to its node.

Fixes: f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3 boards")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---

First fix for 4.17.

---
 arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
index 3328fe583c9b..232f124ce62c 100644
--- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts
@@ -117,6 +117,7 @@
 	phy-handle = <&int_mii_phy>;
 	phy-mode = "mii";
 	allwinner,leds-active-low;
+	status = "okay";
 };
 
 &hdmi {
-- 
2.17.0

Re: [PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

On Tue, Apr 17, 2018 at 12:17:14PM +0800, Chen-Yu Tsai wrote:
> In commit f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3
> boards"), the hunk that enabled HDMI for the Orange Pi One did not add a
> 
>     status = "okay";
> 
> line for the HDMI node, inadvertenly using the one for the EMAC. This
> resulted in the EMAC now being disabled. Whether this was due to a
> rebase error or some other mishap is unknown.
> 
> This patch re-enables the EMAC by adding the status line to its node.
> 
> Fixes: f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3 boards")
> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH] ARM: dts: sun8i: h3: Re-enable EMAC on Orange Pi One

[Maxime Ripard]

On Tue, Apr 17, 2018 at 12:17:14PM +0800, Chen-Yu Tsai wrote:
> In commit f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3
> boards"), the hunk that enabled HDMI for the Orange Pi One did not add a
> 
>     status = "okay";
> 
> line for the HDMI node, inadvertenly using the one for the EMAC. This
> resulted in the EMAC now being disabled. Whether this was due to a
> rebase error or some other mishap is unknown.
> 
> This patch re-enables the EMAC by adding the status line to its node.
> 
> Fixes: f0842bc5637c ("ARM: dts: sun8i: h3: Enable HDMI output on H3 boards")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180417/5cc91314/attachment.sig>