From: Christoffer Dall <christoffer.dall@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm/arm64: VGIC: Kick new VCPU on interrupt migration
Date: Tue, 17 Apr 2018 13:32:20 +0200 [thread overview]
Message-ID: <20180417113220.GA66827@C02W217FHV2R.local> (raw)
In-Reply-To: <20180417102349.3039-1-andre.przywara@arm.com>
On Tue, Apr 17, 2018 at 11:23:49AM +0100, Andre Przywara wrote:
> When vgic_prune_ap_list() finds an interrupt that needs to be migrated
> to a new VCPU, we should notify this VCPU of the pending interrupt,
> since it requires immediate action.
> Kick this VCPU once we have added the new IRQ to the list, but only
> after dropping the locks.
>
> Reported-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Christoffer Dall <christoffer.dall@arm.com>
> ---
> virt/kvm/arm/vgic/vgic.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/virt/kvm/arm/vgic/vgic.c b/virt/kvm/arm/vgic/vgic.c
> index e74baec76361..4b6d72939c42 100644
> --- a/virt/kvm/arm/vgic/vgic.c
> +++ b/virt/kvm/arm/vgic/vgic.c
> @@ -594,6 +594,7 @@ static void vgic_prune_ap_list(struct kvm_vcpu *vcpu)
>
> list_for_each_entry_safe(irq, tmp, &vgic_cpu->ap_list_head, ap_list) {
> struct kvm_vcpu *target_vcpu, *vcpuA, *vcpuB;
> + bool target_vcpu_needs_kick = false;
>
> spin_lock(&irq->irq_lock);
>
> @@ -664,11 +665,18 @@ static void vgic_prune_ap_list(struct kvm_vcpu *vcpu)
> list_del(&irq->ap_list);
> irq->vcpu = target_vcpu;
> list_add_tail(&irq->ap_list, &new_cpu->ap_list_head);
> + target_vcpu_needs_kick = true;
> }
>
> spin_unlock(&irq->irq_lock);
> spin_unlock(&vcpuB->arch.vgic_cpu.ap_list_lock);
> spin_unlock_irqrestore(&vcpuA->arch.vgic_cpu.ap_list_lock, flags);
> +
> + if (target_vcpu_needs_kick) {
> + kvm_make_request(KVM_REQ_IRQ_PENDING, target_vcpu);
> + kvm_vcpu_kick(target_vcpu);
> + }
> +
> goto retry;
> }
>
> --
> 2.14.1
>
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@arm.com (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: arm/arm64: VGIC: Kick new VCPU on interrupt migration
Date: Tue, 17 Apr 2018 13:32:20 +0200 [thread overview]
Message-ID: <20180417113220.GA66827@C02W217FHV2R.local> (raw)
In-Reply-To: <20180417102349.3039-1-andre.przywara@arm.com>
On Tue, Apr 17, 2018 at 11:23:49AM +0100, Andre Przywara wrote:
> When vgic_prune_ap_list() finds an interrupt that needs to be migrated
> to a new VCPU, we should notify this VCPU of the pending interrupt,
> since it requires immediate action.
> Kick this VCPU once we have added the new IRQ to the list, but only
> after dropping the locks.
>
> Reported-by: Stefano Stabellini <sstabellini@kernel.org>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Christoffer Dall <christoffer.dall@arm.com>
> ---
> virt/kvm/arm/vgic/vgic.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/virt/kvm/arm/vgic/vgic.c b/virt/kvm/arm/vgic/vgic.c
> index e74baec76361..4b6d72939c42 100644
> --- a/virt/kvm/arm/vgic/vgic.c
> +++ b/virt/kvm/arm/vgic/vgic.c
> @@ -594,6 +594,7 @@ static void vgic_prune_ap_list(struct kvm_vcpu *vcpu)
>
> list_for_each_entry_safe(irq, tmp, &vgic_cpu->ap_list_head, ap_list) {
> struct kvm_vcpu *target_vcpu, *vcpuA, *vcpuB;
> + bool target_vcpu_needs_kick = false;
>
> spin_lock(&irq->irq_lock);
>
> @@ -664,11 +665,18 @@ static void vgic_prune_ap_list(struct kvm_vcpu *vcpu)
> list_del(&irq->ap_list);
> irq->vcpu = target_vcpu;
> list_add_tail(&irq->ap_list, &new_cpu->ap_list_head);
> + target_vcpu_needs_kick = true;
> }
>
> spin_unlock(&irq->irq_lock);
> spin_unlock(&vcpuB->arch.vgic_cpu.ap_list_lock);
> spin_unlock_irqrestore(&vcpuA->arch.vgic_cpu.ap_list_lock, flags);
> +
> + if (target_vcpu_needs_kick) {
> + kvm_make_request(KVM_REQ_IRQ_PENDING, target_vcpu);
> + kvm_vcpu_kick(target_vcpu);
> + }
> +
> goto retry;
> }
>
> --
> 2.14.1
>
next prev parent reply other threads:[~2018-04-17 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 10:23 [PATCH] KVM: arm/arm64: VGIC: Kick new VCPU on interrupt migration Andre Przywara
2018-04-17 10:23 ` Andre Przywara
2018-04-17 11:32 ` Christoffer Dall [this message]
2018-04-17 11:32 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417113220.GA66827@C02W217FHV2R.local \
--to=christoffer.dall@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.