All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
@ 2018-04-17 13:38 Souptick Joarder
  2018-04-23 10:49 ` Gerd Hoffmann
  2018-04-23 10:49   ` Gerd Hoffmann
  0 siblings, 2 replies; 13+ messages in thread
From: Souptick Joarder @ 2018-04-17 13:38 UTC (permalink / raw)
  To: airlied, kraxel, airlied; +Cc: virtualization, dri-devel, linux-kernel, willy

Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to
vm_fault_t")

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/gpu/drm/qxl/qxl_ttm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
index 59cd74c..0b482b1 100644
--- a/drivers/gpu/drm/qxl/qxl_ttm.c
+++ b/drivers/gpu/drm/qxl/qxl_ttm.c
@@ -105,16 +105,16 @@ static void qxl_ttm_global_fini(struct qxl_device *qdev)
 static struct vm_operations_struct qxl_ttm_vm_ops;
 static const struct vm_operations_struct *ttm_vm_ops;
 
-static int qxl_ttm_fault(struct vm_fault *vmf)
+static vm_fault_t qxl_ttm_fault(struct vm_fault *vmf)
 {
 	struct ttm_buffer_object *bo;
-	int r;
+	vm_fault_t ret;
 
 	bo = (struct ttm_buffer_object *)vmf->vma->vm_private_data;
 	if (bo == NULL)
 		return VM_FAULT_NOPAGE;
-	r = ttm_vm_ops->fault(vmf);
-	return r;
+	ret = ttm_vm_ops->fault(vmf);
+	return ret;
 }
 
 int qxl_mmap(struct file *filp, struct vm_area_struct *vma)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-04-17 13:38 [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t Souptick Joarder
@ 2018-04-23 10:49   ` Gerd Hoffmann
  2018-04-23 10:49   ` Gerd Hoffmann
  1 sibling, 0 replies; 13+ messages in thread
From: Gerd Hoffmann @ 2018-04-23 10:49 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: airlied, airlied, virtualization, dri-devel, linux-kernel, willy

On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")

Hmm, that commit isn't yet in drm-misc-next.
Will drm-misc-next merge with 4.17-rcX soon?

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-04-17 13:38 [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t Souptick Joarder
@ 2018-04-23 10:49 ` Gerd Hoffmann
  2018-04-23 10:49   ` Gerd Hoffmann
  1 sibling, 0 replies; 13+ messages in thread
From: Gerd Hoffmann @ 2018-04-23 10:49 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: airlied, linux-kernel, willy, virtualization, dri-devel, airlied

On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")

Hmm, that commit isn't yet in drm-misc-next.
Will drm-misc-next merge with 4.17-rcX soon?

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
@ 2018-04-23 10:49   ` Gerd Hoffmann
  0 siblings, 0 replies; 13+ messages in thread
From: Gerd Hoffmann @ 2018-04-23 10:49 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: airlied, linux-kernel, willy, virtualization, dri-devel, airlied

On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")

Hmm, that commit isn't yet in drm-misc-next.
Will drm-misc-next merge with 4.17-rcX soon?

cheers,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-04-23 10:49   ` Gerd Hoffmann
@ 2018-04-24 12:11     ` Daniel Vetter
  -1 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2018-04-24 12:11 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: Souptick Joarder, airlied, linux-kernel, willy, virtualization,
	dri-devel, airlied, Maarten Lankhorst, Gustavo Padovan,
	Sean Paul

On Mon, Apr 23, 2018 at 12:49:24PM +0200, Gerd Hoffmann wrote:
> On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> > Use new return type vm_fault_t for fault handler. For
> > now, this is just documenting that the function returns
> > a VM_FAULT value rather than an errno. Once all instances
> > are converted, vm_fault_t will become a distinct type.
> > 
> > Reference id -> 1c8f422059ae ("mm: change return type to
> > vm_fault_t")
> 
> Hmm, that commit isn't yet in drm-misc-next.
> Will drm-misc-next merge with 4.17-rcX soon?

For backmerge requests you need to cc/ping the drm-misc maintainers.
Adding them. I think the hold-up also was that Dave was on vacations
still.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-04-23 10:49   ` Gerd Hoffmann
  (?)
@ 2018-04-24 12:11   ` Daniel Vetter
  -1 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2018-04-24 12:11 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: willy, airlied, Gustavo Padovan, Maarten Lankhorst, linux-kernel,
	dri-devel, virtualization, Sean Paul, Souptick Joarder, airlied

On Mon, Apr 23, 2018 at 12:49:24PM +0200, Gerd Hoffmann wrote:
> On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> > Use new return type vm_fault_t for fault handler. For
> > now, this is just documenting that the function returns
> > a VM_FAULT value rather than an errno. Once all instances
> > are converted, vm_fault_t will become a distinct type.
> > 
> > Reference id -> 1c8f422059ae ("mm: change return type to
> > vm_fault_t")
> 
> Hmm, that commit isn't yet in drm-misc-next.
> Will drm-misc-next merge with 4.17-rcX soon?

For backmerge requests you need to cc/ping the drm-misc maintainers.
Adding them. I think the hold-up also was that Dave was on vacations
still.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
@ 2018-04-24 12:11     ` Daniel Vetter
  0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2018-04-24 12:11 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: willy, airlied, linux-kernel, dri-devel, virtualization,
	Souptick Joarder, airlied

On Mon, Apr 23, 2018 at 12:49:24PM +0200, Gerd Hoffmann wrote:
> On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> > Use new return type vm_fault_t for fault handler. For
> > now, this is just documenting that the function returns
> > a VM_FAULT value rather than an errno. Once all instances
> > are converted, vm_fault_t will become a distinct type.
> > 
> > Reference id -> 1c8f422059ae ("mm: change return type to
> > vm_fault_t")
> 
> Hmm, that commit isn't yet in drm-misc-next.
> Will drm-misc-next merge with 4.17-rcX soon?

For backmerge requests you need to cc/ping the drm-misc maintainers.
Adding them. I think the hold-up also was that Dave was on vacations
still.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-04-24 12:11     ` Daniel Vetter
  (?)
@ 2018-04-24 12:35     ` Gerd Hoffmann
  2018-05-10 15:21       ` Souptick Joarder
  -1 siblings, 1 reply; 13+ messages in thread
From: Gerd Hoffmann @ 2018-04-24 12:35 UTC (permalink / raw)
  To: Souptick Joarder, airlied, linux-kernel, willy, virtualization,
	dri-devel, airlied, Maarten Lankhorst, Gustavo Padovan,
	Sean Paul

On Tue, Apr 24, 2018 at 02:11:51PM +0200, Daniel Vetter wrote:
> On Mon, Apr 23, 2018 at 12:49:24PM +0200, Gerd Hoffmann wrote:
> > On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
> > > Use new return type vm_fault_t for fault handler. For
> > > now, this is just documenting that the function returns
> > > a VM_FAULT value rather than an errno. Once all instances
> > > are converted, vm_fault_t will become a distinct type.
> > > 
> > > Reference id -> 1c8f422059ae ("mm: change return type to
> > > vm_fault_t")
> > 
> > Hmm, that commit isn't yet in drm-misc-next.
> > Will drm-misc-next merge with 4.17-rcX soon?
> 
> For backmerge requests you need to cc/ping the drm-misc maintainers.
> Adding them. I think the hold-up also was that Dave was on vacations
> still.

Ah, ok.

So my expectation that a backmerge happens anyway after -rc1/2 is in
line with reality, it is just to be delayed this time.  I'll stay
tuned ;)

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-04-24 12:35     ` Gerd Hoffmann
@ 2018-05-10 15:21       ` Souptick Joarder
  2018-05-14  9:02           ` Gerd Hoffmann
  2018-05-14  9:02         ` Gerd Hoffmann
  0 siblings, 2 replies; 13+ messages in thread
From: Souptick Joarder @ 2018-05-10 15:21 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: airlied, linux-kernel, Matthew Wilcox, virtualization, dri-devel,
	airlied, Maarten Lankhorst, Gustavo Padovan, Sean Paul

Hi Gerd /Daniel,

On Tue, Apr 24, 2018 at 6:05 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On Tue, Apr 24, 2018 at 02:11:51PM +0200, Daniel Vetter wrote:
>> On Mon, Apr 23, 2018 at 12:49:24PM +0200, Gerd Hoffmann wrote:
>> > On Tue, Apr 17, 2018 at 07:08:44PM +0530, Souptick Joarder wrote:
>> > > Use new return type vm_fault_t for fault handler. For
>> > > now, this is just documenting that the function returns
>> > > a VM_FAULT value rather than an errno. Once all instances
>> > > are converted, vm_fault_t will become a distinct type.
>> > >
>> > > Reference id -> 1c8f422059ae ("mm: change return type to
>> > > vm_fault_t")
>> >
>> > Hmm, that commit isn't yet in drm-misc-next.
>> > Will drm-misc-next merge with 4.17-rcX soon?
>>
>> For backmerge requests you need to cc/ping the drm-misc maintainers.
>> Adding them. I think the hold-up also was that Dave was on vacations
>> still.
>
> Ah, ok.
>
> So my expectation that a backmerge happens anyway after -rc1/2 is in
> line with reality, it is just to be delayed this time.  I'll stay
> tuned ;)

Is this patch already merged in drm-misc-next tree ?

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-05-10 15:21       ` Souptick Joarder
@ 2018-05-14  9:02           ` Gerd Hoffmann
  2018-05-14  9:02         ` Gerd Hoffmann
  1 sibling, 0 replies; 13+ messages in thread
From: Gerd Hoffmann @ 2018-05-14  9:02 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: airlied, linux-kernel, Matthew Wilcox, virtualization, dri-devel,
	airlied, Maarten Lankhorst, Gustavo Padovan, Sean Paul

  Hi,

> > So my expectation that a backmerge happens anyway after -rc1/2 is in
> > line with reality, it is just to be delayed this time.  I'll stay
> > tuned ;)
> 
> Is this patch already merged in drm-misc-next tree ?

Pushed now.

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-05-10 15:21       ` Souptick Joarder
  2018-05-14  9:02           ` Gerd Hoffmann
@ 2018-05-14  9:02         ` Gerd Hoffmann
  1 sibling, 0 replies; 13+ messages in thread
From: Gerd Hoffmann @ 2018-05-14  9:02 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: airlied, Gustavo Padovan, Maarten Lankhorst, linux-kernel,
	dri-devel, virtualization, Sean Paul, Matthew Wilcox, airlied

  Hi,

> > So my expectation that a backmerge happens anyway after -rc1/2 is in
> > line with reality, it is just to be delayed this time.  I'll stay
> > tuned ;)
> 
> Is this patch already merged in drm-misc-next tree ?

Pushed now.

cheers,
  Gerd

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
@ 2018-05-14  9:02           ` Gerd Hoffmann
  0 siblings, 0 replies; 13+ messages in thread
From: Gerd Hoffmann @ 2018-05-14  9:02 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: airlied, linux-kernel, dri-devel, virtualization, Matthew Wilcox,
	airlied

  Hi,

> > So my expectation that a backmerge happens anyway after -rc1/2 is in
> > line with reality, it is just to be delayed this time.  I'll stay
> > tuned ;)
> 
> Is this patch already merged in drm-misc-next tree ?

Pushed now.

cheers,
  Gerd

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
  2018-05-14  9:02           ` Gerd Hoffmann
  (?)
@ 2018-05-14  9:15           ` Souptick Joarder
  -1 siblings, 0 replies; 13+ messages in thread
From: Souptick Joarder @ 2018-05-14  9:15 UTC (permalink / raw)
  To: Gerd Hoffmann
  Cc: airlied, linux-kernel, Matthew Wilcox, virtualization, dri-devel,
	airlied, Maarten Lankhorst, Gustavo Padovan, Sean Paul

On Mon, May 14, 2018 at 2:32 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
>> > So my expectation that a backmerge happens anyway after -rc1/2 is in
>> > line with reality, it is just to be delayed this time.  I'll stay
>> > tuned ;)
>>
>> Is this patch already merged in drm-misc-next tree ?
>
> Pushed now.
>

Thanks Gerd :)

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2018-05-14  9:15 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 13:38 [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t Souptick Joarder
2018-04-23 10:49 ` Gerd Hoffmann
2018-04-23 10:49 ` Gerd Hoffmann
2018-04-23 10:49   ` Gerd Hoffmann
2018-04-24 12:11   ` Daniel Vetter
2018-04-24 12:11   ` Daniel Vetter
2018-04-24 12:11     ` Daniel Vetter
2018-04-24 12:35     ` Gerd Hoffmann
2018-05-10 15:21       ` Souptick Joarder
2018-05-14  9:02         ` Gerd Hoffmann
2018-05-14  9:02           ` Gerd Hoffmann
2018-05-14  9:15           ` Souptick Joarder
2018-05-14  9:02         ` Gerd Hoffmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.