All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v1] roms/ipxe: use configured compiler for ipxe
@ 2018-04-18  8:13 Olaf Hering
  2018-04-18  8:32 ` Olaf Hering
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2018-04-18  8:13 UTC (permalink / raw)
  To: qemu-trivial
  Cc: Olaf Hering, BALATON Zoltan, David Gibson, open list:All patches CC here

configure allows to run a dedicated compiler binary, which is stored in
CC and HOST_CC variables, and overrides the default 'cc' command.

This command however is not used when building ipxe from source.
"make -C roms pxerom" invokes the buildsystem of ipxe.git, which has the
command "gcc" hardcoded. That binary may not be suitable to build ipxe.
Reuse the same compiler command that is used to build qemu by specifying
CC and HOST_CC as make commandline option to override the built-in
defaults of ipxe.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 roms/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/roms/Makefile b/roms/Makefile
index 02b69fbac8..982bf105a3 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -127,11 +127,13 @@ efi-rom-%: build-pxe-roms build-efi-roms
 
 build-pxe-roms:
 	$(MAKE) -C ipxe/src CONFIG=qemu \
+		CC=$(CC) HOST_CC=$(HOST_CC) \
 		CROSS_COMPILE=$(x86_64_cross_prefix) \
 		$(patsubst %,bin/%.rom,$(pxerom_targets))
 
 build-efi-roms: build-pxe-roms
 	$(MAKE) -C ipxe/src CONFIG=qemu \
+		CC=$(CC) HOST_CC=$(HOST_CC) \
 		CROSS_COMPILE=$(x86_64_cross_prefix) \
 		$(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \
 		$(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets))

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH v1] roms/ipxe: use configured compiler for ipxe
  2018-04-18  8:13 [Qemu-devel] [PATCH v1] roms/ipxe: use configured compiler for ipxe Olaf Hering
@ 2018-04-18  8:32 ` Olaf Hering
  0 siblings, 0 replies; 2+ messages in thread
From: Olaf Hering @ 2018-04-18  8:32 UTC (permalink / raw)
  To: qemu-trivial; +Cc: BALATON Zoltan, David Gibson, open list:All patches CC here

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

Am Wed, 18 Apr 2018 10:13:10 +0200
schrieb Olaf Hering <olaf@aepfle.de>:

> configure allows to run a dedicated compiler binary, which is stored in
> CC and HOST_CC variables, and overrides the default 'cc' command.
> This command however is not used when building ipxe from source.
> "make -C roms pxerom" invokes ...

Scratch that patch. make -C operates just below 'roms/' and does not use
results from configure. The CC variable built into make(1) happens to be cc.

Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-18  8:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18  8:13 [Qemu-devel] [PATCH v1] roms/ipxe: use configured compiler for ipxe Olaf Hering
2018-04-18  8:32 ` Olaf Hering

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.