[PATCH v2 0/2] ARM: dts: da850: fix warnings related to memory node

[PATCH v2 0/2] ARM: dts: da850: fix warnings related to memory node

[Sekhar Nori]

Hi,

Here are fixes to W=1 warnings related to memory nodes in
DA850 device-tree files.

v2:
- Address David's comments
- Add devicetree mailing list to recipients.

Sekhar Nori (2):
  ARM: dts: da850: get rid of skeleton.dtsi
  ARM: dts: da850-lcdk: add unit name for memory node

 arch/arm/boot/dts/da850-lcdk.dts |  4 ++--
 arch/arm/boot/dts/da850.dtsi     | 11 ++++++++++-
 2 files changed, 12 insertions(+), 3 deletions(-)

-- 
2.16.2

[PATCH v2 0/2] ARM: dts: da850: fix warnings related to memory node

[Sekhar Nori]

Hi,

Here are fixes to W=1 warnings related to memory nodes in
DA850 device-tree files.

v2:
- Address David's comments
- Add devicetree mailing list to recipients.

Sekhar Nori (2):
  ARM: dts: da850: get rid of skeleton.dtsi
  ARM: dts: da850-lcdk: add unit name for memory node

 arch/arm/boot/dts/da850-lcdk.dts |  4 ++--
 arch/arm/boot/dts/da850.dtsi     | 11 ++++++++++-
 2 files changed, 12 insertions(+), 3 deletions(-)

-- 
2.16.2

[PATCH v2 1/2] ARM: dts: da850: get rid of skeleton.dtsi

[Sekhar Nori]

skeleton.dtsi is deprecated. Drop its usage in da850.dtsi
and move the nodes and properties included by it directly
to keep the dtb same.

The memory node has been changed to get rid of warnings
(see below). It contains the memory base address as that is
fixed for DA850 SoCs. But the size needs to be added by
bootloader or a board specific dts.

This gets rid of the following W=1 warnings:

arch/arm/boot/dts/da850-enbw-cmc.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
arch/arm/boot/dts/da850-evm.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
arch/arm/boot/dts/da850-lego-ev3.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

Reviewed-by: David Lechner <david@lechnology.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
v2: No change, add David's Reviewed-by.

 arch/arm/boot/dts/da850.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 73bf7cd3d229..cba3afd00763 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -7,10 +7,19 @@
  * Free Software Foundation;  either version 2 of the  License, or (at your
  * option) any later version.
  */
-#include "skeleton.dtsi"
 #include <dt-bindings/interrupt-controller/irq.h>
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	chosen { };
+	aliases { };
+
+	memory@c0000000 {
+		device_type = "memory";
+		reg = <0xc0000000 0x0>;
+	};
+
 	arm {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.16.2

[PATCH v2 1/2] ARM: dts: da850: get rid of skeleton.dtsi

[Sekhar Nori]

skeleton.dtsi is deprecated. Drop its usage in da850.dtsi
and move the nodes and properties included by it directly
to keep the dtb same.

The memory node has been changed to get rid of warnings
(see below). It contains the memory base address as that is
fixed for DA850 SoCs. But the size needs to be added by
bootloader or a board specific dts.

This gets rid of the following W=1 warnings:

arch/arm/boot/dts/da850-enbw-cmc.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
arch/arm/boot/dts/da850-evm.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
arch/arm/boot/dts/da850-lego-ev3.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

Reviewed-by: David Lechner <david@lechnology.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
v2: No change, add David's Reviewed-by.

 arch/arm/boot/dts/da850.dtsi | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 73bf7cd3d229..cba3afd00763 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -7,10 +7,19 @@
  * Free Software Foundation;  either version 2 of the  License, or (at your
  * option) any later version.
  */
-#include "skeleton.dtsi"
 #include <dt-bindings/interrupt-controller/irq.h>
 
 / {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	chosen { };
+	aliases { };
+
+	memory at c0000000 {
+		device_type = "memory";
+		reg = <0xc0000000 0x0>;
+	};
+
 	arm {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.16.2

[PATCH v2 2/2] ARM: dts: da850-lcdk: add unit name for memory node

[Sekhar Nori]

Add unit name for memory node to squash the W=1 warning:

arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

While at it, drop the device_type property from memory
node since its provided by da850.dtsi already.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
v2: drop device_type property. Add a comment on size of SDRAM.

 arch/arm/boot/dts/da850-lcdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index a1f4d6d5a569..0edf769ea95c 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -21,8 +21,8 @@
 		stdout-path = "serial2:115200n8";
 	};
 
-	memory {
-		device_type = "memory";
+	memory@c0000000 {
+		/* 128 MB DDR2 SDRAM @ 0xc0000000 */
 		reg = <0xc0000000 0x08000000>;
 	};
 
-- 
2.16.2

[PATCH v2 2/2] ARM: dts: da850-lcdk: add unit name for memory node

[Sekhar Nori]

Add unit name for memory node to squash the W=1 warning:

arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

While at it, drop the device_type property from memory
node since its provided by da850.dtsi already.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
v2: drop device_type property. Add a comment on size of SDRAM.

 arch/arm/boot/dts/da850-lcdk.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts
index a1f4d6d5a569..0edf769ea95c 100644
--- a/arch/arm/boot/dts/da850-lcdk.dts
+++ b/arch/arm/boot/dts/da850-lcdk.dts
@@ -21,8 +21,8 @@
 		stdout-path = "serial2:115200n8";
 	};
 
-	memory {
-		device_type = "memory";
+	memory at c0000000 {
+		/* 128 MB DDR2 SDRAM @ 0xc0000000 */
 		reg = <0xc0000000 0x08000000>;
 	};
 
-- 
2.16.2

Re: [PATCH v2 2/2] ARM: dts: da850-lcdk: add unit name for memory node

[David Lechner]

On 04/18/2018 04:24 AM, Sekhar Nori wrote:
> Add unit name for memory node to squash the W=1 warning:
> 
> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> While at it, drop the device_type property from memory
> node since its provided by da850.dtsi already.
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>

[PATCH v2 2/2] ARM: dts: da850-lcdk: add unit name for memory node

[David Lechner]

On 04/18/2018 04:24 AM, Sekhar Nori wrote:
> Add unit name for memory node to squash the W=1 warning:
> 
> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> While at it, drop the device_type property from memory
> node since its provided by da850.dtsi already.
> 
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>

Re: [PATCH v2 2/2] ARM: dts: da850-lcdk: add unit name for memory node

[Sekhar Nori]

On Wednesday 18 April 2018 08:50 PM, David Lechner wrote:
> On 04/18/2018 04:24 AM, Sekhar Nori wrote:
>> Add unit name for memory node to squash the W=1 warning:
>>
>> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg):
>> /memory: node has a reg or ranges property, but no unit name
>>
>> While at it, drop the device_type property from memory
>> node since its provided by da850.dtsi already.
>>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
> 
> Reviewed-by: David Lechner <david@lechnology.com>

Applied both to fixes.

Thanks,
Sekhar

[PATCH v2 2/2] ARM: dts: da850-lcdk: add unit name for memory node

[Sekhar Nori]

On Wednesday 18 April 2018 08:50 PM, David Lechner wrote:
> On 04/18/2018 04:24 AM, Sekhar Nori wrote:
>> Add unit name for memory node to squash the W=1 warning:
>>
>> arch/arm/boot/dts/da850-lcdk.dtb: Warning (unit_address_vs_reg):
>> /memory: node has a reg or ranges property, but no unit name
>>
>> While at it, drop the device_type property from memory
>> node since its provided by da850.dtsi already.
>>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
> 
> Reviewed-by: David Lechner <david@lechnology.com>

Applied both to fixes.

Thanks,
Sekhar