All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables
@ 2018-04-18 10:31 Olivier Gayot
  2018-04-18 13:43 ` Jonathan Corbet
  0 siblings, 1 reply; 5+ messages in thread
From: Olivier Gayot @ 2018-04-18 10:31 UTC (permalink / raw)
  To: Jonathan Corbet; +Cc: linux-doc, Trivial Patch Monkey, Olivier Gayot

The name of the following proc/sysctl entries were incorrectly
documented:

    /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_number
    /proc/sys/net/ipv6/conf/<interface>/max_hbt_opts_number
    /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_length
    /proc/sys/net/ipv6/conf/<interface>/max_hbt_length

Their name was set to the name of the symbol in the .data field of the
control table instead of their .proc name.

Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
---
 Documentation/networking/ip-sysctl.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 5dc1a040a2f1..b583a73cf95f 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -1390,26 +1390,26 @@ mld_qrv - INTEGER
 	Default: 2 (as specified by RFC3810 9.1)
 	Minimum: 1 (as specified by RFC6636 4.5)
 
-max_dst_opts_cnt - INTEGER
+max_dst_opts_number - INTEGER
 	Maximum number of non-padding TLVs allowed in a Destination
 	options extension header. If this value is less than zero
 	then unknown options are disallowed and the number of known
 	TLVs allowed is the absolute value of this number.
 	Default: 8
 
-max_hbh_opts_cnt - INTEGER
+max_hbh_opts_number - INTEGER
 	Maximum number of non-padding TLVs allowed in a Hop-by-Hop
 	options extension header. If this value is less than zero
 	then unknown options are disallowed and the number of known
 	TLVs allowed is the absolute value of this number.
 	Default: 8
 
-max dst_opts_len - INTEGER
+max_dst_opts_length - INTEGER
 	Maximum length allowed for a Destination options extension
 	header.
 	Default: INT_MAX (unlimited)
 
-max hbh_opts_len - INTEGER
+max_hbh_length - INTEGER
 	Maximum length allowed for a Hop-by-Hop options extension
 	header.
 	Default: INT_MAX (unlimited)
-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables
  2018-04-18 10:31 [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables Olivier Gayot
@ 2018-04-18 13:43 ` Jonathan Corbet
  2018-04-18 16:12   ` Olivier Gayot
  0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Corbet @ 2018-04-18 13:43 UTC (permalink / raw)
  To: Olivier Gayot; +Cc: linux-doc, Trivial Patch Monkey

On Wed, 18 Apr 2018 12:31:34 +0200
Olivier Gayot <olivier.gayot@sigexec.com> wrote:

> The name of the following proc/sysctl entries were incorrectly
> documented:
> 
>     /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_number
>     /proc/sys/net/ipv6/conf/<interface>/max_hbt_opts_number
>     /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_length
>     /proc/sys/net/ipv6/conf/<interface>/max_hbt_length
> 
> Their name was set to the name of the symbol in the .data field of the
> control table instead of their .proc name.

The patch seems good, but can I suggest resending it to netdev?  Davem
likes to handle networking docs patches himself.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables
  2018-04-18 13:43 ` Jonathan Corbet
@ 2018-04-18 16:12   ` Olivier Gayot
  0 siblings, 0 replies; 5+ messages in thread
From: Olivier Gayot @ 2018-04-18 16:12 UTC (permalink / raw)
  To: Jonathan Corbet; +Cc: linux-doc, Trivial Patch Monkey

Hi Jonathan,

On Wed, Apr 18, 2018 at 07:43:56AM -0600, Jonathan Corbet wrote:
> The patch seems good, but can I suggest resending it to netdev?  Davem
> likes to handle networking docs patches himself.
> 
> Thanks,
> 
> jon

Sure. Thanks for the feedback. I'll resend to netdev.

Olivier
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables
  2018-04-18 20:03 Olivier Gayot
@ 2018-04-19 19:22 ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-04-19 19:22 UTC (permalink / raw)
  To: olivier.gayot; +Cc: netdev

From: Olivier Gayot <olivier.gayot@sigexec.com>
Date: Wed, 18 Apr 2018 22:03:06 +0200

> The name of the following proc/sysctl entries were incorrectly
> documented:
> 
>     /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_number
>     /proc/sys/net/ipv6/conf/<interface>/max_hbt_opts_number
>     /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_length
>     /proc/sys/net/ipv6/conf/<interface>/max_hbt_length
> 
> Their name was set to the name of the symbol in the .data field of the
> control table instead of their .proc name.
> 
> Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

Good catch, applied, thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables
@ 2018-04-18 20:03 Olivier Gayot
  2018-04-19 19:22 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Olivier Gayot @ 2018-04-18 20:03 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Olivier Gayot

The name of the following proc/sysctl entries were incorrectly
documented:

    /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_number
    /proc/sys/net/ipv6/conf/<interface>/max_hbt_opts_number
    /proc/sys/net/ipv6/conf/<interface>/max_dst_opts_length
    /proc/sys/net/ipv6/conf/<interface>/max_hbt_length

Their name was set to the name of the symbol in the .data field of the
control table instead of their .proc name.

Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
---
 Documentation/networking/ip-sysctl.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 5dc1a040a2f1..b583a73cf95f 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -1390,26 +1390,26 @@ mld_qrv - INTEGER
 	Default: 2 (as specified by RFC3810 9.1)
 	Minimum: 1 (as specified by RFC6636 4.5)
 
-max_dst_opts_cnt - INTEGER
+max_dst_opts_number - INTEGER
 	Maximum number of non-padding TLVs allowed in a Destination
 	options extension header. If this value is less than zero
 	then unknown options are disallowed and the number of known
 	TLVs allowed is the absolute value of this number.
 	Default: 8
 
-max_hbh_opts_cnt - INTEGER
+max_hbh_opts_number - INTEGER
 	Maximum number of non-padding TLVs allowed in a Hop-by-Hop
 	options extension header. If this value is less than zero
 	then unknown options are disallowed and the number of known
 	TLVs allowed is the absolute value of this number.
 	Default: 8
 
-max dst_opts_len - INTEGER
+max_dst_opts_length - INTEGER
 	Maximum length allowed for a Destination options extension
 	header.
 	Default: INT_MAX (unlimited)
 
-max hbh_opts_len - INTEGER
+max_hbh_length - INTEGER
 	Maximum length allowed for a Hop-by-Hop options extension
 	header.
 	Default: INT_MAX (unlimited)
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-04-19 19:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 10:31 [PATCH] docs: ip-sysctl.txt: fix name of some ipv6 variables Olivier Gayot
2018-04-18 13:43 ` Jonathan Corbet
2018-04-18 16:12   ` Olivier Gayot
2018-04-18 20:03 Olivier Gayot
2018-04-19 19:22 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.