[renesas:topic/hs400-mmc-v4 3/4] drivers/mmc/host/tmio_mmc_core.c:1103:5: sparse: symbol 'tmio_mmc_prepare_hs400_tuning' was not declared. Should it be static?

[renesas:topic/hs400-mmc-v4 3/4] drivers/mmc/host/tmio_mmc_core.c:1103:5: sparse: symbol 'tmio_mmc_prepare_hs400_tuning' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/hs400-mmc-v4
head:   bad50f922dfffd9bc1a54e1512852e45d25b4ac7
commit: 485c8281e412190ab902c62868cfebf7dc783189 [3/4] mmc: tmio: add eMMC HS400 mode support
reproduce:
        # apt-get install sparse
        git checkout 485c8281e412190ab902c62868cfebf7dc783189
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/mmc/host/tmio_mmc_core.c:1103:5: sparse: symbol 'tmio_mmc_prepare_hs400_tuning' was not declared. Should it be static?
>> drivers/mmc/host/tmio_mmc_core.c:1113:6: sparse: symbol 'tmio_mmc_prepare_hs400_tuning_downgrade' was not declared. Should it be static?
>> drivers/mmc/host/tmio_mmc_core.c:1122:6: sparse: symbol 'tmio_mmc_complete_hs400_tuning' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH renesas] mmc: tmio: tmio_mmc_prepare_hs400_tuning() can be static

[kbuild test robot]

Fixes: 485c8281e412 ("mmc: tmio: add eMMC HS400 mode support")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 tmio_mmc_core.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 4a83320..cd7afa9 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -1100,7 +1100,7 @@ static int tmio_multi_io_quirk(struct mmc_card *card,
 	return blk_size;
 }
 
-int tmio_mmc_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
+static int tmio_mmc_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
 {
 	struct tmio_mmc_host *host = mmc_priv(mmc);
 
@@ -1110,8 +1110,8 @@ int tmio_mmc_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios)
 	return 0;
 }
 
-void tmio_mmc_prepare_hs400_tuning_downgrade(struct mmc_host *mmc,
-					     struct mmc_ios *ios)
+static void tmio_mmc_prepare_hs400_tuning_downgrade(struct mmc_host *mmc,
+						    struct mmc_ios *ios)
 {
 	struct tmio_mmc_host *host = mmc_priv(mmc);
 
@@ -1119,8 +1119,8 @@ void tmio_mmc_prepare_hs400_tuning_downgrade(struct mmc_host *mmc,
 		host->prepare_hs400_tuning_downgrade(host, ios);
 }
 
-void tmio_mmc_complete_hs400_tuning(struct mmc_host *mmc,
-				    struct mmc_ios *ios)
+static void tmio_mmc_complete_hs400_tuning(struct mmc_host *mmc,
+					   struct mmc_ios *ios)
 {
 	struct tmio_mmc_host *host = mmc_priv(mmc);
 

Re: [renesas:topic/hs400-mmc-v4 3/4] drivers/mmc/host/tmio_mmc_core.c:1103:5: sparse: symbol 'tmio_mmc_prepare_hs400_tuning' was not declared. Should it be static?

[Simon Horman]

On Wed, Apr 18, 2018 at 08:26:08PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git topic/hs400-mmc-v4
> head:   bad50f922dfffd9bc1a54e1512852e45d25b4ac7
> commit: 485c8281e412190ab902c62868cfebf7dc783189 [3/4] mmc: tmio: add eMMC HS400 mode support
> reproduce:
>         # apt-get install sparse
>         git checkout 485c8281e412190ab902c62868cfebf7dc783189
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/mmc/host/tmio_mmc_core.c:1103:5: sparse: symbol 'tmio_mmc_prepare_hs400_tuning' was not declared. Should it be static?
> >> drivers/mmc/host/tmio_mmc_core.c:1113:6: sparse: symbol 'tmio_mmc_prepare_hs400_tuning_downgrade' was not declared. Should it be static?
> >> drivers/mmc/host/tmio_mmc_core.c:1122:6: sparse: symbol 'tmio_mmc_complete_hs400_tuning' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.

Thanks. Yes, I agree that it looks like they should be static.
I'll address this when posting v5 of this patchset.