* [PATCH net-next v3] team: account for oper state
@ 2018-04-19 10:34 George Wilkie
2018-04-19 11:16 ` Jiri Pirko
2018-04-20 15:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: George Wilkie @ 2018-04-19 10:34 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev
Account for operational state when determining port linkup state,
as per Documentation/networking/operstates.txt.
Signed-off-by: George Wilkie <gwilkie@vyatta.att-mail.com>
---
drivers/net/team/team.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index a6c6ce19eeee..8a8611095ca0 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2918,7 +2918,7 @@ static int team_device_event(struct notifier_block *unused,
case NETDEV_CHANGE:
if (netif_running(port->dev))
team_port_change_check(port,
- !!netif_carrier_ok(port->dev));
+ !!netif_oper_up(port->dev));
break;
case NETDEV_UNREGISTER:
team_del_slave(port->team->dev, dev);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3] team: account for oper state
2018-04-19 10:34 [PATCH net-next v3] team: account for oper state George Wilkie
@ 2018-04-19 11:16 ` Jiri Pirko
2018-04-20 15:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2018-04-19 11:16 UTC (permalink / raw)
To: George Wilkie; +Cc: netdev
Thu, Apr 19, 2018 at 12:34:14PM CEST, gwilkie@vyatta.att-mail.com wrote:
>Account for operational state when determining port linkup state,
>as per Documentation/networking/operstates.txt.
>
>Signed-off-by: George Wilkie <gwilkie@vyatta.att-mail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3] team: account for oper state
2018-04-19 10:34 [PATCH net-next v3] team: account for oper state George Wilkie
2018-04-19 11:16 ` Jiri Pirko
@ 2018-04-20 15:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-04-20 15:13 UTC (permalink / raw)
To: gwilkie; +Cc: jiri, netdev
From: George Wilkie <gwilkie@vyatta.att-mail.com>
Date: Thu, 19 Apr 2018 11:34:14 +0100
> Account for operational state when determining port linkup state,
> as per Documentation/networking/operstates.txt.
>
> Signed-off-by: George Wilkie <gwilkie@vyatta.att-mail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-20 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 10:34 [PATCH net-next v3] team: account for oper state George Wilkie
2018-04-19 11:16 ` Jiri Pirko
2018-04-20 15:13 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.