* [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status
@ 2018-04-17 14:26 Petri Latvala
2018-04-17 14:39 ` Antonio Argenziano
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Petri Latvala @ 2018-04-17 14:26 UTC (permalink / raw)
To: igt-dev
A timeout failure seems exactly what IGT_EXIT_TIMEOUT is for.
Also make the failure error message be printed with critical log level
to match what's done for __igt_fail_assert's message.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
lib/igt_core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/igt_core.c b/lib/igt_core.c
index 5092a3f0..af36fef9 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -2143,12 +2143,12 @@ static const char *timeout_op;
static void __attribute__((noreturn)) igt_alarm_handler(int signal)
{
if (timeout_op)
- igt_info("Timed out: %s\n", timeout_op);
+ igt_critical("Timed out: %s\n", timeout_op);
else
- igt_info("Timed out\n");
+ igt_critical("Timed out\n");
/* exit with failure status */
- igt_fail(IGT_EXIT_FAILURE);
+ igt_fail(IGT_EXIT_TIMEOUT);
}
/**
@@ -2156,7 +2156,7 @@ static void __attribute__((noreturn)) igt_alarm_handler(int signal)
* @seconds: number of seconds before timeout
* @op: Optional string to explain what operation has timed out in the debug log
*
- * Fail a test and exit with #IGT_EXIT_FAILURE status after the specified
+ * Fail a test and exit with #IGT_EXIT_TIMEOUT status after the specified
* number of seconds have elapsed. If the current test has subtests and the
* timeout occurs outside a subtest, subsequent subtests will be skipped and
* marked as failed.
--
2.14.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status
2018-04-17 14:26 [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status Petri Latvala
@ 2018-04-17 14:39 ` Antonio Argenziano
2018-04-19 10:24 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Antonio Argenziano @ 2018-04-17 14:39 UTC (permalink / raw)
To: Petri Latvala, igt-dev
On 17/04/18 07:26, Petri Latvala wrote:
> A timeout failure seems exactly what IGT_EXIT_TIMEOUT is for.
>
> Also make the failure error message be printed with critical log level
> to match what's done for __igt_fail_assert's message.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>
> ---
> lib/igt_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 5092a3f0..af36fef9 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -2143,12 +2143,12 @@ static const char *timeout_op;
> static void __attribute__((noreturn)) igt_alarm_handler(int signal)
> {
> if (timeout_op)
> - igt_info("Timed out: %s\n", timeout_op);
> + igt_critical("Timed out: %s\n", timeout_op);
> else
> - igt_info("Timed out\n");
> + igt_critical("Timed out\n");
>
> /* exit with failure status */
> - igt_fail(IGT_EXIT_FAILURE);
> + igt_fail(IGT_EXIT_TIMEOUT);
> }
>
> /**
> @@ -2156,7 +2156,7 @@ static void __attribute__((noreturn)) igt_alarm_handler(int signal)
> * @seconds: number of seconds before timeout
> * @op: Optional string to explain what operation has timed out in the debug log
> *
> - * Fail a test and exit with #IGT_EXIT_FAILURE status after the specified
> + * Fail a test and exit with #IGT_EXIT_TIMEOUT status after the specified
> * number of seconds have elapsed. If the current test has subtests and the
> * timeout occurs outside a subtest, subsequent subtests will be skipped and
> * marked as failed.
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
2018-04-17 14:26 [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status Petri Latvala
2018-04-17 14:39 ` Antonio Argenziano
@ 2018-04-19 10:24 ` Patchwork
2018-04-19 11:52 ` Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-19 10:24 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
URL : https://patchwork.freedesktop.org/series/41826/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4068 -> IGTPW_1278 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41826/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1278 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-ivb-3520m: PASS -> DMESG-WARN (fdo#106084)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-glk-1: NOTRUN -> INCOMPLETE (k.org#198133, fdo#103359)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (34 -> 32) ==
Additional (1): fi-glk-1
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4441 -> IGTPW_1278
CI_DRM_4068: 28fecc12e5c2b1beb9ab89e3616266d5d5e58e3d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1278/
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1278/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
2018-04-17 14:26 [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status Petri Latvala
2018-04-17 14:39 ` Antonio Argenziano
2018-04-19 10:24 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
@ 2018-04-19 11:52 ` Patchwork
2018-04-19 12:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-19 15:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-19 11:52 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
URL : https://patchwork.freedesktop.org/series/41826/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4068 -> IGTPW_1281 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41826/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1281 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
igt@gem_exec_suspend@basic-s3:
fi-ivb-3520m: PASS -> DMESG-WARN (fdo#106084) +1
igt@kms_chamelium@hdmi-hpd-fast:
fi-kbl-7500u: SKIP -> FAIL (fdo#102672, fdo#103841)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-glk-1: NOTRUN -> INCOMPLETE (fdo#103359, k.org#198133)
==== Possible fixes ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: FAIL (fdo#102575) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (34 -> 32) ==
Additional (1): fi-glk-1
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4441 -> IGTPW_1281
CI_DRM_4068: 28fecc12e5c2b1beb9ab89e3616266d5d5e58e3d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1281: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1281/
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1281/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
2018-04-17 14:26 [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status Petri Latvala
` (2 preceding siblings ...)
2018-04-19 11:52 ` Patchwork
@ 2018-04-19 12:59 ` Patchwork
2018-04-19 15:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-19 12:59 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
URL : https://patchwork.freedesktop.org/series/41826/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4441_full -> IGTPW_1278_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1278_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1278_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41826/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1278_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: PASS -> SKIP
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS +1
== Known issues ==
Here are the changes found in IGTPW_1278_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_atomic_transition@plane-all-modeset-transition:
shard-hsw: PASS -> DMESG-WARN (fdo#102614)
igt@kms_fbcon_fbt@fbc-suspend:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558, fdo#103313)
igt@kms_flip@basic-flip-vs-wf_vblank:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-a-accuracy-idle:
shard-hsw: PASS -> FAIL (fdo#102583)
igt@pm_rpm@universal-planes:
shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#103313)
==== Possible fixes ====
igt@drv_suspend@forcewake:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@2x-dpms-vs-vblank-race:
shard-hsw: FAIL (fdo#103060) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: FAIL (fdo#102887) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-hsw: FAIL (fdo#103925) -> PASS
igt@perf_pmu@interrupts-sync:
shard-apl: FAIL (fdo#104485) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104485 https://bugs.freedesktop.org/show_bug.cgi?id=104485
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 4) ==
Missing (1): shard-glkb
== Build changes ==
* IGT: IGT_4441 -> IGTPW_1278
* Linux: CI_DRM_4059 -> CI_DRM_4068
CI_DRM_4059: c1645edc253f2b52a8c94565a75b479a6782e75f @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4068: 28fecc12e5c2b1beb9ab89e3616266d5d5e58e3d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1278/
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1278/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
2018-04-17 14:26 [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status Petri Latvala
` (3 preceding siblings ...)
2018-04-19 12:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-04-19 15:30 ` Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-19 15:30 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] lib: Make igt_set_timeout fail with a timeout status
URL : https://patchwork.freedesktop.org/series/41826/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4441_full -> IGTPW_1281_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1281_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1281_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41826/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1281_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_flip@2x-plain-flip-ts-check:
shard-hsw: PASS -> FAIL
igt@kms_pipe_crc_basic@read-crc-pipe-c:
shard-apl: PASS -> FAIL
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: PASS -> SKIP
igt@perf_pmu@rc6:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_1281_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_chv_cursor_fail@pipe-b-256x256-top-edge:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_flip@2x-flip-vs-blocking-wf-vblank:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@perf@polling:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@drv_suspend@forcewake:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@2x-dpms-vs-vblank-race:
shard-hsw: FAIL (fdo#103060) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: FAIL (fdo#102887) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-hsw: FAIL (fdo#103925) -> PASS
igt@perf_pmu@interrupts-sync:
shard-apl: FAIL (fdo#104485) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104485 https://bugs.freedesktop.org/show_bug.cgi?id=104485
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 4) ==
Missing (1): shard-glkb
== Build changes ==
* IGT: IGT_4441 -> IGTPW_1281
* Linux: CI_DRM_4059 -> CI_DRM_4068
CI_DRM_4059: c1645edc253f2b52a8c94565a75b479a6782e75f @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4068: 28fecc12e5c2b1beb9ab89e3616266d5d5e58e3d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1281: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1281/
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1281/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-19 15:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 14:26 [igt-dev] [PATCH i-g-t 1/1] lib: Make igt_set_timeout fail with a timeout status Petri Latvala
2018-04-17 14:39 ` Antonio Argenziano
2018-04-19 10:24 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-04-19 11:52 ` Patchwork
2018-04-19 12:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-04-19 15:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.