[igt-dev] [PATCH i-g-t] tests/kms_force_connector_basic: Don't skip when VGA is connected

[igt-dev] [PATCH i-g-t] tests/kms_force_connector_basic: Don't skip when VGA is connected

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We can override the connector status/EDID just fine even if the
thing is already connected. So let's not skip in that case.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_force_connector_basic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
index d11a775a089d..6e96c6be7dab 100644
--- a/tests/kms_force_connector_basic.c
+++ b/tests/kms_force_connector_basic.c
@@ -115,7 +115,6 @@ int main(int argc, char **argv)
 
 		/* Reacquire status after clearing any previous overrides */
 		vga_connector = drmModeGetConnector(drm_fd, vga_connector_id);
-		igt_skip_on(vga_connector->connection == DRM_MODE_CONNECTED);
 
 		start_n_modes = vga_connector->count_modes;
 		start_connection = vga_connector->connection;
-- 
2.16.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_force_connector_basic: Don't skip when VGA is connected

[Patchwork]

== Series Details ==

Series: tests/kms_force_connector_basic: Don't skip when VGA is connected
URL   : https://patchwork.freedesktop.org/series/41981/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4070 -> IGTPW_1287 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1287 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1287, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/41981/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1287:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_force_connector_basic@force-connector-state:
      fi-ilk-650:         SKIP -> PASS +3

    igt@kms_force_connector_basic@force-edid:
      fi-ivb-3770:        SKIP -> PASS +3

    igt@kms_force_connector_basic@force-load-detect:
      fi-hsw-4770:        SKIP -> PASS +3

    igt@kms_force_connector_basic@prune-stale-modes:
      fi-blb-e6850:       SKIP -> PASS +3
      fi-gdg-551:         SKIP -> PASS +3

    
== Known issues ==

  Here are the changes found in IGTPW_1287 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_chamelium@dp-edid-read:
      fi-kbl-7500u:       PASS -> FAIL (fdo#103841)

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-skl-guc:         PASS -> FAIL (fdo#103191)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-glk-1:           PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-ivb-3520m:       PASS -> DMESG-WARN (fdo#106084)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-ivb-3520m:       DMESG-WARN (fdo#106084) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (35 -> 32) ==

  Missing    (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq 


== Build changes ==

    * IGT: IGT_4441 -> IGTPW_1287

  CI_DRM_4070: 47f407780a2b330f097892203401986838eb9795 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1287: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1287/
  IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1287/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/kms_force_connector_basic: Don't skip when VGA is connected

[Patchwork]

== Series Details ==

Series: tests/kms_force_connector_basic: Don't skip when VGA is connected
URL   : https://patchwork.freedesktop.org/series/41981/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4441_full -> IGTPW_1287_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1287_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1287_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/41981/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1287_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_linear_blits@normal:
      shard-apl:          PASS -> SKIP

    igt@kms_force_connector_basic@force-connector-state:
      shard-snb:          SKIP -> PASS +3

    igt@kms_force_connector_basic@prune-stale-modes:
      shard-hsw:          SKIP -> PASS +3

    
== Known issues ==

  Here are the changes found in IGTPW_1287_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_legacy@cursor-vs-flip-legacy:
      shard-hsw:          PASS -> FAIL (fdo#103355)

    igt@kms_flip@2x-flip-vs-wf_vblank:
      shard-hsw:          PASS -> FAIL (fdo#100368)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_vblank@pipe-b-accuracy-idle:
      shard-hsw:          PASS -> FAIL (fdo#102583)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-dpms-vs-vblank-race:
      shard-hsw:          FAIL (fdo#103060) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-hsw:          FAIL (fdo#102887) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-hsw:          FAIL (fdo#103925) -> PASS

    igt@kms_sysfs_edid_timing:
      shard-apl:          WARN (fdo#100047) -> PASS

    igt@perf_pmu@interrupts-sync:
      shard-apl:          FAIL (fdo#104485) -> PASS

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104485 https://bugs.freedesktop.org/show_bug.cgi?id=104485


== Participating hosts (5 -> 3) ==

  Missing    (2): shard-glkb shard-kbl 


== Build changes ==

    * IGT: IGT_4441 -> IGTPW_1287
    * Linux: CI_DRM_4059 -> CI_DRM_4070

  CI_DRM_4059: c1645edc253f2b52a8c94565a75b479a6782e75f @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4070: 47f407780a2b330f097892203401986838eb9795 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1287: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1287/
  IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1287/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_force_connector_basic: Don't skip when VGA is connected

[Daniel Vetter]

On Thu, Apr 19, 2018 at 06:27:04PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We can override the connector status/EDID just fine even if the
> thing is already connected. So let's not skip in that case.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

I think very long times ago we checked that it goes back to unconnected,
or something like that.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  tests/kms_force_connector_basic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/kms_force_connector_basic.c b/tests/kms_force_connector_basic.c
> index d11a775a089d..6e96c6be7dab 100644
> --- a/tests/kms_force_connector_basic.c
> +++ b/tests/kms_force_connector_basic.c
> @@ -115,7 +115,6 @@ int main(int argc, char **argv)
>  
>  		/* Reacquire status after clearing any previous overrides */
>  		vga_connector = drmModeGetConnector(drm_fd, vga_connector_id);
> -		igt_skip_on(vga_connector->connection == DRM_MODE_CONNECTED);
>  
>  		start_n_modes = vga_connector->count_modes;
>  		start_connection = vga_connector->connection;
> -- 
> 2.16.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev