* [PATCH] ARM: dts: da850-lego-ev3: Fix battery voltage gpio
@ 2018-04-14 4:12 David Lechner
2018-04-19 16:18 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2018-04-14 4:12 UTC (permalink / raw)
To: stable; +Cc: David Lechner, Sekhar Nori
This fixes the battery voltage monitoring gpio-hog settings.
When the gpio is low, it turns off the battery voltage to the ADC chip.
However, this needs to be on all of the time so that we can monitor
battery voltage.
Also, there was a typo that prevented pinmuxing from working correctly.
Signed-off-by: David Lechner <david@lechnology.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
This has already been picked up in mainline in 4.15 (c5a88cd2e1c5). However, I
forgot to cc stable when I originally submitted the patch. It would be nice to
get this in the linux-4.14.y branch.
arch/arm/boot/dts/da850-lego-ev3.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/da850-lego-ev3.dts b/arch/arm/boot/dts/da850-lego-ev3.dts
index 413dbd5d9f64..81942ae83e1f 100644
--- a/arch/arm/boot/dts/da850-lego-ev3.dts
+++ b/arch/arm/boot/dts/da850-lego-ev3.dts
@@ -178,7 +178,7 @@
*/
battery {
pinctrl-names = "default";
- pintctrl-0 = <&battery_pins>;
+ pinctrl-0 = <&battery_pins>;
compatible = "lego,ev3-battery";
io-channels = <&adc 4>, <&adc 3>;
io-channel-names = "voltage", "current";
@@ -392,7 +392,7 @@
batt_volt_en {
gpio-hog;
gpios = <6 GPIO_ACTIVE_HIGH>;
- output-low;
+ output-high;
};
};
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: da850-lego-ev3: Fix battery voltage gpio
2018-04-14 4:12 [PATCH] ARM: dts: da850-lego-ev3: Fix battery voltage gpio David Lechner
@ 2018-04-19 16:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-04-19 16:18 UTC (permalink / raw)
To: David Lechner; +Cc: stable, Sekhar Nori
On Fri, Apr 13, 2018 at 11:12:10PM -0500, David Lechner wrote:
> This fixes the battery voltage monitoring gpio-hog settings.
>
> When the gpio is low, it turns off the battery voltage to the ADC chip.
> However, this needs to be on all of the time so that we can monitor
> battery voltage.
>
> Also, there was a typo that prevented pinmuxing from working correctly.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>
> This has already been picked up in mainline in 4.15 (c5a88cd2e1c5). However, I
> forgot to cc stable when I originally submitted the patch. It would be nice to
> get this in the linux-4.14.y branch.
Now applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-19 16:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-14 4:12 [PATCH] ARM: dts: da850-lego-ev3: Fix battery voltage gpio David Lechner
2018-04-19 16:18 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.