Re: [PATCH] USB: Increment wakeup count on remote wakeup.

From: kbuild test robot <lkp@intel.com>
To: Ravi Chandra Sadineni <ravisadineni@chromium.org>
Cc: kbuild-all@01.org, stern@rowland.harvard.edu,
	gregkh@linuxfoundation.org, martin.blumenstingl@googlemail.com,
	ravisadineni@google.com, chunfeng.yun@mediatek.com,
	johan@kernel.org, arvind.yadav.cs@gmail.com, dtor@google.com,
	anton.bondarenko.sama@gmail.com, f.fainelli@gmail.com,
	keescook@chromium.org, mathias.nyman@linux.intel.com,
	felipe.balbi@linux.intel.com, ekorenevsky@gmail.com,
	peter.chen@nxp.com, joe@perches.com, tbroch@google.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	rajatja@google.com, bleung@google.com,
	Ravi Chandra Sadineni <ravisadineni@chromium.org>
Subject: Re: [PATCH] USB: Increment wakeup count on remote wakeup.
Date: Thu, 19 Apr 2018 17:30:58 +0800	[thread overview]
Message-ID: <201804191735.lGfX5YTi%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180419001850.133110-1-ravisadineni@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]

Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: x86_64-randconfig-x013-201815 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb//core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb//core/hcd.c:2378:18: error: 'dev' undeclared (first use in this function); did you mean 'cdev'?
     pm_wakeup_event(dev, 0);
                     ^~~
                     cdev
   drivers/usb//core/hcd.c:2378:18: note: each undeclared identifier is reported only once for each function it appears in

vim +2378 drivers/usb//core/hcd.c

  2364	
  2365	/**
  2366	 * usb_hcd_resume_root_hub - called by HCD to resume its root hub
  2367	 * @hcd: host controller for this root hub
  2368	 *
  2369	 * The USB host controller calls this function when its root hub is
  2370	 * suspended (with the remote wakeup feature enabled) and a remote
  2371	 * wakeup request is received.  The routine submits a workqueue request
  2372	 * to resume the root hub (that is, manage its downstream ports again).
  2373	 */
  2374	void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
  2375	{
  2376		unsigned long flags;
  2377	
> 2378		pm_wakeup_event(dev, 0);
  2379		spin_lock_irqsave (&hcd_root_hub_lock, flags);
  2380		if (hcd->rh_registered) {
  2381			set_bit(HCD_FLAG_WAKEUP_PENDING, &hcd->flags);
  2382			queue_work(pm_wq, &hcd->wakeup_work);
  2383		}
  2384		spin_unlock_irqrestore (&hcd_root_hub_lock, flags);
  2385	}
  2386	EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
  2387	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29813 bytes --]