* [PATCH] go-runtime_1.9: pass BUILD_ flags to cgo for host-side build
@ 2018-04-21 13:19 Matt Madison
2018-04-21 18:11 ` Khem Raj
2018-04-21 19:24 ` Burton, Ross
0 siblings, 2 replies; 3+ messages in thread
From: Matt Madison @ 2018-04-21 13:19 UTC (permalink / raw)
To: openembedded-core; +Cc: otavio
When running the make.bash script to build the host-side
tools, make sure that cgo is using CFLAGS and LDFLAGS for
the build host, rather than those for the target.
[YOCTO #12704]
Signed-off-by: Matt Madison <matt@madison.systems>
---
meta/recipes-devtools/go/go-runtime_1.9.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/go/go-runtime_1.9.bb b/meta/recipes-devtools/go/go-runtime_1.9.bb
index a99cc30f63..d5279ea897 100644
--- a/meta/recipes-devtools/go/go-runtime_1.9.bb
+++ b/meta/recipes-devtools/go/go-runtime_1.9.bb
@@ -11,7 +11,7 @@ do_compile() {
export CC=$BUILD_CC
cd src
- ./make.bash --host-only
+ CGO_CFLAGS="${BUILD_CFLAGS}" CGO_LDFLAGS="${BUILD_LDFLAGS}" ./make.bash --host-only
cp ${B}/pkg/tool/${BUILD_GOTUPLE}/go_bootstrap ${B}
rm -rf ${B}/pkg/${TARGET_GOTUPLE}
./make.bash --target-only
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] go-runtime_1.9: pass BUILD_ flags to cgo for host-side build
2018-04-21 13:19 [PATCH] go-runtime_1.9: pass BUILD_ flags to cgo for host-side build Matt Madison
@ 2018-04-21 18:11 ` Khem Raj
2018-04-21 19:24 ` Burton, Ross
1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2018-04-21 18:11 UTC (permalink / raw)
To: Matt Madison; +Cc: otavio, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
On Sat, Apr 21, 2018 at 6:20 AM Matt Madison <matt@madison.systems> wrote:
> When running the make.bash script to build the host-side
> tools, make sure that cgo is using CFLAGS and LDFLAGS for
> the build host, rather than those for the target.
LGTM I have tested similar patch last night it should fix the issue at hand
Thanks for quick fix
>
> [YOCTO #12704]
>
> Signed-off-by: Matt Madison <matt@madison.systems>
> ---
> meta/recipes-devtools/go/go-runtime_1.9.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/go/go-runtime_1.9.bb
> b/meta/recipes-devtools/go/go-runtime_1.9.bb
> index a99cc30f63..d5279ea897 100644
> --- a/meta/recipes-devtools/go/go-runtime_1.9.bb
> +++ b/meta/recipes-devtools/go/go-runtime_1.9.bb
> @@ -11,7 +11,7 @@ do_compile() {
> export CC=$BUILD_CC
>
> cd src
> - ./make.bash --host-only
> + CGO_CFLAGS="${BUILD_CFLAGS}" CGO_LDFLAGS="${BUILD_LDFLAGS}"
> ./make.bash --host-only
> cp ${B}/pkg/tool/${BUILD_GOTUPLE}/go_bootstrap ${B}
> rm -rf ${B}/pkg/${TARGET_GOTUPLE}
> ./make.bash --target-only
> --
> 2.14.1
>
>
[-- Attachment #2: Type: text/html, Size: 2046 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] go-runtime_1.9: pass BUILD_ flags to cgo for host-side build
2018-04-21 13:19 [PATCH] go-runtime_1.9: pass BUILD_ flags to cgo for host-side build Matt Madison
2018-04-21 18:11 ` Khem Raj
@ 2018-04-21 19:24 ` Burton, Ross
1 sibling, 0 replies; 3+ messages in thread
From: Burton, Ross @ 2018-04-21 19:24 UTC (permalink / raw)
To: Matt Madison; +Cc: Otavio Salvador, OE-core
Thanks Matt!
On 21 April 2018 at 14:19, Matt Madison <matt@madison.systems> wrote:
> When running the make.bash script to build the host-side
> tools, make sure that cgo is using CFLAGS and LDFLAGS for
> the build host, rather than those for the target.
>
> [YOCTO #12704]
>
> Signed-off-by: Matt Madison <matt@madison.systems>
> ---
> meta/recipes-devtools/go/go-runtime_1.9.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/go/go-runtime_1.9.bb b/meta/recipes-devtools/go/go-runtime_1.9.bb
> index a99cc30f63..d5279ea897 100644
> --- a/meta/recipes-devtools/go/go-runtime_1.9.bb
> +++ b/meta/recipes-devtools/go/go-runtime_1.9.bb
> @@ -11,7 +11,7 @@ do_compile() {
> export CC=$BUILD_CC
>
> cd src
> - ./make.bash --host-only
> + CGO_CFLAGS="${BUILD_CFLAGS}" CGO_LDFLAGS="${BUILD_LDFLAGS}" ./make.bash --host-only
> cp ${B}/pkg/tool/${BUILD_GOTUPLE}/go_bootstrap ${B}
> rm -rf ${B}/pkg/${TARGET_GOTUPLE}
> ./make.bash --target-only
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-21 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-21 13:19 [PATCH] go-runtime_1.9: pass BUILD_ flags to cgo for host-side build Matt Madison
2018-04-21 18:11 ` Khem Raj
2018-04-21 19:24 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.