From: Greg KH <gregkh@linuxfoundation.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Alan Cox <alan@linux.intel.com>, Andrew Jeffery <andrew@aj.id.au>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Haiyue Wang <haiyue.wang@linux.intel.com>,
James Feist <james.feist@linux.intel.com>,
Jason M Biils <jason.m.bills@linux.intel.com>,
Jean Delvare <jdelvare@suse.com>, Joel Stanley <joel@jms.id.au>,
Julia Cartwright <juliac@eso.teric.us>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Milton Miller II <miltonm@us.ibm.com>,
Pavel Machek <pavel@ucw.cz>, Randy Dunlap <rdunlap@infradead.org>,
Stef van Os <stef.van.os@prodrive-technologies.com>,
Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>,
Vernon Mauery <vernon.mauery@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core
Date: Mon, 23 Apr 2018 12:52:24 +0200 [thread overview]
Message-ID: <20180423105224.GA1444@kroah.com> (raw)
In-Reply-To: <20180410183212.16787-4-jae.hyun.yoo@linux.intel.com>
On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote:
> +static void peci_adapter_dev_release(struct device *dev)
> +{
> + /* do nothing */
> +}
As per the in-kernel documentation, I am now allowed to make fun of you.
You are trying to "out smart" the kernel by getting rid of a warning
message that was explicitly put there for you to do something. To think
that by just providing an "empty" function you are somehow fulfilling
the API requirement is quite bold, don't you think?
This has to be fixed. I didn't put that warning in there for no good
reason. Please go read the documentation again...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Alan Cox <alan@linux.intel.com>, Andrew Jeffery <andrew@aj.id.au>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Haiyue Wang <haiyue.wang@linux.intel.com>,
James Feist <james.feist@linux.intel.com>,
Jason M Biils <jason.m.bills@linux.intel.com>,
Jean Delvare <jdelvare@suse.com>, Joel Stanley <joel@jms.id.au>,
Julia Cartwright <juliac@eso.teric.us>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Milton Miller II <miltonm@us.ibm.com>,
Pavel Machek <pavel@ucw.cz>, Randy Dunlap <rdunlap@infradead.org>,
Stef van Os <stef.van.os@prodrive-technologies.com>,
Sumeet
Subject: Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core
Date: Mon, 23 Apr 2018 12:52:24 +0200 [thread overview]
Message-ID: <20180423105224.GA1444@kroah.com> (raw)
In-Reply-To: <20180410183212.16787-4-jae.hyun.yoo@linux.intel.com>
On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote:
> +static void peci_adapter_dev_release(struct device *dev)
> +{
> + /* do nothing */
> +}
As per the in-kernel documentation, I am now allowed to make fun of you.
You are trying to "out smart" the kernel by getting rid of a warning
message that was explicitly put there for you to do something. To think
that by just providing an "empty" function you are somehow fulfilling
the API requirement is quite bold, don't you think?
This has to be fixed. I didn't put that warning in there for no good
reason. Please go read the documentation again...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Alan Cox <alan@linux.intel.com>, Andrew Jeffery <andrew@aj.id.au>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Haiyue Wang <haiyue.wang@linux.intel.com>,
James Feist <james.feist@linux.intel.com>,
Jason M Biils <jason.m.bills@linux.intel.com>,
Jean Delvare <jdelvare@suse.com>, Joel Stanley <joel@jms.id.au>,
Julia Cartwright <juliac@eso.teric.us>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Milton Miller II <miltonm@us.ibm.com>,
Pavel Machek <pavel@ucw.cz>, Randy Dunlap <rdunlap@infradead.org>,
Stef van Os <stef.van.os@prodrive-technologies.com>,
Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>,
Vernon Mauery <vernon.mauery@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core
Date: Mon, 23 Apr 2018 12:52:24 +0200 [thread overview]
Message-ID: <20180423105224.GA1444@kroah.com> (raw)
In-Reply-To: <20180410183212.16787-4-jae.hyun.yoo@linux.intel.com>
On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote:
> +static void peci_adapter_dev_release(struct device *dev)
> +{
> + /* do nothing */
> +}
As per the in-kernel documentation, I am now allowed to make fun of you.
You are trying to "out smart" the kernel by getting rid of a warning
message that was explicitly put there for you to do something. To think
that by just providing an "empty" function you are somehow fulfilling
the API requirement is quite bold, don't you think?
This has to be fixed. I didn't put that warning in there for no good
reason. Please go read the documentation again...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core
Date: Mon, 23 Apr 2018 12:52:24 +0200 [thread overview]
Message-ID: <20180423105224.GA1444@kroah.com> (raw)
In-Reply-To: <20180410183212.16787-4-jae.hyun.yoo@linux.intel.com>
On Tue, Apr 10, 2018 at 11:32:05AM -0700, Jae Hyun Yoo wrote:
> +static void peci_adapter_dev_release(struct device *dev)
> +{
> + /* do nothing */
> +}
As per the in-kernel documentation, I am now allowed to make fun of you.
You are trying to "out smart" the kernel by getting rid of a warning
message that was explicitly put there for you to do something. To think
that by just providing an "empty" function you are somehow fulfilling
the API requirement is quite bold, don't you think?
This has to be fixed. I didn't put that warning in there for no good
reason. Please go read the documentation again...
greg k-h
next prev parent reply other threads:[~2018-04-23 10:52 UTC|newest]
Thread overview: 227+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 18:32 [PATCH v3 00/10] PECI device driver introduction Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-12 2:06 ` Jae Hyun Yoo
2018-04-12 2:06 ` Jae Hyun Yoo
2018-04-12 2:06 ` Jae Hyun Yoo
2018-04-12 2:06 ` Jae Hyun Yoo
2018-04-16 17:59 ` Rob Herring
2018-04-16 17:59 ` Rob Herring
2018-04-16 17:59 ` Rob Herring
2018-04-16 17:59 ` Rob Herring
2018-04-16 23:06 ` Jae Hyun Yoo
2018-04-16 23:06 ` Jae Hyun Yoo
2018-04-16 23:06 ` Jae Hyun Yoo
2018-04-16 23:06 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 02/10] Documentations: ioctl: Add ioctl numbers for PECI subsystem Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 03/10] drivers/peci: Add support for PECI bus driver core Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-19 18:59 ` kbuild test robot
2018-04-19 18:59 ` kbuild test robot
2018-04-19 18:59 ` kbuild test robot
2018-04-23 10:52 ` Greg KH [this message]
2018-04-23 10:52 ` Greg KH
2018-04-23 10:52 ` Greg KH
2018-04-23 10:52 ` Greg KH
2018-04-23 17:40 ` Jae Hyun Yoo
2018-04-23 17:40 ` Jae Hyun Yoo
2018-04-23 17:40 ` Jae Hyun Yoo
2018-04-23 17:40 ` Jae Hyun Yoo
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:01 ` Andy Shevchenko
2018-04-24 16:29 ` Jae Hyun Yoo
2018-04-24 16:29 ` Jae Hyun Yoo
2018-04-24 16:29 ` Jae Hyun Yoo
2018-04-24 16:29 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-12 2:11 ` Jae Hyun Yoo
2018-04-12 2:11 ` Jae Hyun Yoo
2018-04-12 2:11 ` Jae Hyun Yoo
2018-04-12 2:11 ` Jae Hyun Yoo
2018-04-16 18:10 ` Rob Herring
2018-04-16 18:10 ` Rob Herring
2018-04-16 18:10 ` Rob Herring
2018-04-16 18:10 ` Rob Herring
2018-04-16 23:12 ` Jae Hyun Yoo
2018-04-16 23:12 ` Jae Hyun Yoo
2018-04-16 23:12 ` Jae Hyun Yoo
2018-04-16 23:12 ` Jae Hyun Yoo
2018-04-17 13:16 ` Rob Herring
2018-04-17 13:16 ` Rob Herring
2018-04-17 13:16 ` Rob Herring
2018-04-17 13:16 ` Rob Herring
2018-04-17 13:16 ` Rob Herring
2018-04-17 18:16 ` Jae Hyun Yoo
2018-04-17 18:16 ` Jae Hyun Yoo
2018-04-17 18:16 ` Jae Hyun Yoo
2018-04-17 18:16 ` Jae Hyun Yoo
2018-04-17 22:06 ` Jae Hyun Yoo
2018-04-17 22:06 ` Jae Hyun Yoo
2018-04-17 22:06 ` Jae Hyun Yoo
2018-04-17 22:06 ` Jae Hyun Yoo
2018-04-18 13:59 ` Rob Herring
2018-04-18 13:59 ` Rob Herring
2018-04-18 13:59 ` Rob Herring
2018-04-18 13:59 ` Rob Herring
2018-04-18 13:59 ` Rob Herring
2018-04-18 16:45 ` Jae Hyun Yoo
2018-04-18 16:45 ` Jae Hyun Yoo
2018-04-18 16:45 ` Jae Hyun Yoo
2018-04-18 16:45 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 05/10] ARM: dts: aspeed: peci: Add PECI node Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-11 11:52 ` Joel Stanley
2018-04-12 2:20 ` Jae Hyun Yoo
2018-04-12 2:20 ` Jae Hyun Yoo
2018-04-12 2:20 ` Jae Hyun Yoo
2018-04-12 2:20 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 06/10] drivers/peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-11 11:51 ` Joel Stanley
2018-04-11 11:51 ` Joel Stanley
2018-04-11 11:51 ` Joel Stanley
2018-04-11 11:51 ` Joel Stanley
2018-04-11 11:51 ` Joel Stanley
2018-04-12 2:03 ` Jae Hyun Yoo
2018-04-12 2:03 ` Jae Hyun Yoo
2018-04-12 2:03 ` Jae Hyun Yoo
2018-04-12 2:03 ` Jae Hyun Yoo
2018-04-17 13:37 ` Robin Murphy
2018-04-17 13:37 ` Robin Murphy
2018-04-17 13:37 ` Robin Murphy
2018-04-17 13:37 ` Robin Murphy
2018-04-17 18:21 ` Jae Hyun Yoo
2018-04-17 18:21 ` Jae Hyun Yoo
2018-04-17 18:21 ` Jae Hyun Yoo
2018-04-17 18:21 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 07/10] Documentation: dt-bindings: Add documents for PECI hwmon client drivers Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-16 18:14 ` Rob Herring
2018-04-16 18:14 ` Rob Herring
2018-04-16 18:14 ` Rob Herring
2018-04-16 18:14 ` Rob Herring
2018-04-16 23:22 ` Jae Hyun Yoo
2018-04-16 23:22 ` Jae Hyun Yoo
2018-04-16 23:22 ` Jae Hyun Yoo
2018-04-16 23:22 ` Jae Hyun Yoo
2018-04-16 23:51 ` Jae Hyun Yoo
2018-04-16 23:51 ` Jae Hyun Yoo
2018-04-16 23:51 ` Jae Hyun Yoo
2018-04-16 23:51 ` Jae Hyun Yoo
2018-04-17 20:40 ` Jae Hyun Yoo
2018-04-17 20:40 ` Jae Hyun Yoo
2018-04-17 20:40 ` Jae Hyun Yoo
2018-04-17 20:40 ` Jae Hyun Yoo
2018-04-18 14:32 ` Rob Herring
2018-04-18 14:32 ` Rob Herring
2018-04-18 14:32 ` Rob Herring
2018-04-18 14:32 ` Rob Herring
2018-04-18 14:32 ` Rob Herring
2018-04-18 20:28 ` Jae Hyun Yoo
2018-04-18 20:28 ` Jae Hyun Yoo
2018-04-18 20:28 ` Jae Hyun Yoo
2018-04-18 20:28 ` Jae Hyun Yoo
2018-04-18 21:28 ` Rob Herring
2018-04-18 21:28 ` Rob Herring
2018-04-18 21:28 ` Rob Herring
2018-04-18 21:28 ` Rob Herring
2018-04-18 21:28 ` Rob Herring
2018-04-18 21:57 ` Jae Hyun Yoo
2018-04-18 21:57 ` Jae Hyun Yoo
2018-04-18 21:57 ` Jae Hyun Yoo
2018-04-18 21:57 ` Jae Hyun Yoo
2018-04-19 19:48 ` Jae Hyun Yoo
2018-04-19 19:48 ` Jae Hyun Yoo
2018-04-19 19:48 ` Jae Hyun Yoo
2018-04-19 19:48 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 08/10] Documentation: hwmon: " Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 09/10] drivers/hwmon: Add " Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 22:28 ` Guenter Roeck
2018-04-10 22:28 ` Guenter Roeck
2018-04-10 22:28 ` Guenter Roeck
2018-04-10 22:28 ` Guenter Roeck
2018-04-11 21:59 ` Jae Hyun Yoo
2018-04-11 21:59 ` Jae Hyun Yoo
2018-04-11 21:59 ` Jae Hyun Yoo
2018-04-11 21:59 ` Jae Hyun Yoo
2018-04-12 0:34 ` Guenter Roeck
2018-04-12 0:34 ` Guenter Roeck
2018-04-12 0:34 ` Guenter Roeck
2018-04-12 0:34 ` Guenter Roeck
2018-04-12 2:51 ` Jae Hyun Yoo
2018-04-12 2:51 ` Jae Hyun Yoo
2018-04-12 2:51 ` Jae Hyun Yoo
2018-04-12 2:51 ` Jae Hyun Yoo
2018-04-12 3:40 ` Guenter Roeck
2018-04-12 3:40 ` Guenter Roeck
2018-04-12 3:40 ` Guenter Roeck
2018-04-12 3:40 ` Guenter Roeck
2018-04-12 17:09 ` Jae Hyun Yoo
2018-04-12 17:09 ` Jae Hyun Yoo
2018-04-12 17:09 ` Jae Hyun Yoo
2018-04-12 17:09 ` Jae Hyun Yoo
2018-04-12 17:37 ` Guenter Roeck
2018-04-12 17:37 ` Guenter Roeck
2018-04-12 17:37 ` Guenter Roeck
2018-04-12 17:37 ` Guenter Roeck
2018-04-12 19:51 ` Jae Hyun Yoo
2018-04-12 19:51 ` Jae Hyun Yoo
2018-04-12 19:51 ` Jae Hyun Yoo
2018-04-12 19:51 ` Jae Hyun Yoo
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 15:56 ` Andy Shevchenko
2018-04-24 16:26 ` Jae Hyun Yoo
2018-04-24 16:26 ` Jae Hyun Yoo
2018-04-24 16:26 ` Jae Hyun Yoo
2018-04-24 16:26 ` Jae Hyun Yoo
2018-04-10 18:32 ` [PATCH v3 10/10] Add a maintainer for the PECI subsystem Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
2018-04-10 18:32 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423105224.GA1444@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=fengguang.wu@intel.com \
--cc=haiyue.wang@linux.intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=james.feist@linux.intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=juliac@eso.teric.us \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=miltonm@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=stef.van.os@prodrive-technologies.com \
--cc=sumeet.r.pawnikar@intel.com \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.