[PATCH] ALSA: control: Fix missing __user annotation

[PATCH] ALSA: control: Fix missing __user annotation

[Takashi Iwai]

There is one place missing __user annotation to the pointer used by
the recent code refactoring.  Reported by sparse.

Fixes: 450296f305f1 ("ALSA: control: code refactoring TLV ioctl handler")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/control.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/control.c b/sound/core/control.c
index 69734b0eafd0..9aa15bfc7936 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1492,7 +1492,7 @@ static int snd_ctl_tlv_ioctl(struct snd_ctl_file *file,
                              int op_flag)
 {
 	struct snd_ctl_tlv header;
-	unsigned int *container;
+	unsigned int __user *container;
 	unsigned int container_size;
 	struct snd_kcontrol *kctl;
 	struct snd_ctl_elem_id id;
-- 
2.16.3

Re: [PATCH] ALSA: control: Fix missing __user annotation

[Takashi Sakamoto]

On Apr 23 2018 22:29, Takashi Iwai wrote:
> There is one place missing __user annotation to the pointer used by
> the recent code refactoring.  Reported by sparse.
> 
> Fixes: 450296f305f1 ("ALSA: control: code refactoring TLV ioctl handler")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>   sound/core/control.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/control.c b/sound/core/control.c
> index 69734b0eafd0..9aa15bfc7936 100644
> --- a/sound/core/control.c
> +++ b/sound/core/control.c
> @@ -1492,7 +1492,7 @@ static int snd_ctl_tlv_ioctl(struct snd_ctl_file *file,
>                                int op_flag)
>   {
>   	struct snd_ctl_tlv header;
> -	unsigned int *container;
> +	unsigned int __user *container;
>   	unsigned int container_size;
>   	struct snd_kcontrol *kctl;
>   	struct snd_ctl_elem_id id;

Indeed. I missed it when posting this change...

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Thanks

Takashi Sakamoto