* master - lvmetad: need to set up bcache in another place
@ 2018-04-23 13:55 David Teigland
0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2018-04-23 13:55 UTC (permalink / raw)
To: lvm-devel
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e351f8bc66d49fecaa0ab78f8413d50a4674604a
Commit: e351f8bc66d49fecaa0ab78f8413d50a4674604a
Parent: 7e33bd1335ba91d6b978df3a39250987d3412116
Author: David Teigland <teigland@redhat.com>
AuthorDate: Tue Mar 6 15:05:27 2018 -0600
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Fri Apr 20 11:22:48 2018 -0500
lvmetad: need to set up bcache in another place
We need to find one common place to set up bcache
for the lvmetad case, instead of adding calls in
various places.
---
lib/label/label.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/lib/label/label.c b/lib/label/label.c
index 82d4bf3..9401067 100644
--- a/lib/label/label.c
+++ b/lib/label/label.c
@@ -675,6 +675,13 @@ int label_scan_devs(struct cmd_context *cmd, struct dm_list *devs)
{
struct device_list *devl;
+ /* FIXME: get rid of this, it's only needed for lvmetad in which
+ case we should be setting up bcache in one place. */
+ if (!scan_bcache) {
+ if (!_setup_bcache(0))
+ return 0;
+ }
+
dm_list_iterate_items(devl, devs) {
if (_in_bcache(devl->dev)) {
bcache_invalidate_fd(scan_bcache, devl->dev->bcache_fd);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* master - lvmetad: need to set up bcache in another place
@ 2018-04-23 13:52 David Teigland
0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2018-04-23 13:52 UTC (permalink / raw)
To: lvm-devel
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e351f8bc66d49fecaa0ab78f8413d50a4674604a
Commit: e351f8bc66d49fecaa0ab78f8413d50a4674604a
Parent: 7e33bd1335ba91d6b978df3a39250987d3412116
Author: David Teigland <teigland@redhat.com>
AuthorDate: Tue Mar 6 15:05:27 2018 -0600
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Fri Apr 20 11:22:48 2018 -0500
lvmetad: need to set up bcache in another place
We need to find one common place to set up bcache
for the lvmetad case, instead of adding calls in
various places.
---
lib/label/label.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/lib/label/label.c b/lib/label/label.c
index 82d4bf3..9401067 100644
--- a/lib/label/label.c
+++ b/lib/label/label.c
@@ -675,6 +675,13 @@ int label_scan_devs(struct cmd_context *cmd, struct dm_list *devs)
{
struct device_list *devl;
+ /* FIXME: get rid of this, it's only needed for lvmetad in which
+ case we should be setting up bcache in one place. */
+ if (!scan_bcache) {
+ if (!_setup_bcache(0))
+ return 0;
+ }
+
dm_list_iterate_items(devl, devs) {
if (_in_bcache(devl->dev)) {
bcache_invalidate_fd(scan_bcache, devl->dev->bcache_fd);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-23 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 13:55 master - lvmetad: need to set up bcache in another place David Teigland
-- strict thread matches above, loose matches on Subject: below --
2018-04-23 13:52 David Teigland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.