From: Andres Rodriguez <andresx7@gmail.com> To: linux-kernel@vger.kernel.org Cc: andresx7@gmail.com, gregkh@linuxfoundation.org, mcgrof@kernel.org, alexdeucher@gmail.com, christian.koenig@amd.com, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com Subject: [PATCH 4/9] firmware: use () to terminate kernel-doc function names Date: Mon, 23 Apr 2018 16:12:00 -0400 [thread overview] Message-ID: <20180423201205.20533-5-andresx7@gmail.com> (raw) In-Reply-To: <20180423201205.20533-1-andresx7@gmail.com> The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andresx7@gmail.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> --- drivers/base/firmware_loader/fallback.c | 8 ++++---- drivers/base/firmware_loader/main.c | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index ecc49a619298..e75928458489 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -124,7 +124,7 @@ static ssize_t timeout_show(struct class *class, struct class_attribute *attr, } /** - * firmware_timeout_store - set number of seconds to wait for firmware + * firmware_timeout_store() - set number of seconds to wait for firmware * @class: device class pointer * @attr: device attribute pointer * @buf: buffer to scan for timeout value @@ -238,7 +238,7 @@ static int map_fw_priv_pages(struct fw_priv *fw_priv) } /** - * firmware_loading_store - set value in the 'loading' control file + * firmware_loading_store() - set value in the 'loading' control file * @dev: device pointer * @attr: device attribute pointer * @buf: buffer to scan for loading control value @@ -430,7 +430,7 @@ static int fw_realloc_pages(struct fw_sysfs *fw_sysfs, int min_size) } /** - * firmware_data_write - write method for firmware + * firmware_data_write() - write method for firmware * @filp: open sysfs file * @kobj: kobject for the device * @bin_attr: bin_attr structure @@ -536,7 +536,7 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, } /** - * fw_load_sysfs_fallback - load a firmware via the sysfs fallback mechanism + * fw_load_sysfs_fallback() - load a firmware via the sysfs fallback mechanism * @fw_sysfs: firmware sysfs information for the firmware to load * @opt_flags: flags of options, FW_OPT_* * @timeout: timeout to wait for the load diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 5baadad3012d..d028cd3257f7 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -597,7 +597,7 @@ _firmware_request(const struct firmware **firmware_p, const char *name, } /** - * firmware_request: - send firmware request and wait for it + * firmware_request() - send firmware request and wait for it * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -632,7 +632,7 @@ firmware_request(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request); /** - * firmware_request_direct: - load firmware directly without usermode helper + * firmware_request_direct() - load firmware directly without usermode helper * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -657,7 +657,7 @@ int firmware_request_direct(const struct firmware **firmware_p, EXPORT_SYMBOL_GPL(firmware_request_direct); /** - * firmware_request_cache: - cache firmware for suspend so resume can use it + * firmware_request_cache() - cache firmware for suspend so resume can use it * @name: name of firmware file * @device: device for which firmware should be cached for * @@ -681,7 +681,7 @@ int firmware_request_cache(struct device *device, const char *name) EXPORT_SYMBOL_GPL(firmware_request_cache); /** - * firmware_request_into_buf - load firmware into a previously allocated buffer + * firmware_request_into_buf() - load firmware into a previously allocated buffer * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded and DMA region allocated @@ -713,7 +713,7 @@ firmware_request_into_buf(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request_into_buf); /** - * firmware_release: - release the resource associated with a firmware image + * firmware_release() - release the resource associated with a firmware image * @fw: firmware resource to release **/ void firmware_release(const struct firmware *fw) @@ -755,7 +755,7 @@ static void firmware_request_work_func(struct work_struct *work) } /** - * firmware_request_nowait - asynchronous version of firmware_request + * firmware_request_nowait() - asynchronous version of firmware_request * @module: module requesting the firmware * @uevent: sends uevent to copy the firmware image if this flag * is non-zero else the firmware copy must be done manually. @@ -824,7 +824,7 @@ EXPORT_SYMBOL(firmware_request_nowait); static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain); /** - * cache_firmware - cache one firmware image in kernel memory space + * cache_firmware() - cache one firmware image in kernel memory space * @fw_name: the firmware image name * * Cache firmware in kernel memory so that drivers can use it when @@ -866,7 +866,7 @@ static struct fw_priv *lookup_fw_priv(const char *fw_name) } /** - * uncache_firmware - remove one cached firmware image + * uncache_firmware() - remove one cached firmware image * @fw_name: the firmware image name * * Uncache one firmware image which has been cached successfully @@ -1042,7 +1042,7 @@ static void __device_uncache_fw_images(void) } /** - * device_cache_fw_images - cache devices' firmware + * device_cache_fw_images() - cache devices' firmware * * If one device called firmware_request or its nowait version * successfully before, the firmware names are recored into the @@ -1075,7 +1075,7 @@ static void device_cache_fw_images(void) } /** - * device_uncache_fw_images - uncache devices' firmware + * device_uncache_fw_images() - uncache devices' firmware * * uncache all firmwares which have been cached successfully * by device_uncache_fw_images earlier @@ -1092,7 +1092,7 @@ static void device_uncache_fw_images_work(struct work_struct *work) } /** - * device_uncache_fw_images_delay - uncache devices firmwares + * device_uncache_fw_images_delay() - uncache devices firmwares * @delay: number of milliseconds to delay uncache device firmwares * * uncache all devices's firmwares which has been cached successfully -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: Andres Rodriguez <andresx7@gmail.com> To: linux-kernel@vger.kernel.org Cc: arend.vanspriel@broadcom.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com, mcgrof@kernel.org, andresx7@gmail.com, alexdeucher@gmail.com, christian.koenig@amd.com, kvalo@codeaurora.org Subject: [PATCH 4/9] firmware: use () to terminate kernel-doc function names Date: Mon, 23 Apr 2018 16:12:00 -0400 [thread overview] Message-ID: <20180423201205.20533-5-andresx7@gmail.com> (raw) In-Reply-To: <20180423201205.20533-1-andresx7@gmail.com> The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andresx7@gmail.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> --- drivers/base/firmware_loader/fallback.c | 8 ++++---- drivers/base/firmware_loader/main.c | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index ecc49a619298..e75928458489 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -124,7 +124,7 @@ static ssize_t timeout_show(struct class *class, struct class_attribute *attr, } /** - * firmware_timeout_store - set number of seconds to wait for firmware + * firmware_timeout_store() - set number of seconds to wait for firmware * @class: device class pointer * @attr: device attribute pointer * @buf: buffer to scan for timeout value @@ -238,7 +238,7 @@ static int map_fw_priv_pages(struct fw_priv *fw_priv) } /** - * firmware_loading_store - set value in the 'loading' control file + * firmware_loading_store() - set value in the 'loading' control file * @dev: device pointer * @attr: device attribute pointer * @buf: buffer to scan for loading control value @@ -430,7 +430,7 @@ static int fw_realloc_pages(struct fw_sysfs *fw_sysfs, int min_size) } /** - * firmware_data_write - write method for firmware + * firmware_data_write() - write method for firmware * @filp: open sysfs file * @kobj: kobject for the device * @bin_attr: bin_attr structure @@ -536,7 +536,7 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, } /** - * fw_load_sysfs_fallback - load a firmware via the sysfs fallback mechanism + * fw_load_sysfs_fallback() - load a firmware via the sysfs fallback mechanism * @fw_sysfs: firmware sysfs information for the firmware to load * @opt_flags: flags of options, FW_OPT_* * @timeout: timeout to wait for the load diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 5baadad3012d..d028cd3257f7 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -597,7 +597,7 @@ _firmware_request(const struct firmware **firmware_p, const char *name, } /** - * firmware_request: - send firmware request and wait for it + * firmware_request() - send firmware request and wait for it * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -632,7 +632,7 @@ firmware_request(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request); /** - * firmware_request_direct: - load firmware directly without usermode helper + * firmware_request_direct() - load firmware directly without usermode helper * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -657,7 +657,7 @@ int firmware_request_direct(const struct firmware **firmware_p, EXPORT_SYMBOL_GPL(firmware_request_direct); /** - * firmware_request_cache: - cache firmware for suspend so resume can use it + * firmware_request_cache() - cache firmware for suspend so resume can use it * @name: name of firmware file * @device: device for which firmware should be cached for * @@ -681,7 +681,7 @@ int firmware_request_cache(struct device *device, const char *name) EXPORT_SYMBOL_GPL(firmware_request_cache); /** - * firmware_request_into_buf - load firmware into a previously allocated buffer + * firmware_request_into_buf() - load firmware into a previously allocated buffer * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded and DMA region allocated @@ -713,7 +713,7 @@ firmware_request_into_buf(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request_into_buf); /** - * firmware_release: - release the resource associated with a firmware image + * firmware_release() - release the resource associated with a firmware image * @fw: firmware resource to release **/ void firmware_release(const struct firmware *fw) @@ -755,7 +755,7 @@ static void firmware_request_work_func(struct work_struct *work) } /** - * firmware_request_nowait - asynchronous version of firmware_request + * firmware_request_nowait() - asynchronous version of firmware_request * @module: module requesting the firmware * @uevent: sends uevent to copy the firmware image if this flag * is non-zero else the firmware copy must be done manually. @@ -824,7 +824,7 @@ EXPORT_SYMBOL(firmware_request_nowait); static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain); /** - * cache_firmware - cache one firmware image in kernel memory space + * cache_firmware() - cache one firmware image in kernel memory space * @fw_name: the firmware image name * * Cache firmware in kernel memory so that drivers can use it when @@ -866,7 +866,7 @@ static struct fw_priv *lookup_fw_priv(const char *fw_name) } /** - * uncache_firmware - remove one cached firmware image + * uncache_firmware() - remove one cached firmware image * @fw_name: the firmware image name * * Uncache one firmware image which has been cached successfully @@ -1042,7 +1042,7 @@ static void __device_uncache_fw_images(void) } /** - * device_cache_fw_images - cache devices' firmware + * device_cache_fw_images() - cache devices' firmware * * If one device called firmware_request or its nowait version * successfully before, the firmware names are recored into the @@ -1075,7 +1075,7 @@ static void device_cache_fw_images(void) } /** - * device_uncache_fw_images - uncache devices' firmware + * device_uncache_fw_images() - uncache devices' firmware * * uncache all firmwares which have been cached successfully * by device_uncache_fw_images earlier @@ -1092,7 +1092,7 @@ static void device_uncache_fw_images_work(struct work_struct *work) } /** - * device_uncache_fw_images_delay - uncache devices firmwares + * device_uncache_fw_images_delay() - uncache devices firmwares * @delay: number of milliseconds to delay uncache device firmwares * * uncache all devices's firmwares which has been cached successfully -- 2.14.1 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-04-23 20:12 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-23 20:11 [PATCH 0/9] Loading optional firmware v4 Andres Rodriguez 2018-04-23 20:11 ` Andres Rodriguez 2018-04-23 20:11 ` [PATCH 1/9] firmware: some documentation fixes Andres Rodriguez 2018-04-23 20:11 ` Andres Rodriguez 2018-04-25 15:25 ` Greg KH 2018-04-25 15:25 ` Greg KH 2018-04-25 15:26 ` Greg KH 2018-04-25 15:26 ` Greg KH 2018-04-25 16:25 ` [PATCH 1/2] " Andres Rodriguez 2018-04-25 16:25 ` Andres Rodriguez 2018-04-25 16:25 ` [PATCH 2/2] usb: typec: fix formatting errors that cause build breakage Andres Rodriguez 2018-04-25 16:25 ` Andres Rodriguez 2018-04-25 16:35 ` Greg KH 2018-04-25 16:35 ` Greg KH 2018-04-25 16:36 ` [PATCH 1/2] firmware: some documentation fixes Greg KH 2018-04-25 16:36 ` Greg KH 2018-05-03 23:31 ` [PATCH 1/9] " Luis R. Rodriguez 2018-05-03 23:31 ` Luis R. Rodriguez 2018-04-23 20:11 ` [PATCH 2/9] firmware: wrap FW_OPT_* into an enum Andres Rodriguez 2018-04-23 20:11 ` Andres Rodriguez 2018-05-03 23:35 ` Luis R. Rodriguez 2018-05-03 23:35 ` Luis R. Rodriguez 2018-04-23 20:11 ` [PATCH 3/9] firmware: add kernel-doc for enum fw_opt Andres Rodriguez 2018-04-23 20:11 ` Andres Rodriguez 2018-05-03 23:36 ` Luis R. Rodriguez 2018-05-03 23:36 ` Luis R. Rodriguez 2018-04-23 20:12 ` Andres Rodriguez [this message] 2018-04-23 20:12 ` [PATCH 4/9] firmware: use () to terminate kernel-doc function names Andres Rodriguez 2018-05-03 23:37 ` Luis R. Rodriguez 2018-05-03 23:37 ` Luis R. Rodriguez 2018-04-23 20:12 ` [PATCH 5/9] firmware: add function to load firmware without warnings v5 Andres Rodriguez 2018-04-23 20:12 ` Andres Rodriguez 2018-05-03 23:40 ` Luis R. Rodriguez 2018-05-03 23:40 ` Luis R. Rodriguez 2018-05-04 0:00 ` Luis R. Rodriguez 2018-05-04 0:00 ` Luis R. Rodriguez 2018-04-23 20:12 ` [PATCH 6/9] firmware: print firmware name on fallback path Andres Rodriguez 2018-04-23 20:12 ` Andres Rodriguez 2018-05-03 23:42 ` Luis R. Rodriguez 2018-05-03 23:42 ` Luis R. Rodriguez 2018-05-05 2:57 ` Andres Rodriguez 2018-05-05 2:57 ` Andres Rodriguez 2018-05-08 0:20 ` Luis R. Rodriguez 2018-05-08 0:20 ` Luis R. Rodriguez 2018-05-12 8:03 ` Kalle Valo 2018-05-12 8:03 ` Kalle Valo 2018-05-12 8:03 ` Kalle Valo 2018-05-12 9:06 ` Luis R. Rodriguez 2018-05-12 9:06 ` Luis R. Rodriguez 2018-04-23 20:12 ` [PATCH 7/9] firmware: use rename fw_sysfs_fallback to use the firmware_ prefix Andres Rodriguez 2018-04-23 20:12 ` Andres Rodriguez 2018-05-03 23:44 ` Luis R. Rodriguez 2018-05-03 23:44 ` Luis R. Rodriguez 2018-04-23 20:12 ` [PATCH 8/9] ath10k: use request_firmware_nowarn to load firmware Andres Rodriguez 2018-04-23 20:12 ` Andres Rodriguez 2018-04-23 20:12 ` [PATCH 9/9] ath10k: re-enable the firmware fallback mechanism for testmode Andres Rodriguez 2018-04-23 20:12 ` Andres Rodriguez 2018-04-24 5:29 ` Kalle Valo 2018-04-24 5:29 ` Kalle Valo 2018-04-24 5:29 ` Kalle Valo -- strict thread matches above, loose matches on Subject: below -- 2018-04-17 15:32 [PATCH 0/9] Loading optional firmware v3 Andres Rodriguez 2018-04-17 15:33 ` [PATCH 4/9] firmware: use () to terminate kernel-doc function names Andres Rodriguez 2018-04-17 20:56 ` Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180423201205.20533-5-andresx7@gmail.com \ --to=andresx7@gmail.com \ --cc=alexdeucher@gmail.com \ --cc=arend.vanspriel@broadcom.com \ --cc=ath10k@lists.infradead.org \ --cc=christian.koenig@amd.com \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mcgrof@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.