* [PATCH] proc: skip branch in /proc/*/* lookup
@ 2018-04-23 21:39 Alexey Dobriyan
0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2018-04-23 21:39 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Code is structured like this:
for ( ... p < last; p++) {
if (memcmp == 0)
break;
}
if (p >= last)
ERROR
OK
gcc doesn't see that if if lookup succeeds than post loop branch will
never be taken and skip it.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/proc/base.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2485,14 +2485,11 @@ static struct dentry *proc_pident_lookup(struct inode *dir,
for (p = ents; p < last; p++) {
if (p->len != dentry->d_name.len)
continue;
- if (!memcmp(dentry->d_name.name, p->name, p->len))
+ if (!memcmp(dentry->d_name.name, p->name, p->len)) {
+ error = proc_pident_instantiate(dir, dentry, task, p);
break;
+ }
}
- if (p >= last)
- goto out;
-
- error = proc_pident_instantiate(dir, dentry, task, p);
-out:
put_task_struct(task);
out_no_task:
return ERR_PTR(error);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-23 21:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 21:39 [PATCH] proc: skip branch in /proc/*/* lookup Alexey Dobriyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.