All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/kbl: Add KBL GT2 sku
@ 2018-04-23 22:01 matthew.s.atwood
  2018-04-23 22:28 ` matthew.s.atwood
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: matthew.s.atwood @ 2018-04-23 22:01 UTC (permalink / raw)
  To: intel-gfx

From: Matt Atwood <matthew.s.atwood@intel.com>

Adding a missing GT2 sku discovered off hardware.

Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
---
 include/drm/i915_pciids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 70f0c25..a58a548 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -349,6 +349,7 @@
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
 	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
+	INTEL_VGA_DEVICE(0x591C, info), /* Mobile GT2 */ \
 	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
 	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] drm/i915/kbl: Add KBL GT2 sku
  2018-04-23 22:01 [PATCH] drm/i915/kbl: Add KBL GT2 sku matthew.s.atwood
@ 2018-04-23 22:28 ` matthew.s.atwood
  2018-04-23 23:10   ` Rodrigo Vivi
  2018-04-23 22:40 ` Clint Taylor
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 7+ messages in thread
From: matthew.s.atwood @ 2018-04-23 22:28 UTC (permalink / raw)
  To: intel-gfx, clinton.a.taylor

From: Matt Atwood <matthew.s.atwood@intel.com>

Adding a missing GT2 sku discovered off hardware.

Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Reviewed-by: Clint Taylor <clinton.a.taylor@intel.com>
---
 include/drm/i915_pciids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index 70f0c25..bab70ff 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -349,6 +349,7 @@
 #define INTEL_KBL_GT2_IDS(info)	\
 	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
 	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
+	INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
 	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
 	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/i915/kbl: Add KBL GT2 sku
  2018-04-23 22:01 [PATCH] drm/i915/kbl: Add KBL GT2 sku matthew.s.atwood
  2018-04-23 22:28 ` matthew.s.atwood
@ 2018-04-23 22:40 ` Clint Taylor
  2018-04-23 22:44 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Clint Taylor @ 2018-04-23 22:40 UTC (permalink / raw)
  To: matthew.s.atwood, intel-gfx



On 04/23/2018 03:01 PM, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
>
> Adding a missing GT2 sku discovered off hardware.
>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
>   include/drm/i915_pciids.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 70f0c25..a58a548 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -349,6 +349,7 @@
>   #define INTEL_KBL_GT2_IDS(info)	\
>   	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
>   	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
> +	INTEL_VGA_DEVICE(0x591C, info), /* Mobile GT2 */ \

KBL-R Y 2+2 should actually be labeled as ULX GT2 instead of Mobile GT2. 
Of course this information is conveniently missing from the spec.

With that change:
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>

-Clint


>   	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
>   	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>   	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku
  2018-04-23 22:01 [PATCH] drm/i915/kbl: Add KBL GT2 sku matthew.s.atwood
  2018-04-23 22:28 ` matthew.s.atwood
  2018-04-23 22:40 ` Clint Taylor
@ 2018-04-23 22:44 ` Patchwork
  2018-04-23 23:05 ` ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku (rev2) Patchwork
  2018-04-23 23:54 ` ✗ Fi.CI.IGT: failure " Patchwork
  4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-04-23 22:44 UTC (permalink / raw)
  To: matthew.s.atwood; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/kbl: Add KBL GT2 sku
URL   : https://patchwork.freedesktop.org/series/42144/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4081 -> Patchwork_8778 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42144/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_8778 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       PASS -> DMESG-WARN (fdo#105128)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-ivb-3520m:       PASS -> DMESG-WARN (fdo#106084)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@gem_mmap_gtt@basic-small-bo-tiledx:
      fi-gdg-551:         FAIL (fdo#102575) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    
  fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084


== Participating hosts (35 -> 33) ==

  Additional (1): fi-glk-j4005 
  Missing    (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq 


== Build changes ==

    * Linux: CI_DRM_4081 -> Patchwork_8778

  CI_DRM_4081: fb7048acaac8ece5ebc53f9b748b76cdcef60fa3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4444: dcc44347494231feabc588c2a76998cbc9afdf8c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8778: 9614a8734006963f14240b48edeeced3005f85bc @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4444: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit


== Linux commits ==

9614a8734006 drm/i915/kbl: Add KBL GT2 sku

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8778/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku (rev2)
  2018-04-23 22:01 [PATCH] drm/i915/kbl: Add KBL GT2 sku matthew.s.atwood
                   ` (2 preceding siblings ...)
  2018-04-23 22:44 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-04-23 23:05 ` Patchwork
  2018-04-23 23:54 ` ✗ Fi.CI.IGT: failure " Patchwork
  4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-04-23 23:05 UTC (permalink / raw)
  To: matthew.s.atwood; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/kbl: Add KBL GT2 sku (rev2)
URL   : https://patchwork.freedesktop.org/series/42144/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4081 -> Patchwork_8779 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42144/revisions/2/mbox/

== Known issues ==

  Here are the changes found in Patchwork_8779 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008


== Participating hosts (35 -> 33) ==

  Additional (1): fi-glk-j4005 
  Missing    (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq 


== Build changes ==

    * Linux: CI_DRM_4081 -> Patchwork_8779

  CI_DRM_4081: fb7048acaac8ece5ebc53f9b748b76cdcef60fa3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4444: dcc44347494231feabc588c2a76998cbc9afdf8c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8779: 3f9866f91add309c6b5d9dca6c34b8656d9b0b0c @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4444: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit


== Linux commits ==

3f9866f91add drm/i915/kbl: Add KBL GT2 sku

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8779/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/i915/kbl: Add KBL GT2 sku
  2018-04-23 22:28 ` matthew.s.atwood
@ 2018-04-23 23:10   ` Rodrigo Vivi
  0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-04-23 23:10 UTC (permalink / raw)
  To: matthew.s.atwood; +Cc: intel-gfx

On Mon, Apr 23, 2018 at 03:28:03PM -0700, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
> 
> Adding a missing GT2 sku discovered off hardware.
> 
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> Reviewed-by: Clint Taylor <clinton.a.taylor@intel.com>

pushed to dinq, thanks for patch and review.

> ---
>  include/drm/i915_pciids.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index 70f0c25..bab70ff 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -349,6 +349,7 @@
>  #define INTEL_KBL_GT2_IDS(info)	\
>  	INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
>  	INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
> +	INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
>  	INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
>  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* ✗ Fi.CI.IGT: failure for drm/i915/kbl: Add KBL GT2 sku (rev2)
  2018-04-23 22:01 [PATCH] drm/i915/kbl: Add KBL GT2 sku matthew.s.atwood
                   ` (3 preceding siblings ...)
  2018-04-23 23:05 ` ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku (rev2) Patchwork
@ 2018-04-23 23:54 ` Patchwork
  4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-04-23 23:54 UTC (permalink / raw)
  To: matthew.s.atwood; +Cc: intel-gfx

== Series Details ==

Series: drm/i915/kbl: Add KBL GT2 sku (rev2)
URL   : https://patchwork.freedesktop.org/series/42144/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4081_full -> Patchwork_8779_full =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_8779_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_8779_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42144/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_8779_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
      shard-apl:          PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd2:
      shard-kbl:          PASS -> SKIP

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          SKIP -> PASS +2

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
      shard-hsw:          SKIP -> PASS

    igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
      shard-glk:          SKIP -> PASS +37

    igt@kms_vblank@pipe-b-wait-forked-busy-hang:
      shard-glk:          PASS -> SKIP +48

    
== Known issues ==

  Here are the changes found in Patchwork_8779_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@mock_breadcrumbs:
      shard-snb:          NOTRUN -> DMESG-FAIL (fdo#106085)

    igt@drv_selftest@mock_scatterlist:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#103667)

    igt@gem_eio@in-flight-suspend:
      shard-snb:          PASS -> DMESG-WARN (fdo#102365)

    igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
      shard-hsw:          PASS -> FAIL (fdo#104873)

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#103928)

    igt@kms_flip@dpms-vs-vblank-race-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#102887)

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-kbl:          PASS -> FAIL (fdo#100368)

    igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
      shard-kbl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602) +10

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-no-display:
      shard-snb:          DMESG-FAIL -> PASS

    igt@drv_selftest@mock_sanitycheck:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-hsw:          FAIL (fdo#105707) -> PASS

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS +1

    igt@kms_hdmi_inject@inject-audio:
      shard-glk:          FAIL (fdo#102370) -> PASS

    igt@kms_rotation_crc@primary-rotation-90:
      shard-kbl:          FAIL (fdo#103925) -> PASS

    igt@perf_pmu@interrupts-sync:
      shard-glk:          FAIL (fdo#104485) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
  fdo#102370 https://bugs.freedesktop.org/show_bug.cgi?id=102370
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103667 https://bugs.freedesktop.org/show_bug.cgi?id=103667
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#104485 https://bugs.freedesktop.org/show_bug.cgi?id=104485
  fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105707 https://bugs.freedesktop.org/show_bug.cgi?id=105707
  fdo#106085 https://bugs.freedesktop.org/show_bug.cgi?id=106085


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-glkb 


== Build changes ==

    * Linux: CI_DRM_4081 -> Patchwork_8779

  CI_DRM_4081: fb7048acaac8ece5ebc53f9b748b76cdcef60fa3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4444: dcc44347494231feabc588c2a76998cbc9afdf8c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8779: 3f9866f91add309c6b5d9dca6c34b8656d9b0b0c @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4444: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8779/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-04-23 23:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 22:01 [PATCH] drm/i915/kbl: Add KBL GT2 sku matthew.s.atwood
2018-04-23 22:28 ` matthew.s.atwood
2018-04-23 23:10   ` Rodrigo Vivi
2018-04-23 22:40 ` Clint Taylor
2018-04-23 22:44 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-23 23:05 ` ✓ Fi.CI.BAT: success for drm/i915/kbl: Add KBL GT2 sku (rev2) Patchwork
2018-04-23 23:54 ` ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.