[PATCH 00/10] arm64: renesas: enable HDMI sound on Salvator

[PATCH 00/10] arm64: renesas: enable HDMI sound on Salvator

[Kuninori Morimoto]

Hi Simon

These patches enable HDMI sound on R-Car Salvator boards on H3/M3.
Basically, HDMI sound support on "driver side" was already supported,
but I didn't posted "DT side" patches, because it needed to confirm
business relationship. Now it be cleared.

But, unfortunately, DT "full_name" behavior was exchanged from v4.15.
And driver assumeed that DT is using numerical suffixes, but this idea
was rejected. Because of these reasons, it needs below patch.
Simon, can you consider these patches on below ?

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git :: for-4.18

9ff7386656f5b7d9524ab7bdf69d508d14800d42
("ASoC: rsnd: don't assume node full path name for HDMI probing")

1)       : only for renesas, not for upstream
2)       : for defconfig
3) - 10) : based on 9ff7386656f5b7d9524ab7bdf69d508d14800d42

Kuninori Morimoto (10):
   1) arm64: renesas_defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD
   2) arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD
   3) arm64: dts: renesas: r8a7795: add HDMI sound support
   4) arm64: dts: renesas: r8a7796: add HDMI sound support
   5) arm64: dts: renesas: salvator-common: use audio-graph-card for Sound
   6) arm64: dts: renesas: r8a7795-es1-salvator-x: enable HDMI sound
   7) arm64: dts: renesas: r8a7795-salvator-xs: enable HDMI sound
   8) arm64: dts: renesas: r8a7796-salvator-xs: enable HDMI sound
   9) arm64: dts: renesas: r8a7795-salvator-x: enable HDMI sound
  10) arm64: dts: renesas: r8a7796-salvator-x: enable HDMI sound

 .../boot/dts/renesas/r8a7795-es1-salvator-x.dts    | 46 ++++++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 46 ++++++++++++++++++++++
 .../arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 46 ++++++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a7795.dtsi           |  8 ++++
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 28 +++++++++++++
 .../arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 28 +++++++++++++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi           |  4 ++
 arch/arm64/boot/dts/renesas/salvator-common.dtsi   | 38 ++++++++++--------
 arch/arm64/configs/defconfig                       |  1 +
 arch/arm64/configs/renesas_defconfig               |  1 +
 10 files changed, 230 insertions(+), 16 deletions(-)

-- 
1.9.1

[PATCH 01/10] arm64: renesas_defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/configs/renesas_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/renesas_defconfig b/arch/arm64/configs/renesas_defconfig
index 6f3f965..c27ab6f5 100644
--- a/arch/arm64/configs/renesas_defconfig
+++ b/arch/arm64/configs/renesas_defconfig
@@ -227,6 +227,7 @@ CONFIG_SND_SOC=y
 CONFIG_SND_SOC_RCAR=y
 CONFIG_SND_SOC_AK4613=y
 CONFIG_SND_SIMPLE_CARD=y
+CONFIG_SND_AUDIO_GRAPH_CARD=y
 CONFIG_USB=y
 CONFIG_USB_OTG=y
 CONFIG_USB_XHCI_HCD=y
-- 
1.9.1

[PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index ecf6137..66b4638 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
 CONFIG_SND_SOC_RCAR=m
 CONFIG_SND_SOC_AK4613=m
 CONFIG_SND_SIMPLE_CARD=y
+CONFIG_SND_AUDIO_GRAPH_CARD=y
 CONFIG_USB=y
 CONFIG_USB_OTG=y
 CONFIG_USB_XHCI_HCD=y
-- 
1.9.1

[PATCH 03/10] arm64: dts: renesas: r8a7795: add HDMI sound support

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 5ae85d8..2b83c4ad 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -2736,6 +2736,10 @@
 				port@1 {
 					reg = <1>;
 				};
+				port@2 {
+					/* HDMI sound */
+					reg = <2>;
+				};
 			};
 		};
 
@@ -2761,6 +2765,10 @@
 				port@1 {
 					reg = <1>;
 				};
+				port@2 {
+					/* HDMI sound */
+					reg = <2>;
+				};
 			};
 		};
 
-- 
1.9.1

[PATCH 04/10] arm64: dts: renesas: r8a7796: add HDMI sound support

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 599c74d..732f1ce 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -2380,6 +2380,10 @@
 				port@1 {
 					reg = <1>;
 				};
+				port@2 {
+					/* HDMI sound */
+					reg = <2>;
+				};
 			};
 		};
 
-- 
1.9.1

[PATCH 05/10] arm64: dts: renesas: salvator-common: use audio-graph-card for Sound

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current Sound is using simple-audio-card which can't support HDMI.
To use HDMI sound, we need to use audio-graph-card.
But, one note is that r8a7795 has 2 HDMI ports, but r8a7796 has 1.
Because of this mismatch, supporting HDMI on salvator-common is
impossible.
Thus, this patch exchange sound card to audio-graph-card and keep
supporting ak4613 as 1st sound node.
r8a7795/r8a7796 salvator-x{s} need to add HDMI sound individually.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 38 ++++++++++++++----------
 1 file changed, 22 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index b5b9b83..8add664 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -116,20 +116,12 @@
 		regulator-always-on;
 	};
 
-	rsnd_ak4613: sound {
-		compatible = "simple-audio-card";
+	sound_card: sound {
+		compatible = "audio-graph-card";
 
-		simple-audio-card,format = "left_j";
-		simple-audio-card,bitclock-master = <&sndcpu>;
-		simple-audio-card,frame-master = <&sndcpu>;
+		label = "rcar-sound";
 
-		sndcpu: simple-audio-card,cpu {
-			sound-dai = <&rcar_sound>;
-		};
-
-		sndcodec: simple-audio-card,codec {
-			sound-dai = <&ak4613>;
-		};
+		dais = <&rsnd_port0>;
 	};
 
 	vbus0_usb2: regulator-vbus0-usb2 {
@@ -376,6 +368,12 @@
 		asahi-kasei,out4-single-end;
 		asahi-kasei,out5-single-end;
 		asahi-kasei,out6-single-end;
+
+		port {
+			ak4613_endpoint: endpoint {
+				remote-endpoint = <&rsnd_endpoint0>;
+			};
+		};
 	};
 
 	cs2000: clk_multiplier@4f {
@@ -686,10 +684,18 @@
 		 <&audio_clk_c>,
 		 <&cpg CPG_CORE CPG_AUDIO_CLK_I>;
 
-	rcar_sound,dai {
-		dai0 {
-			playback = <&ssi0 &src0 &dvc0>;
-			capture  = <&ssi1 &src1 &dvc1>;
+	ports {
+		rsnd_port0: port@0 {
+			rsnd_endpoint0: endpoint {
+				remote-endpoint = <&ak4613_endpoint>;
+
+				dai-format = "left_j";
+				bitclock-master = <&rsnd_endpoint0>;
+				frame-master = <&rsnd_endpoint0>;
+
+				playback = <&ssi0 &src0 &dvc0>;
+				capture  = <&ssi1 &src1 &dvc1>;
+			};
 		};
 	};
 };
-- 
1.9.1

[PATCH 06/10] arm64: dts: renesas: r8a7795-es1-salvator-x: enable HDMI sound

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 .../boot/dts/renesas/r8a7795-es1-salvator-x.dts    | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
index 7f2a3d9..3f46345 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-es1-salvator-x.dts
@@ -56,6 +56,12 @@
 	status = "okay";
 };
 
+&sound_card {
+	dais = <&rsnd_port0	/* ak4613 */
+		&rsnd_port1	/* HDMI0  */
+		&rsnd_port2>;	/* HDMI1  */
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -66,6 +72,12 @@
 				remote-endpoint = <&hdmi0_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi0_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint1>;
+			};
+		};
 	};
 };
 
@@ -83,6 +95,12 @@
 				remote-endpoint = <&hdmi1_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi1_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint2>;
+			};
+		};
 	};
 };
 
@@ -94,6 +112,34 @@
 	status = "okay";
 };
 
+&rcar_sound {
+	ports {
+		/* rsnd_port0 is on salvator-common */
+		rsnd_port1: port@1 {
+			rsnd_endpoint1: endpoint {
+				remote-endpoint = <&dw_hdmi0_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint1>;
+				frame-master = <&rsnd_endpoint1>;
+
+				playback = <&ssi2>;
+			};
+		};
+		rsnd_port2: port@2 {
+			rsnd_endpoint2: endpoint {
+				remote-endpoint = <&dw_hdmi1_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint2>;
+				frame-master = <&rsnd_endpoint2>;
+
+				playback = <&ssi3>;
+			};
+		};
+	};
+};
+
 &pfc {
 	usb2_pins: usb2 {
 		groups = "usb2";
-- 
1.9.1

[PATCH 07/10] arm64: dts: renesas: r8a7795-salvator-xs: enable HDMI sound

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 .../arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index 8b50ceb..8367668 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -56,6 +56,12 @@
 	status = "okay";
 };
 
+&sound_card {
+	dais = <&rsnd_port0	/* ak4613 */
+		&rsnd_port1	/* HDMI0  */
+		&rsnd_port2>;	/* HDMI1  */
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -66,6 +72,12 @@
 				remote-endpoint = <&hdmi0_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi0_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint1>;
+			};
+		};
 	};
 };
 
@@ -83,6 +95,12 @@
 				remote-endpoint = <&hdmi1_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi1_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint2>;
+			};
+		};
 	};
 };
 
@@ -94,6 +112,34 @@
 	status = "okay";
 };
 
+&rcar_sound {
+	ports {
+		/* rsnd_port0 is on salvator-common */
+		rsnd_port1: port@1 {
+			rsnd_endpoint1: endpoint {
+				remote-endpoint = <&dw_hdmi0_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint1>;
+				frame-master = <&rsnd_endpoint1>;
+
+				playback = <&ssi2>;
+			};
+		};
+		rsnd_port2: port@2 {
+			rsnd_endpoint2: endpoint {
+				remote-endpoint = <&dw_hdmi1_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint2>;
+				frame-master = <&rsnd_endpoint2>;
+
+				playback = <&ssi3>;
+			};
+		};
+	};
+};
+
 &pfc {
 	usb2_pins: usb2 {
 		groups = "usb2";
-- 
1.9.1

[PATCH 08/10] arm64: dts: renesas: r8a7796-salvator-xs: enable HDMI sound

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 .../arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
index 2c37055..ddf35d4 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts
@@ -40,6 +40,11 @@
 		      "dclkin.0", "dclkin.1", "dclkin.2";
 };
 
+&sound_card {
+	dais = <&rsnd_port0	/* ak4613 */
+		&rsnd_port1>;	/* HDMI0  */
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -50,9 +55,32 @@
 				remote-endpoint = <&hdmi0_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi0_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint1>;
+			};
+		};
 	};
 };
 
 &hdmi0_con {
 	remote-endpoint = <&rcar_dw_hdmi0_out>;
 };
+
+&rcar_sound {
+	ports {
+		/* rsnd_port0 is on salvator-common */
+		rsnd_port1: port@1 {
+			rsnd_endpoint1: endpoint {
+				remote-endpoint = <&dw_hdmi0_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint1>;
+				frame-master = <&rsnd_endpoint1>;
+
+				playback = <&ssi2>;
+			};
+		};
+	};
+};
-- 
1.9.1

[PATCH 09/10] arm64: dts: renesas: r8a7795-salvator-x: enable HDMI sound

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index af46741..0efbef5 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -56,6 +56,12 @@
 	status = "okay";
 };
 
+&sound_card {
+	dais = <&rsnd_port0	/* ak4613 */
+		&rsnd_port1	/* HDMI0  */
+		&rsnd_port2>;	/* HDMI1  */
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -66,6 +72,12 @@
 				remote-endpoint = <&hdmi0_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi0_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint1>;
+			};
+		};
 	};
 };
 
@@ -83,6 +95,12 @@
 				remote-endpoint = <&hdmi1_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi1_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint2>;
+			};
+		};
 	};
 };
 
@@ -94,6 +112,34 @@
 	status = "okay";
 };
 
+&rcar_sound {
+	ports {
+		/* rsnd_port0 is on salvator-common */
+		rsnd_port1: port@1 {
+			rsnd_endpoint1: endpoint {
+				remote-endpoint = <&dw_hdmi0_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint1>;
+				frame-master = <&rsnd_endpoint1>;
+
+				playback = <&ssi2>;
+			};
+		};
+		rsnd_port2: port@2 {
+			rsnd_endpoint2: endpoint {
+				remote-endpoint = <&dw_hdmi1_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint2>;
+				frame-master = <&rsnd_endpoint2>;
+
+				playback = <&ssi3>;
+			};
+		};
+	};
+};
+
 &pfc {
 	usb2_pins: usb2 {
 		groups = "usb2";
-- 
1.9.1

[PATCH 10/10] arm64: dts: renesas: r8a7796-salvator-x: enable HDMI sound

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index 498c9e8..90cca09 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -40,6 +40,11 @@
 		      "dclkin.0", "dclkin.1", "dclkin.2";
 };
 
+&sound_card {
+	dais = <&rsnd_port0	/* ak4613 */
+		&rsnd_port1>;	/* HDMI0  */
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -50,9 +55,32 @@
 				remote-endpoint = <&hdmi0_con>;
 			};
 		};
+		port@2 {
+			reg = <2>;
+			dw_hdmi0_snd_in: endpoint {
+				remote-endpoint = <&rsnd_endpoint1>;
+			};
+		};
 	};
 };
 
 &hdmi0_con {
 	remote-endpoint = <&rcar_dw_hdmi0_out>;
 };
+
+&rcar_sound {
+	ports {
+		/* rsnd_port0 is on salvator-common */
+		rsnd_port1: port@1 {
+			rsnd_endpoint1: endpoint {
+				remote-endpoint = <&dw_hdmi0_snd_in>;
+
+				dai-format = "i2s";
+				bitclock-master = <&rsnd_endpoint1>;
+				frame-master = <&rsnd_endpoint1>;
+
+				playback = <&ssi2>;
+			};
+		};
+	};
+};
-- 
1.9.1

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Geert Uytterhoeven]

Hi Morimoto-san,

On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>

Thanks for your patch!

> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
>  CONFIG_SND_SOC_RCAR=m
>  CONFIG_SND_SOC_AK4613=m
>  CONFIG_SND_SIMPLE_CARD=y
> +CONFIG_SND_AUDIO_GRAPH_CARD=y

Perhaps "m"?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Simon Horman]

On Mon, Apr 23, 2018 at 10:01:51AM +0200, Geert Uytterhoeven wrote:
> Hi Morimoto-san,
> 
> On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> >
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
> >  CONFIG_SND_SOC_RCAR=m
> >  CONFIG_SND_SOC_AK4613=m
> >  CONFIG_SND_SIMPLE_CARD=y
> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
> 
> Perhaps "m"?

Hi Geert,

do you plan to review the rest of the series?

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Geert Uytterhoeven]

Hi Simon,

On Tue, Apr 24, 2018 at 11:27 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Apr 23, 2018 at 10:01:51AM +0200, Geert Uytterhoeven wrote:
>> On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
>> <kuninori.morimoto.gx@renesas.com> wrote:
>> >
>> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> >
>> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
>>
>> Thanks for your patch!
>>
>> > --- a/arch/arm64/configs/defconfig
>> > +++ b/arch/arm64/configs/defconfig
>> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
>> >  CONFIG_SND_SOC_RCAR=m
>> >  CONFIG_SND_SOC_AK4613=m
>> >  CONFIG_SND_SIMPLE_CARD=y
>> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
>>
>> Perhaps "m"?
>
> Hi Geert,
>
> do you plan to review the rest of the series?

No, I'm too scared of audio.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Simon Horman]

On Tue, Apr 24, 2018 at 11:31:14AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Apr 24, 2018 at 11:27 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Apr 23, 2018 at 10:01:51AM +0200, Geert Uytterhoeven wrote:
> >> On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
> >> <kuninori.morimoto.gx@renesas.com> wrote:
> >> >
> >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> >
> >> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> >> >
> >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/arch/arm64/configs/defconfig
> >> > +++ b/arch/arm64/configs/defconfig
> >> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
> >> >  CONFIG_SND_SOC_RCAR=m
> >> >  CONFIG_SND_SOC_AK4613=m
> >> >  CONFIG_SND_SIMPLE_CARD=y
> >> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
> >>
> >> Perhaps "m"?
> >
> > Hi Geert,
> >
> > do you plan to review the rest of the series?
> 
> No, I'm too scared of audio.

No problem, just wondering if I should wait. I won't.

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Simon Horman]

On Mon, Apr 23, 2018 at 10:01:51AM +0200, Geert Uytterhoeven wrote:
> Hi Morimoto-san,
> 
> On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> >
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
> >  CONFIG_SND_SOC_RCAR=m
> >  CONFIG_SND_SOC_AK4613=m
> >  CONFIG_SND_SIMPLE_CARD=y
> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
> 
> Perhaps "m"?

Do you suggest the same for renesas_defconfig?
That is, patch 2/10?

Re: [PATCH 00/10] arm64: renesas: enable HDMI sound on Salvator

[Simon Horman]

On Mon, Apr 23, 2018 at 01:35:59AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> These patches enable HDMI sound on R-Car Salvator boards on H3/M3.
> Basically, HDMI sound support on "driver side" was already supported,
> but I didn't posted "DT side" patches, because it needed to confirm
> business relationship. Now it be cleared.
> 
> But, unfortunately, DT "full_name" behavior was exchanged from v4.15.
> And driver assumeed that DT is using numerical suffixes, but this idea
> was rejected. Because of these reasons, it needs below patch.
> Simon, can you consider these patches on below ?
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git :: for-4.18
> 
> 9ff7386656f5b7d9524ab7bdf69d508d14800d42
> ("ASoC: rsnd: don't assume node full path name for HDMI probing")
> 
> 1)       : only for renesas, not for upstream
> 2)       : for defconfig
> 3) - 10) : based on 9ff7386656f5b7d9524ab7bdf69d508d14800d42
> 
> Kuninori Morimoto (10):
>    1) arm64: renesas_defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD
>    2) arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

Geert has some comments regarding patch 1 which may also apply to patch 2.
Lets sort that out one way or another.

>    3) arm64: dts: renesas: r8a7795: add HDMI sound support
>    4) arm64: dts: renesas: r8a7796: add HDMI sound support
>    5) arm64: dts: renesas: salvator-common: use audio-graph-card for Sound
>    6) arm64: dts: renesas: r8a7795-es1-salvator-x: enable HDMI sound
>    7) arm64: dts: renesas: r8a7795-salvator-xs: enable HDMI sound
>    8) arm64: dts: renesas: r8a7796-salvator-xs: enable HDMI sound
>    9) arm64: dts: renesas: r8a7795-salvator-x: enable HDMI sound
>   10) arm64: dts: renesas: r8a7796-salvator-x: enable HDMI sound

Patches 3 - 10 applied, thanks!

> 
>  .../boot/dts/renesas/r8a7795-es1-salvator-x.dts    | 46 ++++++++++++++++++++++
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 46 ++++++++++++++++++++++
>  .../arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 46 ++++++++++++++++++++++
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi           |  8 ++++
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 28 +++++++++++++
>  .../arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 28 +++++++++++++
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi           |  4 ++
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi   | 38 ++++++++++--------
>  arch/arm64/configs/defconfig                       |  1 +
>  arch/arm64/configs/renesas_defconfig               |  1 +
>  10 files changed, 230 insertions(+), 16 deletions(-)
> 
> -- 
> 1.9.1
> 

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Geert Uytterhoeven]

Hi Simon,

On Tue, Apr 24, 2018 at 11:36 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Apr 23, 2018 at 10:01:51AM +0200, Geert Uytterhoeven wrote:
>> On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
>> <kuninori.morimoto.gx@renesas.com> wrote:
>> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> >
>> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
>> >
>> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
>>
>> Thanks for your patch!
>>
>> > --- a/arch/arm64/configs/defconfig
>> > +++ b/arch/arm64/configs/defconfig
>> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
>> >  CONFIG_SND_SOC_RCAR=m
>> >  CONFIG_SND_SOC_AK4613=m
>> >  CONFIG_SND_SIMPLE_CARD=y
>> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
>>
>> Perhaps "m"?
>
> Do you suggest the same for renesas_defconfig?
> That is, patch 2/10?

No. For {shmobile,renesas}_defconfig we make everything builtin.
For {multi_v7,arm64}_defconfig, we usually make non-critical devices modular.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Kuninori Morimoto]

Hi Geert

Thank for your review.

> >> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> >> >
> >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/arch/arm64/configs/defconfig
> >> > +++ b/arch/arm64/configs/defconfig
> >> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
> >> >  CONFIG_SND_SOC_RCAR=m
> >> >  CONFIG_SND_SOC_AK4613=m
> >> >  CONFIG_SND_SIMPLE_CARD=y
> >> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
> >>
> >> Perhaps "m"?
> >
> > Do you suggest the same for renesas_defconfig?
> > That is, patch 2/10?
> 
> No. For {shmobile,renesas}_defconfig we make everything builtin.
> For {multi_v7,arm64}_defconfig, we usually make non-critical devices modular.

Yeah.
CONFIG_SND_AUDIO_GRAPH_CARD is similar driver to CONFIG_SND_SIMPLE_CARD
But it has =y on defconfig, thus, I used same style.
If it should be =m, then, we need +1 patch which modifes CONFIG_SND_SIMPLE_CARD, too.


Best regards
---
Kuninori Morimoto

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Simon Horman]

On Tue, Apr 24, 2018 at 11:53:15AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Apr 24, 2018 at 11:36 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Apr 23, 2018 at 10:01:51AM +0200, Geert Uytterhoeven wrote:
> >> On Mon, Apr 23, 2018 at 3:39 AM, Kuninori Morimoto
> >> <kuninori.morimoto.gx@renesas.com> wrote:
> >> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> >
> >> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> >> >
> >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> >>
> >> Thanks for your patch!
> >>
> >> > --- a/arch/arm64/configs/defconfig
> >> > +++ b/arch/arm64/configs/defconfig
> >> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
> >> >  CONFIG_SND_SOC_RCAR=m
> >> >  CONFIG_SND_SOC_AK4613=m
> >> >  CONFIG_SND_SIMPLE_CARD=y
> >> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
> >>
> >> Perhaps "m"?
> >
> > Do you suggest the same for renesas_defconfig?
> > That is, patch 2/10?
> 
> No. For {shmobile,renesas}_defconfig we make everything builtin.
> For {multi_v7,arm64}_defconfig, we usually make non-critical devices modular.

Thanks, that makes sense to me.

Re: [PATCH 01/10] arm64: renesas_defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Simon Horman]

On Mon, Apr 23, 2018 at 01:39:01AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>

Thanks, applied.

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Simon Horman]

On Wed, Apr 25, 2018 at 12:13:07AM +0000, Kuninori Morimoto wrote:
> 
> Hi Geert
> 
> Thank for your review.
> 
> > >> > CONFIG_SND_AUDIO_GRAPH_CARD is needed to use HDMI sound with video
> > >> >
> > >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >> > Tested-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> > >>
> > >> Thanks for your patch!
> > >>
> > >> > --- a/arch/arm64/configs/defconfig
> > >> > +++ b/arch/arm64/configs/defconfig
> > >> > @@ -440,6 +440,7 @@ CONFIG_SND_SOC_SAMSUNG=y
> > >> >  CONFIG_SND_SOC_RCAR=m
> > >> >  CONFIG_SND_SOC_AK4613=m
> > >> >  CONFIG_SND_SIMPLE_CARD=y
> > >> > +CONFIG_SND_AUDIO_GRAPH_CARD=y
> > >>
> > >> Perhaps "m"?
> > >
> > > Do you suggest the same for renesas_defconfig?
> > > That is, patch 2/10?
> > 
> > No. For {shmobile,renesas}_defconfig we make everything builtin.
> > For {multi_v7,arm64}_defconfig, we usually make non-critical devices modular.
> 
> Yeah.
> CONFIG_SND_AUDIO_GRAPH_CARD is similar driver to CONFIG_SND_SIMPLE_CARD
> But it has =y on defconfig, thus, I used same style.
> If it should be =m, then, we need +1 patch which modifes CONFIG_SND_SIMPLE_CARD, too.

I think that would be ideal.

Re: [PATCH 02/10] arm64: defconfig: Enable CONFIG_SND_AUDIO_GRAPH_CARD

[Kuninori Morimoto]

Hi Simon

> > > No. For {shmobile,renesas}_defconfig we make everything builtin.
> > > For {multi_v7,arm64}_defconfig, we usually make non-critical devices modular.
> > 
> > Yeah.
> > CONFIG_SND_AUDIO_GRAPH_CARD is similar driver to CONFIG_SND_SIMPLE_CARD
> > But it has =y on defconfig, thus, I used same style.
> > If it should be =m, then, we need +1 patch which modifes CONFIG_SND_SIMPLE_CARD, too.
> 
> I think that would be ideal.

OK, will do