* [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages
@ 2018-04-24 11:52 Chris Wilson
2018-04-24 12:07 ` Tvrtko Ursulin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-04-24 11:52 UTC (permalink / raw)
To: intel-gfx
Knowing the offset of the per-engine scratch/HWS page during boot is not
very informative, so remove the DRM_DEBUG.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_engine_cs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index be608f7111f5..7fe0ca8c6c40 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -541,8 +541,6 @@ int intel_engine_create_scratch(struct intel_engine_cs *engine, int size)
goto err_unref;
engine->scratch = vma;
- DRM_DEBUG_DRIVER("%s pipe control offset: 0x%08x\n",
- engine->name, i915_ggtt_offset(vma));
return 0;
err_unref:
@@ -636,9 +634,6 @@ static int init_status_page(struct intel_engine_cs *engine)
engine->status_page.vma = vma;
engine->status_page.ggtt_offset = i915_ggtt_offset(vma);
engine->status_page.page_addr = memset(vaddr, 0, PAGE_SIZE);
-
- DRM_DEBUG_DRIVER("%s hws offset: 0x%08x\n",
- engine->name, i915_ggtt_offset(vma));
return 0;
err_unpin:
--
2.17.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages
2018-04-24 11:52 [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages Chris Wilson
@ 2018-04-24 12:07 ` Tvrtko Ursulin
2018-04-24 12:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-24 15:08 ` ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2018-04-24 12:07 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 24/04/2018 12:52, Chris Wilson wrote:
> Knowing the offset of the per-engine scratch/HWS page during boot is not
> very informative, so remove the DRM_DEBUG.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_engine_cs.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> index be608f7111f5..7fe0ca8c6c40 100644
> --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -541,8 +541,6 @@ int intel_engine_create_scratch(struct intel_engine_cs *engine, int size)
> goto err_unref;
>
> engine->scratch = vma;
> - DRM_DEBUG_DRIVER("%s pipe control offset: 0x%08x\n",
> - engine->name, i915_ggtt_offset(vma));
> return 0;
>
> err_unref:
> @@ -636,9 +634,6 @@ static int init_status_page(struct intel_engine_cs *engine)
> engine->status_page.vma = vma;
> engine->status_page.ggtt_offset = i915_ggtt_offset(vma);
> engine->status_page.page_addr = memset(vaddr, 0, PAGE_SIZE);
> -
> - DRM_DEBUG_DRIVER("%s hws offset: 0x%08x\n",
> - engine->name, i915_ggtt_offset(vma));
> return 0;
>
> err_unpin:
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Skip printing global offsets for per-engine scratch pages
2018-04-24 11:52 [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages Chris Wilson
2018-04-24 12:07 ` Tvrtko Ursulin
@ 2018-04-24 12:57 ` Patchwork
2018-04-24 15:08 ` ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-04-24 12:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Skip printing global offsets for per-engine scratch pages
URL : https://patchwork.freedesktop.org/series/42187/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4084 -> Patchwork_8786 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42187/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8786 that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-skl-6700k2: FAIL (fdo#103191) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
== Participating hosts (36 -> 33) ==
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4084 -> Patchwork_8786
CI_DRM_4084: 45349bde096d69db4d81b55ce2f4b4a48eec4834 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4446: e5e8dafc991ee922ec159491c680caff0cfe9235 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8786: ed86dc572fb05c9f38dfa91162e9099eb0ddea61 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4446: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit
== Linux commits ==
ed86dc572fb0 drm/i915: Skip printing global offsets for per-engine scratch pages
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8786/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✗ Fi.CI.IGT: failure for drm/i915: Skip printing global offsets for per-engine scratch pages
2018-04-24 11:52 [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages Chris Wilson
2018-04-24 12:07 ` Tvrtko Ursulin
2018-04-24 12:57 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-04-24 15:08 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-04-24 15:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Skip printing global offsets for per-engine scratch pages
URL : https://patchwork.freedesktop.org/series/42187/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4084_full -> Patchwork_8786_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_8786_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8786_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42187/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8786_full:
=== IGT changes ===
==== Possible regressions ====
igt@syncobj_wait@wait-all-delayed-signal:
shard-snb: PASS -> FAIL
==== Warnings ====
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: PASS -> SKIP +1
igt@gem_exec_schedule@deep-vebox:
shard-kbl: SKIP -> PASS
igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
shard-glk: PASS -> SKIP +82
igt@kms_mmap_write_crc:
shard-glk: SKIP -> PASS +92
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_8786_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-blt:
shard-kbl: NOTRUN -> FAIL (fdo#103158)
igt@kms_cursor_crc@cursor-64x64-onscreen:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +4
igt@kms_flip@flip-vs-panning-vs-hang-interruptible:
shard-snb: PASS -> DMESG-WARN (fdo#103821)
igt@kms_flip@flip-vs-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#100368) +3
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: SKIP -> FAIL (fdo#100368)
igt@kms_setmode@basic:
shard-hsw: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_eio@in-flight-immediate:
shard-glk: FAIL (fdo#105957) -> PASS
igt@kms_flip@2x-plain-flip-ts-check-interruptible:
shard-hsw: FAIL (fdo#100368) -> PASS +1
igt@kms_flip@flip-vs-dpms-off-vs-modeset:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_flip@modeset-vs-vblank-race:
shard-hsw: FAIL (fdo#103060) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105957 https://bugs.freedesktop.org/show_bug.cgi?id=105957
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 5) ==
Missing (1): shard-glkb
== Build changes ==
* Linux: CI_DRM_4084 -> Patchwork_8786
CI_DRM_4084: 45349bde096d69db4d81b55ce2f4b4a48eec4834 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4446: e5e8dafc991ee922ec159491c680caff0cfe9235 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8786: ed86dc572fb05c9f38dfa91162e9099eb0ddea61 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4446: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8786/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-24 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 11:52 [PATCH] drm/i915: Skip printing global offsets for per-engine scratch pages Chris Wilson
2018-04-24 12:07 ` Tvrtko Ursulin
2018-04-24 12:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-24 15:08 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.