* [PATCH] drm/ast: fix mode_valid's return type
@ 2018-04-24 13:14 Luc Van Oostenryck
2018-04-25 7:07 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Dave Airlie, David Airlie, Daniel Vetter,
Cihangir Akturk, Takashi Iwai, Egbert Eich, Peter Rosin,
dri-devel
The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.
Fix this by using 'enum drm_mode_status' in the driver too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/gpu/drm/ast/ast_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 831b73392..036dff8a1 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -799,7 +799,7 @@ static int ast_get_modes(struct drm_connector *connector)
return 0;
}
-static int ast_mode_valid(struct drm_connector *connector,
+static enum drm_mode_status ast_mode_valid(struct drm_connector *connector,
struct drm_display_mode *mode)
{
struct ast_private *ast = connector->dev->dev_private;
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ast: fix mode_valid's return type
2018-04-24 13:14 [PATCH] drm/ast: fix mode_valid's return type Luc Van Oostenryck
@ 2018-04-25 7:07 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-04-25 7:07 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: linux-kernel, Dave Airlie, David Airlie, Daniel Vetter,
Cihangir Akturk, Takashi Iwai, Egbert Eich, Peter Rosin,
dri-devel
On Tue, Apr 24, 2018 at 03:14:40PM +0200, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/ast/ast_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 831b73392..036dff8a1 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -799,7 +799,7 @@ static int ast_get_modes(struct drm_connector *connector)
> return 0;
> }
>
> -static int ast_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status ast_mode_valid(struct drm_connector *connector,
> struct drm_display_mode *mode)
> {
> struct ast_private *ast = connector->dev->dev_private;
> --
> 2.17.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ast: fix mode_valid's return type
@ 2018-04-25 7:07 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2018-04-25 7:07 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: Egbert Eich, David Airlie, Daniel Vetter, linux-kernel,
dri-devel, Cihangir Akturk, Dave Airlie, Peter Rosin
On Tue, Apr 24, 2018 at 03:14:40PM +0200, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Applied to drm-misc-next, thanks.
-Daniel
> ---
> drivers/gpu/drm/ast/ast_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 831b73392..036dff8a1 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -799,7 +799,7 @@ static int ast_get_modes(struct drm_connector *connector)
> return 0;
> }
>
> -static int ast_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status ast_mode_valid(struct drm_connector *connector,
> struct drm_display_mode *mode)
> {
> struct ast_private *ast = connector->dev->dev_private;
> --
> 2.17.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-25 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] drm/ast: fix mode_valid's return type Luc Van Oostenryck
2018-04-25 7:07 ` Daniel Vetter
2018-04-25 7:07 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.