* [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
@ 2018-04-24 13:14 Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, intel-gfx, dri-devel
All implementations of the method intel_dvo_dev_ops::mode_valid(), as
well as the underlying struct drm_connector_helper_funcs::mode_valid()
use 'enum drm_mode_status' for the method's return type but the
declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
Fix this by using 'enum drm_mode_status' for the declaration too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/gpu/drm/i915/dvo.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
index 5e6a3013d..b6e143ebc 100644
--- a/drivers/gpu/drm/i915/dvo.h
+++ b/drivers/gpu/drm/i915/dvo.h
@@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
*
* \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/
- int (*mode_valid)(struct intel_dvo_device *dvo,
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
struct drm_display_mode *mode);
/*
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
@ 2018-04-24 15:11 ` Jani Nikula
2018-04-24 15:50 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2018-04-24 15:11 UTC (permalink / raw)
To: Luc Van Oostenryck, linux-kernel
Cc: Luc Van Oostenryck, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
intel-gfx, dri-devel
On Tue, 24 Apr 2018, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote:
> All implementations of the method intel_dvo_dev_ops::mode_valid(), as
> well as the underlying struct drm_connector_helper_funcs::mode_valid()
> use 'enum drm_mode_status' for the method's return type but the
> declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' for the declaration too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/gpu/drm/i915/dvo.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
> index 5e6a3013d..b6e143ebc 100644
> --- a/drivers/gpu/drm/i915/dvo.h
> +++ b/drivers/gpu/drm/i915/dvo.h
> @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> struct drm_display_mode *mode);
Please adjust the alignment here as well. With that,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Oh, and as far as lists go, intel-gfx is sufficient.
>
> /*
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
@ 2018-04-24 15:11 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2018-04-24 15:11 UTC (permalink / raw)
To: linux-kernel
Cc: David Airlie, intel-gfx, dri-devel, Rodrigo Vivi, Luc Van Oostenryck
On Tue, 24 Apr 2018, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote:
> All implementations of the method intel_dvo_dev_ops::mode_valid(), as
> well as the underlying struct drm_connector_helper_funcs::mode_valid()
> use 'enum drm_mode_status' for the method's return type but the
> declaration of intel_dvo_dev_ops::mode_valid() uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' for the declaration too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/gpu/drm/i915/dvo.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
> index 5e6a3013d..b6e143ebc 100644
> --- a/drivers/gpu/drm/i915/dvo.h
> +++ b/drivers/gpu/drm/i915/dvo.h
> @@ -74,7 +74,7 @@ struct intel_dvo_dev_ops {
> *
> * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
> */
> - int (*mode_valid)(struct intel_dvo_device *dvo,
> + enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
> struct drm_display_mode *mode);
Please adjust the alignment here as well. With that,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Oh, and as far as lists go, intel-gfx is sufficient.
>
> /*
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula
@ 2018-04-24 15:50 ` Patchwork
2018-04-24 16:05 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-24 20:08 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-24 15:50 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
URL : https://patchwork.freedesktop.org/series/42209/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e19139a5a800 drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
-:25: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#25: FILE: drivers/gpu/drm/i915/dvo.h:78:
+ enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
struct drm_display_mode *mode);
total: 0 errors, 0 warnings, 1 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula
2018-04-24 15:50 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-04-24 16:05 ` Patchwork
2018-04-24 20:08 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-24 16:05 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
URL : https://patchwork.freedesktop.org/series/42209/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4087 -> Patchwork_8792 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42209/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8792 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: PASS -> DMESG-WARN (fdo#106084) +1
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
== Participating hosts (37 -> 33) ==
Additional (1): fi-hsw-4770r
Missing (5): fi-ctg-p8600 fi-glk-j4005 fi-ilk-m540 fi-bxt-dsi fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4087 -> Patchwork_8792
CI_DRM_4087: d04fd4f6d93cea918521059db8358ff9e7a4a03b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4446: e5e8dafc991ee922ec159491c680caff0cfe9235 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8792: e19139a5a8007d6ad772ac85b539ca5976d592c5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4446: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit
== Linux commits ==
e19139a5a800 drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8792/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
` (2 preceding siblings ...)
2018-04-24 16:05 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-04-24 20:08 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-04-24 20:08 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: fix intel_dvo_dev_ops::mode_valid's return type
URL : https://patchwork.freedesktop.org/series/42209/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4087_full -> Patchwork_8792_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_8792_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_8792_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42209/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8792_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_rotation_crc@primary-rotation-90:
shard-apl: PASS -> DMESG-WARN
==== Warnings ====
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: SKIP -> PASS +2
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: PASS -> SKIP +1
== Known issues ==
Here are the changes found in Patchwork_8792_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@absolute-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#106087)
igt@kms_flip@flip-vs-dpms-off-vs-modeset:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
igt@kms_frontbuffer_tracking@fbc-farfromfence:
shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +29
igt@kms_sysfs_edid_timing:
shard-apl: PASS -> WARN (fdo#100047)
==== Possible fixes ====
igt@gem_eio@in-flight-immediate:
shard-glk: FAIL (fdo#105957) -> PASS
igt@kms_flip@dpms-vs-vblank-race-interruptible:
shard-hsw: FAIL (fdo#103060) -> PASS
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS +1
shard-hsw: FAIL (fdo#100368) -> PASS
==== Warnings ====
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> DMESG-FAIL (fdo#99912, fdo#103558)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105957 https://bugs.freedesktop.org/show_bug.cgi?id=105957
fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-glkb
== Build changes ==
* Linux: CI_DRM_4087 -> Patchwork_8792
CI_DRM_4087: d04fd4f6d93cea918521059db8358ff9e7a4a03b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4446: e5e8dafc991ee922ec159491c680caff0cfe9235 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8792: e19139a5a8007d6ad772ac85b539ca5976d592c5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4446: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8792/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-24 20:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] drm/i915: fix intel_dvo_dev_ops::mode_valid's return type Luc Van Oostenryck
2018-04-24 15:11 ` Jani Nikula
2018-04-24 15:11 ` Jani Nikula
2018-04-24 15:50 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-04-24 16:05 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-24 20:08 ` ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.