* [PATCH] staging: vboxvideo: fix mode_valid's return type
@ 2018-04-24 13:15 Luc Van Oostenryck
2018-04-24 13:20 ` [PATCH] " Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:15 UTC (permalink / raw)
To: linux-kernel
Cc: devel, Michael Thayer, Paolo Cretaro, Hans de Goede,
Greg Kroah-Hartman, Keith Packard, Cihangir Akturk,
Daniel Vetter, Peter Rosin, Luc Van Oostenryck
The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.
Fix this by using 'enum drm_mode_status' in the driver too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/staging/vboxvideo/vbox_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index b265fe924..5c7ea2378 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -573,7 +573,7 @@ static int vbox_get_modes(struct drm_connector *connector)
return num_modes;
}
-static int vbox_mode_valid(struct drm_connector *connector,
+static enum drm_mode_status vbox_mode_valid(struct drm_connector *connector,
struct drm_display_mode *mode)
{
return MODE_OK;
--
2.17.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vboxvideo: fix mode_valid's return type
2018-04-24 13:15 [PATCH] staging: vboxvideo: fix mode_valid's return type Luc Van Oostenryck
@ 2018-04-24 13:20 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2018-04-24 13:20 UTC (permalink / raw)
To: Luc Van Oostenryck, linux-kernel
Cc: Greg Kroah-Hartman, Cihangir Akturk, Daniel Vetter,
Michael Thayer, Peter Rosin, Keith Packard, Paolo Cretaro, devel
Hi,
On 24-04-18 15:15, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Thank you for the patch, looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/vboxvideo/vbox_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
> index b265fe924..5c7ea2378 100644
> --- a/drivers/staging/vboxvideo/vbox_mode.c
> +++ b/drivers/staging/vboxvideo/vbox_mode.c
> @@ -573,7 +573,7 @@ static int vbox_get_modes(struct drm_connector *connector)
> return num_modes;
> }
>
> -static int vbox_mode_valid(struct drm_connector *connector,
> +static enum drm_mode_status vbox_mode_valid(struct drm_connector *connector,
> struct drm_display_mode *mode)
> {
> return MODE_OK;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-24 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:15 [PATCH] staging: vboxvideo: fix mode_valid's return type Luc Van Oostenryck
2018-04-24 13:20 ` [PATCH] " Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.